Linux-mtd Archive on
 help / Atom feed
* [PATCH v2] mtd: rawnand: mtk: fix possible object reference leak
@ 2019-02-05 16:18 Wen Yang
  0 siblings, 0 replies; 1+ messages in thread
From: Wen Yang @ 2019-02-05 16:18 UTC (permalink / raw)
  To:, bbrezillon, miquel.raynal, richard, dwmw2,
	computersforpeace, marek.vasut
  Cc: Wen Yang, linux-kernel, ludovic.desroches, linux-mediatek,
	matthias.bgg, linux-mtd, linux-arm-kernel

of_find_device_by_node() takes a reference to the struct device
when it finds a match via get_device, there is no need to call
get_device() twice.
We also should make sure to drop the reference to the device
taken by of_find_device_by_node() on driver unbind.

Fixes: 1d6b1e464950 ("mtd: mediatek: driver for MTK Smart Device")
Signed-off-by: Wen Yang <>
Suggested-by: Miquel Raynal <>
Cc: Xiaolei Li <>
Cc: Boris Brezillon <>
Cc: Miquel Raynal <>
Cc: Richard Weinberger <>
Cc: David Woodhouse <>
Cc: Brian Norris <>
Cc: Marek Vasut <>
Cc: Matthias Brugger <>
v2->v1: Since there is the only one user, let's remove the err_put_device label.

 drivers/mtd/nand/raw/mtk_ecc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/mtk_ecc.c b/drivers/mtd/nand/raw/mtk_ecc.c
index 6432bd7..83a05b4 100644
--- a/drivers/mtd/nand/raw/mtk_ecc.c
+++ b/drivers/mtd/nand/raw/mtk_ecc.c
@@ -267,10 +267,13 @@ static struct mtk_ecc *mtk_ecc_get(struct device_node *np)
 	struct mtk_ecc *ecc;
 	pdev = of_find_device_by_node(np);
-	if (!pdev || !platform_get_drvdata(pdev))
+	if (!pdev)
+	if (!platform_get_drvdata(pdev)) {
+		put_device(&pdev->dev);
+	}
-	get_device(&pdev->dev);
 	ecc = platform_get_drvdata(pdev);

Linux MTD discussion mailing list

^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-05 16:18 [PATCH v2] mtd: rawnand: mtk: fix possible object reference leak Wen Yang

Linux-mtd Archive on

Archives are clonable:
	git clone --mirror linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ \
	public-inbox-index linux-mtd

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox