From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E53C2D0CE for ; Tue, 21 Jan 2020 12:23:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37B212073A for ; Tue, 21 Jan 2020 12:23:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XJvTTfHZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=micron.com header.i=@micron.com header.b="C2SdqW09" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37B212073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=micron.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rtNfIn3w2fI+iHMqTkOff009PhZvJGQAXvnveChryPQ=; b=XJvTTfHZimJ+Ai PtTL3scZWnBMBBAdRhr75zmfj4+bE5SsNFwg1Hz4Zdz7A9SVPSOBcMCJz8y4xyFJxKOwS8fNvphMB ryI22ZNSRQiFHZnXgKFeglyx33EshKjTqsXfjRAv1ykyjDp5TgyINoenzhAEkHPWt4N6q7js/1hZ3 YU2Q85OMEvn9GS8r8u3E+vaZk4oGyf0vYi6dobFJYdzwE+49CiE44GPW2nQ52v8fbHLbl8NohHz1m eoxrabMx7QcLy3rI0uGnVwfn5BxEIL7hD9o0o8qf230Uj1a7m3zCtvqAeSFqhCGP1z8O0LnlEH8W2 IA84KxsWkQobcb5Ogo8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1itsZ9-0005NZ-7K; Tue, 21 Jan 2020 12:23:31 +0000 Received: from mail-eopbgr680075.outbound.protection.outlook.com ([40.107.68.75] helo=NAM04-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1itsZ1-0005Mu-KY for linux-mtd@lists.infradead.org; Tue, 21 Jan 2020 12:23:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRlVTWtqR5g21jhapZZ4A7t05V6NLoKTst2fypA2DKqPTfC1jzLx7SVwr2JGSnunLFR2gEUQgR5wu4TLgZvZR4Rz3IBW9MnMbjg9Oa/YDX5HVm03g8km7ZJFh4VHMpcE4HDEgUJKBo811nnOJCj1JgR9jTQrvm6wzIM8kxon6wyI8RfFf1o/IoWXnxY+MOfAXfA4tV7y0Ik/apCt+zbIQeBaGWxOtIo1Apln9sOvhaUgK1SNtso95k6+7AblF9BWoIKf7WFnOLud30uG0YMhKu0224x2uzHQjTVx5ejB4fKkeuGT5hT0zNTkWsQuRln21R0HClPCouBqgHrfyJ0lxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gwQiUZmfKlDzitUKrz5GZy7FwddUcS/XIGunNuGweFA=; b=Jy39PU6w6w91HCygPAmYt61TN5ePKbrKUyKNeuKO8agms03dc3fLqDr9i1boCU3y2V96uvGqN1HWUPvUsG1ZjlFXi3VDOytlqX9aKCrpXBwiuJE1aFdAMwdmkMtXDrsNsU55QdbwOGsVLWeVzIMbdDIJsw0RkzPm6r32KbXAdgVV7yvMNyLQq2iGLbNNEA1sx+xK8eiul6i2d1En072AK3eQFyMcPx0kYl73ZZelLWXByba9S496J/qP8XNdRk62KvQ4i+XMYvg2DTKolT7vBgsrSMb8jeh+WypZwmubnqSqjX7Pfi3ciMA3kHdjmhtkzWfmnSqzn5I6JeSNDJ/JFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=micron.com; dmarc=pass action=none header.from=micron.com; dkim=pass header.d=micron.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=micron.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gwQiUZmfKlDzitUKrz5GZy7FwddUcS/XIGunNuGweFA=; b=C2SdqW09rvMmvB7tm8A38y3hLDJbb7m+wooTjhv4aJnIeemH7cFSNs22fkxmfQh03zGOjq593mf8dyH9C6My2K7f2PcR5QXlCzQpkoMd8AQBlyAR5muoxHDyT8DbvxqP4RuiHfUlRXZylelVc77x7AFG+xfm8cNFydsIaHdMN2U= Received: from MN2PR08MB6397.namprd08.prod.outlook.com (52.132.170.74) by MN2PR08MB6206.namprd08.prod.outlook.com (52.132.168.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.20; Tue, 21 Jan 2020 12:23:20 +0000 Received: from MN2PR08MB6397.namprd08.prod.outlook.com ([fe80::61af:ed8:e19b:cb6a]) by MN2PR08MB6397.namprd08.prod.outlook.com ([fe80::61af:ed8:e19b:cb6a%3]) with mapi id 15.20.2644.027; Tue, 21 Jan 2020 12:23:20 +0000 From: "Shivamurthy Shastri (sshivamurthy)" To: Miquel Raynal Subject: RE: [EXT] Re: [PATCH 3/4] mtd: spinand: Add M70A series Micron SPI NAND devices Thread-Topic: [EXT] Re: [PATCH 3/4] mtd: spinand: Add M70A series Micron SPI NAND devices Thread-Index: AQHVz3qxhHT4F5gqHEqpiIf5nVR3gqfzXyrA Date: Tue, 21 Jan 2020 12:23:20 +0000 Message-ID: References: <20200119145432.10405-1-sshivamurthy@micron.com> <20200119145432.10405-4-sshivamurthy@micron.com> <20200120111626.7cb2f6c5@xps13> In-Reply-To: <20200120111626.7cb2f6c5@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc3NoaXZhbXVydGh5XGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0YmEyOWUzNWJcbXNnc1xtc2ctY2Q5ZTAwNjMtM2M0OC0xMWVhLWIxZTMtOTgzYjhmNzQ1MjUxXGFtZS10ZXN0XGNkOWUwMDY1LTNjNDgtMTFlYS1iMWUzLTk4M2I4Zjc0NTI1MWJvZHkudHh0IiBzej0iNDM2NSIgdD0iMTMyMjQwODI5OTgzNDIwNzUyIiBoPSJENEllMVVhU3pnR0JJV21yY0xkV2pUYjZKU0U9IiBpZD0iIiBibD0iMCIgYm89IjEiLz48L21ldGE+ authentication-results: spf=none (sender IP is ) smtp.mailfrom=sshivamurthy@micron.com; x-originating-ip: [165.225.80.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fc5ed83-ea0d-4175-9f75-08d79e6cb3c5 x-ms-traffictypediagnostic: MN2PR08MB6206:|MN2PR08MB6206:|MN2PR08MB6206: x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0289B6431E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(39860400002)(346002)(376002)(136003)(189003)(199004)(64756008)(66556008)(26005)(66946007)(478600001)(66446008)(186003)(54906003)(71200400001)(66476007)(55236004)(6506007)(8936002)(76116006)(81156014)(81166006)(316002)(8676002)(6916009)(66574012)(86362001)(55016002)(4326008)(5660300002)(7696005)(52536014)(33656002)(2906002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR08MB6206; H:MN2PR08MB6397.namprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: micron.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZaFMRp8xKyasSvyD40mM4SNG10KV3nUkoDrDX5BfX/F33vFTjKSm4FWC8siBuhuR7u4WzEbYdTKq0FABj2Th+L7p2PynDIjWytVkt9J42NGSJpdSkG7g6ug3dyB1Fhv2Y9/VJXq5oUdz3KsrOkOWP6Mr7wWLBlIFWJtk4gkLXP/w/4J1iXo9drroFxvaEmX0yODoETzi/Lfo4gwD4fzOYdJuRhwiWD60BiwewRaACylsTz1aPLwZ6yVae9bxh1ZBsIc7ENWF/FTv+N/2jZOOF+EiPmYeENXJ66ANPQpX3ve5qNWtIqrur5Y+f2aMuakbwL8DJx/xSyoPlnujTAepCkQF79xwWL5mNI68sh2QXjbHerf+GFxWHRNU2Rd+WsdvOQ/v3LkjAhTYbP0nseBo9dwd7j2zy+SF4YMnJfbZH4wBzooa3u8nigyw9XtahfGv MIME-Version: 1.0 X-OriginatorOrg: micron.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fc5ed83-ea0d-4175-9f75-08d79e6cb3c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2020 12:23:20.4649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3TMww87rkb/cdCPh5qRYSd2N/3LOFpOFz6RxoU6NmsuyD68WssxjG50LJw3dXvQ3pPF9zmPBxRl2ywWeKCZFrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR08MB6206 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200121_042323_740897_B8A77405 X-CRM114-Status: GOOD ( 22.93 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Boris Brezillon , Shivamurthy Shastri , Richard Weinberger , "linux-kernel@vger.kernel.org" , Frieder Schrempf , "linux-mtd@lists.infradead.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Miquel, > = > Hi Shiva, > = > This is remark common to the four patches: you miss the 'v2' prefix in > the object. > = Sorry for this mistake. I recognized this after sending out the patches. > shiva.linuxworks@gmail.com wrote on Sun, 19 Jan 2020 15:54:31 +0100: > = > > From: Shivamurthy Shastri > > > > Add device table for M70A series Micron SPI NAND devices. > > > > While at it, disable the Continuous Read feature which is enabled by > > default. > = > Can you please give us more detail on why this is an issue? "Continuous Read" is the new feature added by the Micron for = M70A series devices. If this feature is enabled, the READ command = doesn't output the OOB area. The following short description describes this feature. Description: If the Continuous Read feature is enabled, the device provides = the capability to read the whole block with a single command. However, the read command doesn't output the OOB area. Read command behavior (if Continuous Read enabled): The READ CACHE command doesn't require the starting column address. The device always output the data starting from the first column of the cache register, and once the end of the cache register reached, the data output continues through the next page. With the continuous read mode, it is possible to read out the entire block using a single READ command, and once the end of the block reached, the output pins become High-Z state. > = > Shall we backport it to stable? This is not a bug fix and applicable only to M70A series devices, there is = no need to backport. (FYI, the previously enabled device was M79A series) > = > As a rule of thumb, when you start a sentence by "while at it" in a > commit message and this is not a trivial change : split the patch, > please. Unless this is really related and in this case explain how and > why in the commit message. Okay, I will explain in my next version. > = > > > > Signed-off-by: Shivamurthy Shastri > > --- > > drivers/mtd/nand/spi/micron.c | 31 > +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/drivers/mtd/nand/spi/micron.c > b/drivers/mtd/nand/spi/micron.c > > index 5fd1f921ef12..45fc37c58f8a 100644 > > --- a/drivers/mtd/nand/spi/micron.c > > +++ b/drivers/mtd/nand/spi/micron.c > > @@ -131,6 +131,26 @@ static const struct spinand_info > micron_spinand_table[] =3D { > > 0, > > SPINAND_ECCINFO(µn_8_ooblayout, > > micron_8_ecc_get_status)), > > + /* M70A 4Gb 3.3V */ > > + SPINAND_INFO("MT29F4G01ABAFD", 0x34, > > + NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), > > + NAND_ECCREQ(8, 512), > > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > > + &write_cache_variants, > > + &update_cache_variants), > > + 0, > > + SPINAND_ECCINFO(µn_8_ooblayout, > > + micron_8_ecc_get_status)), > > + /* M70A 4Gb 1.8V */ > > + SPINAND_INFO("MT29F4G01ABBFD", 0x35, > > + NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), > > + NAND_ECCREQ(8, 512), > > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > > + &write_cache_variants, > > + &update_cache_variants), > > + 0, > > + SPINAND_ECCINFO(µn_8_ooblayout, > > + micron_8_ecc_get_status)), > > }; > > > > static int micron_spinand_detect(struct spinand_device *spinand) > > @@ -153,8 +173,19 @@ static int micron_spinand_detect(struct > spinand_device *spinand) > > return 1; > > } > > > > +static int micron_spinand_init(struct spinand_device *spinand) > > +{ > > + /* > > + * M70A device series enable Continuous Read feature at Power-up, > > + * which is not supported. Disable this bit to avoid any possible > > + * failure. > > + */ > > + return spinand_upd_cfg(spinand, CFG_QUAD_ENABLE, 0); > > +} > > + > > static const struct spinand_manufacturer_ops > micron_spinand_manuf_ops =3D { > > .detect =3D micron_spinand_detect, > > + .init =3D micron_spinand_init, > > }; > > > > const struct spinand_manufacturer micron_spinand_manufacturer =3D { > = > Thanks, > Miqu=E8l Thanks, Shiva ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/