From: masonccyang@mxic.com.tw
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: kstewart@linuxfoundation.org, vigneshr@ti.com,
bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at,
linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de,
marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
tglx@linutronix.de, computersforpeace@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCH] Add support for Macronix NAND randomizer
Date: Thu, 29 Aug 2019 17:07:51 +0800 [thread overview]
Message-ID: <OF22C5A579.E2E7676F-ON48258465.002F7F69-48258465.00322849@mxic.com.tw> (raw)
In-Reply-To: <20190824130329.68f310aa@xps13>
Hi Miquel,
> >
> > If subpage write not available with hardware ECC, for example,
> > NAND chip options NAND_NO_SUBPAGE_WRITE be set in driver and
> > randomizer function is recommended for high-reliability.
> > Driver checks byte 167 of Vendor Blocks in ONFI parameter page table
> > to see if this high-reliability function is supported.
> >
>
> You did not flagged this patch as a v2 and forgot about the changelog.
> You did not listen to our comments in the last version neither. I was
> open to a solution with a specific DT property for warned users but I
> don't see it coming.
>
Based on your comments by specific DT property for randomizer support.
to add a new property in children nodes:
i.e,.
nand: nand-controller@43c30000 {
nand@0 {
reg = <0>;
nand-reliability = "randomizer";
};
};
file of nand_macronix.c will patch to:
static void macronix_nand_onfi_init(struct nand_chip *chip)
{
struct nand_parameters *p = &chip->parameters;
struct device_node *dn = nand_get_flash_node(chip);
const char *pm;
int rand_enable = 0;
ret = of_property_read_string(dn, "nand-reliability", &pm);
if (!ret) {
if (!strcasecmp(pm, "randomizer"));
rand_enable = 1;
}
mxic = (struct nand_onfi_vendor_macronix *)p->onfi->vendor;
if (rand_enable &&
mxic->reliability_func & MACRONIX_RANDOMIZER_BIT) {
if (p->supports_set_get_features) {
bitmap_set(p->set_feature_list,
ONFI_FEATURE_ADDR_MXIC_RANDOMIZER, 1);
bitmap_set(p->get_feature_list,
ONFI_FEATURE_ADDR_MXIC_RANDOMIZER, 1);
/* set-up chip options with NAND_NO_SUBPAGE_WRITE
*/
chip->options |= NAND_NO_SUBPAGE_WRITE;
macronix_nand_randomizer_check_enable(chip);
}
}
}
something like this,
is it OK ?
thanks & best regards,
Mason
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-08-29 9:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 5:53 [PATCH] Add support for Macronix NAND randomizer Mason Yang
2019-08-24 11:03 ` Miquel Raynal
2019-08-26 2:52 ` masonccyang
2019-08-26 7:23 ` Miquel Raynal
2019-08-26 9:24 ` masonccyang
2019-08-29 9:07 ` masonccyang [this message]
2019-08-30 9:51 ` Miquel Raynal
2019-09-02 6:53 ` masonccyang
2019-09-02 7:05 ` Richard Weinberger
2019-09-02 7:39 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF22C5A579.E2E7676F-ON48258465.002F7F69-48258465.00322849@mxic.com.tw \
--to=masonccyang@mxic.com.tw \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@kontron.de \
--cc=juliensu@mxic.com.tw \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).