From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B829C7619D for ; Mon, 17 Feb 2020 08:15:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC5C020718 for ; Mon, 17 Feb 2020 08:15:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fGoSDp2r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC5C020718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mxic.com.tw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:From:Message-ID:MIME-Version: Subject:To:References:In-Reply-To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LiTfv8N1Obk2oOxOYhszzrCkt4I6SqlBSmvBcsftMLU=; b=fGoSDp2rhBEDlA cFEbzQjscI/t2m1hqK3YhG6iWlJa1RGCT/6QKu1y17KVPuaJLuafxMX/RBKqRK8L83anMX9uO3r9c kGC4Pkva6ZHpDRUT/XVo80kH0sEdKK8Gl3Pco8nPmoaXRSmjrXKYaGC87VXifiw5KQX2Ee9BGlJ5j FR3nbZFPnrRCeXSSsPkdiKpBQogG9uNxyht5yHBR+KvLKyysWi/M8jEP84Zk7UcOG/ancqTg2K4Zz cashK+GUfsPcajsT+Hu+zzpiW+CY/butxIL+ABkIpBsf3svl1xYeXIKcdwh/+12yRBiCUZgO4dIfu s4lWNXbOiGGYpS7yk7Zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3bYP-0004kM-6H; Mon, 17 Feb 2020 08:14:57 +0000 Received: from twhmllg3.macronix.com ([211.75.127.131]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3bYM-0004k5-3V for linux-mtd@lists.infradead.org; Mon, 17 Feb 2020 08:14:55 +0000 Received: from twhfmlp1.macronix.com (twhfm1p1.macronix.com [172.17.20.91]) by TWHMLLG3.macronix.com with ESMTP id 01H8ENdB073564; Mon, 17 Feb 2020 16:14:23 +0800 (GMT-8) (envelope-from masonccyang@mxic.com.tw) Received: from MXML06C.mxic.com.tw (mxml06c.macronix.com [172.17.14.55]) by Forcepoint Email with ESMTP id 330F75CF8CA615BE2FE8; Mon, 17 Feb 2020 16:14:24 +0800 (CST) In-Reply-To: <20200109203055.2370a358@collabora.com> References: <1572256527-5074-1-git-send-email-masonccyang@mxic.com.tw> <1572256527-5074-2-git-send-email-masonccyang@mxic.com.tw> <20200109203055.2370a358@collabora.com> To: "Boris Brezillon" Subject: Re: [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin MIME-Version: 1.0 X-KeepSent: 505D0437:0130F15A-48258511:002C7F75; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3FP4 SHF90 June 10, 2013 Message-ID: From: masonccyang@mxic.com.tw Date: Mon, 17 Feb 2020 16:14:23 +0800 X-MIMETrack: Serialize by Router on MXML06C/TAIWAN/MXIC(Release 9.0.1FP10 HF265|July 25, 2018) at 2020/02/17 PM 04:14:24, Serialize complete at 2020/02/17 PM 04:14:24 X-MAIL: TWHMLLG3.macronix.com 01H8ENdB073564 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_001454_403438_9AAA14AE X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at, linux-kernel@vger.kernel.org, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Boris, > > > /* Set default functions */ > > static void nand_set_defaults(struct nand_chip *chip) > > { > > @@ -5782,8 +5810,8 @@ static int nand_scan_tail(struct nand_chip *chip) > > mtd->_read_oob = nand_read_oob; > > mtd->_write_oob = nand_write_oob; > > mtd->_sync = nand_sync; > > - mtd->_lock = NULL; > > - mtd->_unlock = NULL; > > + mtd->_lock = nand_lock; > > + mtd->_unlock = nand_unlock; > > mtd->_suspend = nand_suspend; > > mtd->_resume = nand_resume; > > mtd->_reboot = nand_shutdown; > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > index 4ab9bcc..2430ecd 100644 > > --- a/include/linux/mtd/rawnand.h > > +++ b/include/linux/mtd/rawnand.h > > @@ -1136,6 +1136,9 @@ struct nand_chip { > > const struct nand_manufacturer *desc; > > void *priv; > > } manufacturer; > > + > > + int (*_lock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > > + int (*_unlock)(struct nand_chip *chip, loff_t ofs, uint64_t len); > > Please drop this _ prefix. Drop _ prefix of _lock will get compile error due to there is already defined "struct mutex lock" in struct nand_chip. What about keep this _ prefix or patch it to blocklock/blockunlock, i.e., int (*blocklock)(struct nand_chip *chip, loff_t ofs, uint64_t len); int (*blockunlock)(struct nand_chip *chip, loff_t ofs, uint64_t len); thanks for your time & comments. Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/