From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18111ECE58C for ; Tue, 8 Oct 2019 02:33:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF4DD20867 for ; Tue, 8 Oct 2019 02:33:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="joZJDOD2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF4DD20867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mxic.com.tw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:From:Message-ID:MIME-Version: Subject:To:References:In-Reply-To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mIZlkTjHjfLUTkRKIAHafwdIq1LNsRVFU4r65mXQ4U0=; b=joZJDOD2qLZKF9 U47fSVYDaBiqhvNCSHHvchc6TdAqGlyLnzxl1DfhNNWFhtuZpXp47lo/JUtOKjmRTNxJpxGdG/dch Jfo64SDkiul2t26V4Wa3ozU1h/T1na/6lqLwJE0449trnz060eDLSV9WcNmRDmB8KCgvTBCtMpi3p v2z0t32J3o2crMAItsEY6DCKC2AvqN599pLkVZAhmBbJkE0GjISa6mqGDOpGDpLIigkk6kpoXNDYN /hISeKZ1VhBU+ZeLBMNnV8vqWVlVEjMn7R5mFS2Zuc9R6+6HIGPjXL3TW+vQIVDCmWgWrAP1MHQhT dGVrfga3U5UtsLNkPo6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHfJu-0006PH-SQ; Tue, 08 Oct 2019 02:33:50 +0000 Received: from twhmllg3.macronix.com ([211.75.127.131]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHfJr-0006Oi-QU for linux-mtd@lists.infradead.org; Tue, 08 Oct 2019 02:33:49 +0000 Received: from twhfmlp1.macronix.com (twhfm1p1.macronix.com [172.17.20.91]) by TWHMLLG3.macronix.com with ESMTP id x982XAwX085399; Tue, 8 Oct 2019 10:33:10 +0800 (GMT-8) (envelope-from masonccyang@mxic.com.tw) Received: from MXML06C.mxic.com.tw (mxml06c.mxic.com.tw [172.17.14.55]) by Forcepoint Email with ESMTP id 0E9BF9080964A92859FC; Tue, 8 Oct 2019 10:33:11 +0800 (CST) In-Reply-To: <20191007112442.783e4fbe@xps13> References: <1568793387-25199-1-git-send-email-masonccyang@mxic.com.tw> <1568793387-25199-2-git-send-email-masonccyang@mxic.com.tw> <20191007104511.5aa7b8f2@xps13> <20191007112442.783e4fbe@xps13> To: "Miquel Raynal" Subject: Re: [PATCH RFC 2/3] mtd: rawnand: Add support Macronix Block Protection function MIME-Version: 1.0 X-KeepSent: EDE76FEE:8BC48D9E-4825848D:000BCC94; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3FP4 SHF90 June 10, 2013 Message-ID: From: masonccyang@mxic.com.tw Date: Tue, 8 Oct 2019 10:33:11 +0800 X-MIMETrack: Serialize by Router on MXML06C/TAIWAN/MXIC(Release 9.0.1FP10 HF265|July 25, 2018) at 2019/10/08 AM 10:33:11, Serialize complete at 2019/10/08 AM 10:33:11 X-MAIL: TWHMLLG3.macronix.com x982XAwX085399 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_193348_108207_A3EA37AC X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, bbrezillon@kernel.org, juliensu@mxic.com.tw, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, frieder.schrempf@kontron.de, marcel.ziswiler@toradex.com, linux-mtd@lists.infradead.org, richard@nod.at, tglx@linutronix.de, computersforpeace@gmail.com, dwmw2@infradead.org, marek.vasut@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Miquel, > > > > > Macronix AC series support using SET/GET_FEATURES to change > > > Block Protection and Unprotection. > > > > > > MTD default _lock/_unlock function replacement by manufacturer > > > postponed initialization. > > > > Why would we do that? > > > > Anyway your solution looks overkill, if we ever decide to > > implement these hooks for raw nand, it is better just to not > > overwrite them in nand_scan_tail() if they have been filled > > previously (ie. by the manufacturer code). > > Actually you should add two NAND hooks that do the interface with the > MTD hooks. In the NAND hooks, check that the request is to lock all the > device, otherwise return -ENOTSUPP. sorry, can't get your point. Because the NAND entire chip will be protected if PT(protection) pin is active high at power-on. > > Then fill-in these two hooks from the manufacturer code, without the > postponed init. > But in the final of nand_scan_tail(), mtd->_lock/_unlock will be filled by NULL, right ? thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/