From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187D1C4321A for ; Fri, 28 Jun 2019 09:10:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE7F4208CB for ; Fri, 28 Jun 2019 09:10:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gnycWDMc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE7F4208CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mxic.com.tw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:From:Message-ID:MIME-Version: Subject:To:References:In-Reply-To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DddxRrpTcXTqU6oIGLKyhpLPI3sxT1SnJVr2ZfMfsyk=; b=gnycWDMcgWoa0B wxur0/SrEL7GG8JqsCnwRGT0PSeThlNCGZ1Izm3X+/PAFnfTHoe3xziFkPx6ri7GQ2YtlX8fKFH8p 34Oml7+fmOeh571l5C/xViuGFCK19xI12eTqHKup/NgY7NbIvWPqXRNuJsiWG0NzCK3Gv0Y0NGk7/ hOoy4rxP+DlosNjtTwapq1YHZfeohRwDQb/GPNrLdcaB/b4Rt5f4u9xq/RdJeGnSJ/bvRYhmbJIIy qSFKWOCiRk9sgJ0aO5sjMmmCgK2RgYrmDq++eEpu6QQFLGZ54k7DfogyRf/S8NHrVG14yF4iIztBL KkDMSs0qOkhhDxrI8v+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgmtT-00007b-S8; Fri, 28 Jun 2019 09:10:08 +0000 Received: from twhmllg3.macronix.com ([122.147.135.201]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgmtO-0007wr-Da for linux-mtd@lists.infradead.org; Fri, 28 Jun 2019 09:10:05 +0000 Received: from twhfmlp1.macronix.com (twhfm1p1.macronix.com [172.17.20.91]) by TWHMLLG3.macronix.com with ESMTP id x5S99G0c007723; Fri, 28 Jun 2019 17:09:16 +0800 (GMT-8) (envelope-from masonccyang@mxic.com.tw) Received: from MXML06C.mxic.com.tw (mxml06c.macronix.com [172.17.14.55]) by Forcepoint Email with ESMTP id 5F2865BB3BC9A59DC514; Fri, 28 Jun 2019 17:09:16 +0800 (CST) In-Reply-To: <20190628094250.1fd84505@xps13> References: <1561443056-13766-1-git-send-email-masonccyang@mxic.com.tw> <1561443056-13766-3-git-send-email-masonccyang@mxic.com.tw> <20190627192609.0965f6d5@xps13> <20190628094250.1fd84505@xps13> To: "Miquel Raynal" Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings MIME-Version: 1.0 X-KeepSent: F895B48A:00F391C1-48258427:002F8256; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3FP4 SHF90 June 10, 2013 Message-ID: From: masonccyang@mxic.com.tw Date: Fri, 28 Jun 2019 17:09:16 +0800 X-MIMETrack: Serialize by Router on MXML06C/TAIWAN/MXIC(Release 9.0.1FP10 HF265|July 25, 2018) at 2019/06/28 PM 05:09:16, Serialize complete at 2019/06/28 PM 05:09:16 X-MAIL: TWHMLLG3.macronix.com x5S99G0c007723 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190628_021002_767915_32649EB5 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, christophe.kerello@st.com, vigneshr@ti.com, jianxin.pan@amlogic.com, bbrezillon@kernel.org, juliensu@mxic.com.tw, lee.jones@linaro.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, paul@crapouillou.net, marek.vasut@gmail.com, paul.burton@mips.com, broonie@kernel.org, linux-mtd@lists.infradead.org, stefan@agner.ch, richard@nod.at, anders.roxell@linaro.org, liang.yang@amlogic.com, computersforpeace@gmail.com, dwmw2@infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Miquel, > > Please always Cc: Rob (robh+dt@kernel.org) when you send bindings > related patches. Understood. thanks for your remind. > > > > > > > > > +- reg: should contain 1 entrie for the registers > > > > > > entry > > > > > > > +- reg-names: should contain "regs" > > > > > > Not sure you need that? > > > > for a base address of ctlr registers. > > Yes I know, I mean: you don't necessarily need the 'reg-names' property > as it is supposed that the only entry will be the IP registers (unless > there are more). I don't know what's Rob preference here but I would > either drop the reg-names property or enhance the name, "regs" is > terribly not descriptive. Got it, any comment is appreciated for either drop the reg-names property or enhance the name. > > > > > +- interrupts: interrupt line connected to this NAND controller > > > > +- clock-names: should contain "ps_clk", "send_clk" and "send_dly_clk" > > > > +- clocks: should contain 3 entries for the "ps_clk", "send_clk" and > > > > + "send_dly_clk" clocks > > > > > > s/entries/phandles/ ? > > > > ? > > as I know that kernel views the phandle values as device tree structure > > information instead of device tree data and thus does not store them as > > properties. > > The bindings have nothing to do with the kernel views. They might > actually be merged in a different project, out of the kernel. > if patch to phandle, should we also patch driver to of_xxx_phandle()? thanks & best regards, Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/