From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Oleksandr Ocheretnyi -X (oocheret - GLOBALLOGIC INC at Cisco)"
<oocheret@cisco.com>
Cc: "tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"p.yadav@ti.com" <p.yadav@ti.com>,
"michael@walle.cc" <michael@walle.cc>,
"richard@nod.at" <richard@nod.at>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"mauro.lima@eclypsium.com" <mauro.lima@eclypsium.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>
Subject: Re: [PATCH v2] mtd: spi-nor: handle unsupported FSR opcodes properly
Date: Fri, 17 Jun 2022 08:04:40 +0300 [thread overview]
Message-ID: <YqwLaIvjdRBsNRuU@lahna> (raw)
In-Reply-To: <BYAPR11MB2757BD90C63B9F6A31E0600ACDAC9@BYAPR11MB2757.namprd11.prod.outlook.com>
Hi,
On Thu, Jun 16, 2022 at 08:26:33PM +0000, Oleksandr Ocheretnyi -X (oocheret - GLOBALLOGIC INC at Cisco) wrote:
> Hi Mika,
>
> > However I remember you caught situation where
> micron_st_nor_read_fsr()
> > returns -EOPNOTSUPP
> > (intel_spi_exec_mem_op callback returns -EOPNOTSUPP), according to
> your
> > patch
> >
> [3]https://lore.kernel.org/linux-mtd/20220506105158.43613-1-mika.wester
> > berg@linux.intel.com/ I've noted in description body. So I think I
> have
> > to cover both errorcodes, haven't I?
> I was thinking that you change the both functions in Intel SPI to
> return
>
> -ENOTSUPP, not just one.
>
> you know 'drivers/mtd/spi-nor' sources use -EOPNOTSUPP errorcode only,
> however
>
> 'drivers/spi' modules (where intel driver is located as well as
> spi-mem.c) use both errorcodes many times
>
> (-EOPNOTSUPP and -ENOTSUPP).
Oh, indeed. I remembered that SPI-NOR core was using ENOTSUP but it was
SPI-MEM instead.
> So maybe it is better to use -EOPNOTSUPP for intel driver file (what
> uses -EOPNOTSUPP everywhere) and
>
> update the spi-mem.c with -EOPNOTSUPP as return value, how do you
> think?
Yes, I think this is the correct approach. You need to be careful though
to make sure the callers of SPI-MEM functions do not get unexpected
values.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-06-17 5:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BYAPR11MB27570C5DC510D0F37FC106E4CDF69@BYAPR11MB2757.namprd11.prod.outlook.com>
2022-04-25 7:55 ` mtd: spi-nor: fatal issue during the mtd_erase() calls mika.westerberg
2022-06-10 19:15 ` [PATCH] mtd: spi-nor: handle unsupported FSR opcodes properly Oleksandr Ocheretnyi
2022-06-13 6:18 ` Mika Westerberg
[not found] ` <BYAPR11MB27570F2863F7BCDFE629B3DFCDAA9@BYAPR11MB2757.namprd11.prod.outlook.com>
2022-06-15 9:49 ` Mika Westerberg
2022-06-15 18:10 ` Michael Walle
2022-06-15 19:11 ` [PATCH v2] " Oleksandr Ocheretnyi
2022-06-15 19:25 ` Mark Brown
2022-06-16 5:31 ` Mika Westerberg
[not found] ` <BYAPR11MB2757B1146457E3860389F4D1CDAC9@BYAPR11MB2757.namprd11.prod.outlook.com>
2022-06-16 10:35 ` Mika Westerberg
2022-06-16 12:14 ` Oleksandr Ocheretnyi
2022-06-16 12:33 ` Mika Westerberg
[not found] ` <BYAPR11MB2757CEBE99C3A0861928CD43CDAC9@BYAPR11MB2757.namprd11.prod.outlook.com>
2022-06-16 12:59 ` Mika Westerberg
[not found] ` <BYAPR11MB2757BD90C63B9F6A31E0600ACDAC9@BYAPR11MB2757.namprd11.prod.outlook.com>
2022-06-17 5:04 ` Mika Westerberg [this message]
2022-07-19 9:12 ` Tudor.Ambarus
2022-06-16 5:29 ` [PATCH] " Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqwLaIvjdRBsNRuU@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mauro.lima@eclypsium.com \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=oocheret@cisco.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).