linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <tom@tom-fitzhenry.me.uk>, <p.yadav@ti.com>, <michael@walle.cc>,
	<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2] mtd: spi-nor: siliconkaiser: add support for sk25lp128
Date: Sun, 7 Aug 2022 16:01:16 +0000	[thread overview]
Message-ID: <a6c6911d-15e7-56d9-0ced-d3d87c94acf6@microchip.com> (raw)
In-Reply-To: <8757e6d6-666b-433f-3089-621e7c80cf9e@tom-fitzhenry.me.uk>

On 8/6/22 18:22, Tom Fitzhenry wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 21/7/22 18:08, Tudor.Ambarus@microchip.com wrote:
>> Does this flash implement the manufacturer ID continuation codes?
>> Can you read more bytes of manufacturer ID and dump them?
> 
> I'm not sure how to do this, but from what I can gather, flash chips
> that implement manufacturer ID continuation codes return >3 bytes in
> response to RDID. Is this correct?
> 
> To do this, in tools/spi/spidex_fdx.c I set buf[0] = 0x9F, and then
> executed this with a large recvbuf:
> 
> $ sudo ./a.out -m 6 /dev/spidev0.0
> /dev/spidev0.0: spi mode 0x0, 8 bits per word, 10000000 Hz max
> response( 6,  7):  25 70 18 25 70 18

indeed it seems there are no continuation codes.
> 
> It looks like the 3-byte response has cycled, suggesting this flash chip
> does not implement continuation codes.
> 
>> If the flash does not define the continuation codes, we'll need to
>> add this flash in a ID collisions driver.
> 
> I will do this in v3.

Not yet, please. Looks like your flash does not need some special handling,
you used just the SNOR_ID3. If so, then you won't need a flash entry at all,
we can init the flash solely by parsing SFDP. See:
https://lore.kernel.org/linux-mtd/20220513133520.3945820-1-michael@walle.cc/

-- 
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2022-08-07 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 14:16 [PATCH v2] mtd: spi-nor: siliconkaiser: add support for sk25lp128 Tom Fitzhenry
2022-07-21  8:08 ` Tudor.Ambarus
2022-08-06 15:22   ` Tom Fitzhenry
2022-08-07 16:01     ` Tudor.Ambarus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6c6911d-15e7-56d9-0ced-d3d87c94acf6@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=tom@tom-fitzhenry.me.uk \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).