From: Krzysztof Kozlowski <firstname.lastname@example.org>
To: Mikhail Zhilkin <email@example.com>,
Miquel Raynal <firstname.lastname@example.org>,
Richard Weinberger <email@example.com>,
Vignesh Raghavendra <firstname.lastname@example.org>,
Rob Herring <email@example.com>,
Krzysztof Kozlowski <firstname.lastname@example.org>
Cc: NOGUCHI Hiroshi <email@example.com>, Karim <Karimdplay@gmail.com>,
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser
Date: Fri, 29 Apr 2022 22:22:10 +0200 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On 29/04/2022 17:26, Mikhail Zhilkin wrote:
> On 4/29/2022 9:46 AM, Krzysztof Kozlowski wrote:
>>>> I am sorry, but you changed now a lot in the bindings and it looks
>>>> entirely different. Things previously being correct now are wrong, so
>>>> rather start from your old bindings...
>>> Looks like I'm a bit confused... I use dual "compatible" in my real dts
>>> and I realized that:
>>> 1. Therefore I have to use dual "compatible" in example too:
>>> compatible = "sercomm,sc-partitions", "fixed-partitions";
>>> 2. When I'm trying to reuse "fixed-partitions" compatible from
>>> fixed-partitions.yaml in my new .yaml I get "too long" errors.
>> Yes, the fixed-partitions.yaml would have to be changed to allow extension.
>>> Real dts:
>>> So, I currently found another solution - to extend fixed-partitions.yaml
>>> with "sercomm,sc-partitions". Is It ok from your side? Can I use this
>>> code in v3?
>> Not really, I don't understand why do you need it
> The main idea is keeping original Sercomm firmware behavior:
> 1. If dynamic partition map found then use offsets and mtd sizes stored
> in partition map. It's provided by "sercomm,sc-partitions" compatible.
> 2. If dynamic partition map doesn't exist or broken then default values
> (from dts) are used. It's provided by "fixed-partitions" compatible.
Then you need to adjust fixed-partitions for such case. See syscon case
(all over the tree and Documentation/devicetree/bindings/mfd/syscon.yaml).
>> and it does not
>> include our previous talks.
> At the time, I didn't realize how important is it. Understanding began
> to come after dozens of experiments and checking the similar Linux patches.
>>> diff --git
>>> index ea4cace6a955..9eebe39a57fb 100644
>>> --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
>>> @@ -19,7 +19,11 @@ maintainers:
>>> - const: fixed-partitions
>>> + oneOf:
>>> + - const: fixed-partitions
>>> + - items:
>>> + - const: sercomm,sc-partitions
>>> + - const: fixed-partitions
>>> "#address-cells": true
>>> @@ -27,7 +31,18 @@ properties:
>>> - $ref: "partition.yaml#"
>>> + allOf:
>>> + - $ref: "partition.yaml#"
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: sercomm,sc-partitions
>>> + then:
>>> + properties:
>>> + scpart-id:
>> It still misses vendor prefix and we agreed you don't need it, didn't we?
> Do you mean "sercomm" vendor prefix? If so then we agreed that I include
> it in a separate patch:
There was some misunderstanding then. We talk here about scpart-id name.
Adding vendor prefix cannot be a separate patch because it does not make
much sense. You add new property with wrong name and immediately
change/fix it in next patch.
No, it should have proper name since beginning. The property is not used
in the kernel.
> I'm going to send it in v3:
> dt-bindings: Add Sercomm (Suzhou) Corporation vendor prefix
> Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include
> "sercomm" as a vendor prefix for "Sercomm (Suzhou) Corporation".
> Company website:
> Link: https://www.sercomm.com/
> Signed-off-by: Mikhail Zhilkin <email@example.com>
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 01430973ecec..65ff22364fb3 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1082,6 +1082,8 @@ patternProperties:
> description: Sensirion AG
> description: Sensortek Technology Corporation
> + "^sercomm,.*":
> + description: Sercomm (Suzhou) Corporation
This can be separate patch, but it's separate issue...
Linux MTD discussion mailing list
next prev parent reply other threads:[~2022-04-29 20:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 19:55 [PATCH v2 0/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser Mikhail Zhilkin
2022-04-06 19:59 ` [PATCH v2 1/2] " Mikhail Zhilkin
2022-04-07 7:48 ` Krzysztof Kozlowski
2022-04-09 12:26 ` Mikhail Zhilkin
2022-04-09 12:43 ` Krzysztof Kozlowski
2022-04-09 18:04 ` Mikhail Zhilkin
2022-04-09 18:17 ` Mikhail Zhilkin
2022-04-10 8:18 ` Krzysztof Kozlowski
2022-04-28 15:24 ` Mikhail Zhilkin
2022-04-29 6:46 ` Krzysztof Kozlowski
2022-04-29 15:26 ` Mikhail Zhilkin
2022-04-29 20:22 ` Krzysztof Kozlowski [this message]
2022-04-30 8:04 ` Mikhail Zhilkin
2022-04-30 14:35 ` Krzysztof Kozlowski
2022-04-30 18:54 ` Mikhail Zhilkin
2022-05-01 8:17 ` Krzysztof Kozlowski
2022-05-01 14:51 ` Mikhail Zhilkin
2022-05-01 16:17 ` Krzysztof Kozlowski
2022-05-02 5:42 ` Mikhail Zhilkin
2022-04-10 8:14 ` Krzysztof Kozlowski
2022-04-07 13:50 ` Rob Herring
2022-04-09 12:35 ` Mikhail Zhilkin
2022-04-09 12:49 ` Krzysztof Kozlowski
2022-04-10 6:54 ` Mikhail Zhilkin
2022-04-06 20:00 ` [PATCH v2 2/2] mtd: parsers: add support for Sercomm partitions Mikhail Zhilkin
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).