From: <Tudor.Ambarus@microchip.com>
To: <miyatsu@qq.com>, <avalentin@marcant.net>, <hauke@hauke-m.de>,
<marek.vasut@gmail.com>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <bbrezillon@kernel.org>,
<richard@nod.at>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spi-nor: Add support for mx25u3235f
Date: Sun, 3 Feb 2019 11:32:43 +0000 [thread overview]
Message-ID: <ac42a4ed-e7ac-2251-c857-870cca1de23e@microchip.com> (raw)
In-Reply-To: <20190130041121.109735-1-miyatsu@qq.com>
Hi, Boris,
On 01/30/2019 06:11 AM, Ding Tao wrote:
> From: André Valentin <avalentin@marcant.net>
>
> The mx25u3235f is found on the ZyXEL NBG6817 router, therefore
> add driver support for it so that we can upstream board support.
>
> Minimal tested with u-boot tools fw_printenv/fw_setenv on GlobalScale
> ESPRESSObin v5 board.
>
> [miyatsu@qq.com: Remove unnecessary white space.]
Would you please move this line between Andre's S-o-b and Ding's?
> Signed-off-by: André Valentin <avalentin@marcant.net>
Ding,
your change should be indicated between the last Signed-off-by header and yours,
see Documentation/process/submitting-patches.rst. Your Tested-by tag could have
been here too.
> Signed-off-by: Ding Tao <miyatsu@qq.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Andre and Hauke, we will take this version of the patch, because Ding has worked
on it too.
> ---
change log was nice to have here.
Cheers,
ta
> drivers/mtd/spi-nor/spi-nor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 6e13bbd1aaa5..01ac2e4babaa 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1836,6 +1836,8 @@ static const struct flash_info spi_nor_ids[] = {
> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> { "mx25u2033e", INFO(0xc22532, 0, 64 * 1024, 4, SECT_4K) },
> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
> { "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-03 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 4:11 [PATCH] mtd: spi-nor: Add support for mx25u3235f Ding Tao
2019-02-03 11:32 ` Tudor.Ambarus [this message]
2019-02-10 18:56 ` Boris Brezillon
-- strict thread matches above, loose matches on Subject: below --
2019-01-23 17:22 [PATCH] " André Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac42a4ed-e7ac-2251-c857-870cca1de23e@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=avalentin@marcant.net \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miyatsu@qq.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).