Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <daniel@makrotopia.org>, <linux-mtd@lists.infradead.org>,
	<microcaicai@gmail.com>
Cc: eitan@neot-semadar.com, pepe2k@gmail.com
Subject: Re: [PATCH v2] mtd: spi-nor: Add support for xt25f128b chip
Date: Wed, 1 Jul 2020 07:50:05 +0000
Message-ID: <ac8e9689-4148-c31e-4253-66385490c304@microchip.com> (raw)
In-Reply-To: <20200206171941.GA2398@makrotopia.org>

Hi, Daniel,

On 2/6/20 7:19 PM, Daniel Golle wrote:
> Add XT25F128B made by XTX Technology (Shenzhen) Limited.
> This chip supports dual and quad read and uniform 4K-byte erase.
> Verified on Teltonika RUT955 which comes with XT25F128B in recent
> versions of the device.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> v2: remove XT25F128A, flash ID and features are identical with XM25QH128A
> 
>  drivers/mtd/spi-nor/spi-nor.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 4fc632ec18fe..b36c9044f597 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2706,6 +2706,9 @@ static const struct flash_info spi_nor_ids[] = {
>  	/* XMC (Wuhan Xinxin Semiconductor Manufacturing Corp.) */
>  	{ "XM25QH64A", INFO(0x207017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ "XM25QH128A", INFO(0x207018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +
> +	/* XTX Technology (Shenzhen) Limited */
> +	{ "xt25f128b", INFO(0x0B4018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ },
>  };

Can you point me to the xt25f128b datasheet?

We'll have to re-spin your patch to the latest spi-nor/next.
Microcai sent a similar patch at
https://patchwork.ozlabs.org/project/linux-mtd/patch/CAMgqO2y9MYDj6antOaWLBRKU8vGEwqCB-Y1TkXTSWsmsed+W6A@mail.gmail.com/

Would you sync with Microcai and send another version?

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 17:19 Daniel Golle
2020-07-01  7:50 ` Tudor.Ambarus [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-01-30  8:55 [PATCH] mtd: spi-nor: Add support for xt25f128 chips Daniel Golle
2020-02-05 15:48 ` [PATCH v2] mtd: spi-nor: add support for XT25F128B chip Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac8e9689-4148-c31e-4253-66385490c304@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=daniel@makrotopia.org \
    --cc=eitan@neot-semadar.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=microcaicai@gmail.com \
    --cc=pepe2k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git