From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E45CC433E1 for ; Tue, 28 Jul 2020 08:29:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE1822075D for ; Tue, 28 Jul 2020 08:29:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="izdprTVx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="04i4RnSS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="tyRLY0gi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE1822075D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z3XQcd7zHaQdsjQycu7Ege/npwrLiqxj5lehfkxv1nI=; b=izdprTVxcf5aIBMetSTSp10bf pmxPdNbbeMXMGhgYK1TwplqOIICAZDCD6Oh3k1zIdu/OwQdWGXUbso0hmDSlTFsmA/mFRyICK2Z+B EMhvODiu14jO4dITF8DNMMa7nrjrUfwSjq4HSbRrGoKGV4XNr07FMy4gyblx53Z+NZEcPZBSF6ZMW /2Ve8J7F/SLcMP0O2ANODfDYj9GmlzWyj97BIPtAoc1cCpZPZsRvFabAj5/tLwaGCX85JIXQ27zUt kBrJmoCkVwuNU79GHkx2hhG2Y6FXN9GDXPYWNcyNggr6XCenTPuIp5JnD4IM3qUQbqEqjERzvQnxy vxukjLItA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0KyQ-0006Zz-ID; Tue, 28 Jul 2020 08:28:34 +0000 Received: from esa1.microchip.iphmx.com ([68.232.147.91]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0KyK-0006Xt-E9 for linux-mtd@lists.infradead.org; Tue, 28 Jul 2020 08:28:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595924908; x=1627460908; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Lm+N48S5Uq+yCnUNt9kr34UN4ANy62YN5kFOkfoXbnQ=; b=04i4RnSSMC7ilexJ+69MeKQd1ys0j0nrsdyDblEnt9qYTL73Tpd5zo9x cb4mKVsGtpen6WbAAkjK0JEdPffyZePsudlda4GlGDCWMcN1bw8IrSBr7 WlMgnNsDwOsF7qEJ1Z8aHrbybdYYOuILvGUj9lMReyC+Vm2QqC5YVROuc 8zCMgYH+uBFKbDWJu1siEeOG/EsfHk4HN6R8kjwzw5p5WGt8eW0C7QE+Z 5YXmXZ5n8NPm5b5CINA1SYv22aTI0/+sAskDGuhoB5gynmILnwgefuM3o YFUqi5ZKi6dQsLufs4p8WH3XfyH4Ox6xkjg0ERSKL2ty2GQJSSWL2NdNi Q==; IronPort-SDR: zcyaraZ92XDdt38sG3yaP2LEC5UPwTOjZD2S4YN80+tcQmolDa2K0sZFMcGF8I3fkFvnZIkEe4 WMpD4bXgxLf1q7Qc3cVlT3EvUuDpiICwsTIhGv+ogKHh6ZJD07Isj/jyG4ums6AWAMMOZ5gT5R KFjEc4kgSxXxgpl6xMzN0p7ePPKlsWh7IGO9QAADjO5Q/0S0Z9UlF06luNyvYJffhOLbYZ2dOM sy10YbWtGcutKQdg5v9/zdb8U2LCPvmiIcbKZ8S8pZDGm997UeZsU9IkE2OrPU6YowPhPj3tUc K9s= X-IronPort-AV: E=Sophos;i="5.75,405,1589266800"; d="scan'208";a="89400873" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 28 Jul 2020 01:28:26 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 28 Jul 2020 01:28:26 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Tue, 28 Jul 2020 01:28:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2duDNWecVN0yhijX/kUKXeMD00139xqAh1swlux2quR65YW/El7yF/fT853Xq94NcJIA7AWMlTe3YK0RrHAWZP/oKRBu2CTjQMUS70ii71XhJLIxp854IPBeXotzbuJe7XkqtwGDX5hXfe61tf4GYSAonBvQzNuzS5d6joCIcUw9Ij2lH5OPx41CZ7meJKMXZYlT7W1uyYfp+KEmwn1g0a06E2Ege9x3Qiksdb+yfdKAMCZFNL55s/0QV68r/72VlM/8iE6NCnEWtmPiHKViKrAPaAZwhjSjG2Dnie+Oixfc0MaUOXF/sSC4TYcZTTaN6JpcrX0VrLnh0kpUpu3ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lm+N48S5Uq+yCnUNt9kr34UN4ANy62YN5kFOkfoXbnQ=; b=CBV1QpI4J2W4/u/Iwb5gHGFww8qjnseoNpA5nyoapcG/SUYUCHl7MkpQ82o727p3tCDfcEdk/MzVoUYkmqSYwQyOIF8mickiXUe2MIpY8FOIISOUm3wb6dE4EwUQVqajSDeuxfZzS2tkePMLfrbfNApxyIVll0QPzjapqAU6nM/yeH/6QacRxJwY+zrex075Tr5DhfvW4Mq93khknT/pd/WcgNQApj+n2m4tuLalNT6bca3Ooc1qR8xt7yJpVgf6y55COXAbStKPeYYSJaJh4Pgkj5P0QWF+X+deJrFFcNPOimIYet8nZ02ZF96XiKfZrSUq4CeE4o4P6k7wd3Th6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lm+N48S5Uq+yCnUNt9kr34UN4ANy62YN5kFOkfoXbnQ=; b=tyRLY0gisOFJFc72piOn6xs0Uz/5EHeXpcLKZmkyCAEyUFF1I9Z3wwVmlWYN0aDQ1v+y0Nr16orBUZCIb0zVZDSISO6bpmsyTM6hi37FMoRNFh4tPVGl6nJ6qu5/zNV7OqPZsBT6sFgphlhpw13Pi/PdSKdfSSh2E4pdbJ4gO5U= Received: from DM5PR11MB1914.namprd11.prod.outlook.com (2603:10b6:3:112::12) by DM6PR11MB4121.namprd11.prod.outlook.com (2603:10b6:5:199::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Tue, 28 Jul 2020 08:28:22 +0000 Received: from DM5PR11MB1914.namprd11.prod.outlook.com ([fe80::a8e8:d0bc:8b3c:d385]) by DM5PR11MB1914.namprd11.prod.outlook.com ([fe80::a8e8:d0bc:8b3c:d385%11]) with mapi id 15.20.3216.033; Tue, 28 Jul 2020 08:28:22 +0000 From: To: , Subject: Re: [PATCH] mtd: revert "spi-nor: intel: provide a range for poll_timout" Thread-Topic: [PATCH] mtd: revert "spi-nor: intel: provide a range for poll_timout" Thread-Index: AQHWYEoGCAqTB2Up30yP+LHzC/Sy+w== Date: Tue, 28 Jul 2020 08:28:22 +0000 Message-ID: References: <20200610224652.64336-1-luisalberto@google.com> <40ef3da0-56f4-3c78-f875-a750afaf2ec5@nokia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: nokia.com; dkim=none (message not signed) header.d=none;nokia.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [79.115.63.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25821337-606e-4849-fd97-08d832d030d3 x-ms-traffictypediagnostic: DM6PR11MB4121: x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OCNoAUoXA7V6BG8HGBCJEp2VB/Fc0X+kYLPjdx0ZSyeBBZ1wAdWoq9h/S3F7B+2zGN8txJ11KXfMWrHoposU6XGXl4lYbcrdfnr7dhtVGbQbubtMHUjtl2qDv38Ghg0zlYRhe5Sb74kJLtr+0euRfdLuO3yPS2qy/Np/V5rBBhuKj8I26RMtTrCiTkPlkU1yQMq4OK8KYJFH3pJXO5eXnm/Tnard9OIKS9WjBG3ZTkWI6spMhiUefSCilg+pgt2a6kfkrfAuh0cbkxt8LkrMuuwPYdxoA8HLlBjlTc6bWrBpr3ZUGp8PCyL/pv5lnkJJDyKK/07aPlCYmXheyyi43Qv/HtXb4pel167j7JCSF7nx5GfrVzM8t9V7e7amrnkEQilm61qNF9OARgOnC5wqhA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1914.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(376002)(136003)(396003)(366004)(39860400002)(8936002)(7416002)(71200400001)(53546011)(478600001)(316002)(296002)(2906002)(6486002)(8676002)(36756003)(4326008)(26005)(31686004)(86362001)(110136005)(5660300002)(6512007)(6506007)(64756008)(66556008)(66476007)(66446008)(66946007)(76116006)(91956017)(186003)(2616005)(54906003)(31696002)(21314003)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RFnGQiMN1LocalPeUcCYQbOB7LpJkhLaRRHfGbV5yMENrhcDMW+iRr7cBL2pPwNMO6iLoP5wpPzlCAuuHr6aq0ZGg0TBJi8DlFI57P2VXhBTaW6MCnCxpvA0E3CJn28rCFVAuK+D29UJABscaH7401OLM2OE9q7pvQtc0dQvGOopoMGTuGAxNRyCY64oZo0+HUm9ja6e5ACdMl6Q+VnUGGD1IDEdEvr4rLQ1NCs9wvnipe9GgHXzid4vE1yp1WTntcq9uyCVSZMD45VDK+SchSrUgMpaJRGcnOqfAiqgXyYAVlhrEJb2iT8X8l0jZN6aQ8U3u60YIhp+08EwwswMSpkDkRHAZ0takMhT/SKUynISVeXJfdIIoIjrkAIwjtz5D+0hRLQPInYh+IILFU2n+HtCPmp2ikzLADgI5+a6LNfRLFuIxDjSXJt5kXv5RnwXBZi/SfAyQQwHDu/Pi7XgdKhmIlLdM95ege9Zgun9dHI= x-ms-exchange-transport-forked: True Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1914.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25821337-606e-4849-fd97-08d832d030d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2020 08:28:22.5241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +QP43u4zrH+h8LM/ifXXi3UO1KGO6Oe1qju7WWJPNRJA04qn+O+6Eb6VpXIdVr19/bBX7jhOgKhZ3grB+HtgMxwTSu4CY9AWPSHEXchfMrs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4121 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_042828_745915_9016EB88 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, bbrezillon@kernel.org, richard@nod.at, jethro@fortanix.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, mika.westerberg@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi, Mika, On 7/23/20 12:05 PM, Alexander Sverdlin wrote: > > Hello Tudor, > > On 22/07/2020 19:03, Tudor.Ambarus@microchip.com wrote: >> On 7/22/20 7:37 PM, Alexander Sverdlin wrote: > > [...] > >>> I've performed my testing as well and got the following results: >>> >>> Vanilla Linux 4.9 (i.e. before the introduction of the offending >>> patch): >>> >>> dd if=/dev/flash/by-name/XXX of=/dev/null bs=4k >>> 1280+0 records in >>> 1280+0 records out >>> 5242880 bytes (5.2 MB, 5.0 MiB) copied, 3.91981 s, 1.3 MB/s >>> >>> Vanilla 4.19 (i.e. with offending patch): >>> >>> dd if=/dev/flash/by-name/XXX of=/dev/null bs=4k >>> 1280+0 records in >>> 1280+0 records out >>> 5242880 bytes (5.2 MB, 5.0 MiB) copied, 6.70891 s, 781 kB/s >>> >>> 4.19 + revert: >>> >>> dd if=/dev/flash/by-name/XXX of=/dev/null bs=4k >>> 1280+0 records in >>> 1280+0 records out >>> 5242880 bytes (5.2 MB, 5.0 MiB) copied, 3.90503 s, 1.3 MB/s >>> [cut] > with 10us it looks like this: > > dd if=/dev/flash/by-name/... of=/dev/null bs=4k > 1280+0 records in > 1280+0 records out > 5242880 bytes (5.2 MB, 5.0 MiB) copied, 4.33816 s, 1.2 MB/s > > Which means, there is a performance regression and it would depend on > the test case, how bad it will be... > We need a bit of a context here. Using a tight-loop for polling and having a 5 secs timeout is fishy. For anything that's expected to complete less than a few usec, it's usually better to poll continuously, but then a timeout of 5s is way too big. Can we shrink the timeout to few msecs? I'll queue this to spi-nor/next to fix the perf regression, but I would like to continue the discussion and to come up with an incremental patch on top of this one. Cheers, ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/