From: James Morris <jmorris@namei.org>
To: Matthew Garrett <mjg59@google.com>
Cc: David Howells <dhowells@redhat.com>,
Joern Engel <joern@lazybastard.org>,
LSM List <linux-security-module@vger.kernel.org>,
Ben Hutchings <ben@decadent.org.uk>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down
Date: Tue, 10 Sep 2019 08:17:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1909100816170.3709@namei.org> (raw)
In-Reply-To: <CACdnJuutzv+0nPKeizsiaix5YtYHU4RSoH-hPFfG1Z8sW_yy2w@mail.gmail.com>
On Tue, 10 Sep 2019, Matthew Garrett wrote:
> On Fri, Aug 30, 2019 at 11:47 AM Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > These drivers allow mapping arbitrary memory ranges as MTD devices.
> > This should be disabled to preserve the kernel's integrity when it is
> > locked down.
> >
> > * Add the HWPARAM flag to the module parameters
> > * When slram is built-in, it uses __setup() to read kernel parameters,
> > so add an explicit check security_locked_down() check
> >
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > Cc: Matthew Garrett <mjg59@google.com>
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Joern Engel <joern@lazybastard.org>
> > Cc: linux-mtd@lists.infradead.org
>
> Reviewed-by: Matthew Garrett <mjg59@google.com>
>
> James, should I pick patches like this up and send them to you, or
> will you queue them directly after they're acked?
As long as I'm on the to or cc when they're acked, I can grab them.
--
James Morris
<jmorris@namei.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-09-10 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190830154549.vss6h5tlrl6d5r5y@decadent.org.uk>
2019-08-30 15:47 ` [PATCH 2/2] mtd: phram,slram: Disable when the kernel is locked down Ben Hutchings
2019-09-10 14:27 ` [PATCH 2/2] mtd: phram, slram: " Matthew Garrett
2019-09-10 15:17 ` James Morris [this message]
2019-09-10 22:18 ` Richard Weinberger
2019-09-10 23:43 ` [PATCH 2/2] mtd: phram,slram: " Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1909100816170.3709@namei.org \
--to=jmorris@namei.org \
--cc=ben@decadent.org.uk \
--cc=dhowells@redhat.com \
--cc=joern@lazybastard.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).