From: Vignesh Raghavendra <vigneshr@ti.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<marek.vasut@gmail.com>, <miquel.raynal@bootlin.com>,
<richard@nod.at>
Cc: sr@denx.de, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: cfi_cmdset_0002: dynamically determine the max sectors
Date: Fri, 28 Jun 2019 20:02:19 +0530 [thread overview]
Message-ID: <b4a2970f-40ff-3c6c-d408-4c19d5d502ad@ti.com> (raw)
In-Reply-To: <20190522000628.13073-1-chris.packham@alliedtelesis.co.nz>
Hi,
On 22-May-19 5:36 AM, Chris Packham wrote:
> Because PPB unlocking unlocks the whole chip cfi_ppb_unlock() needs to
> remember the locked status for each sector so it can re-lock the
> unaddressed sectors. Dynamically calculate the maximum number of sectors
> rather than using a hardcoded value that is too small for larger chips.
>
> Tested with Spansion S29GL01GS11TFI flash device.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
branch mtd/next.
Regards
Vignesh
> drivers/mtd/chips/cfi_cmdset_0002.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index c8fa5906bdf9..a1a7d334aa82 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -2533,8 +2533,6 @@ struct ppb_lock {
> int locked;
> };
>
> -#define MAX_SECTORS 512
> -
> #define DO_XXLOCK_ONEBLOCK_LOCK ((void *)1)
> #define DO_XXLOCK_ONEBLOCK_UNLOCK ((void *)2)
> #define DO_XXLOCK_ONEBLOCK_GETLOCK ((void *)3)
> @@ -2633,6 +2631,7 @@ static int __maybe_unused cfi_ppb_unlock(struct mtd_info *mtd, loff_t ofs,
> int i;
> int sectors;
> int ret;
> + int max_sectors;
>
> /*
> * PPB unlocking always unlocks all sectors of the flash chip.
> @@ -2640,7 +2639,11 @@ static int __maybe_unused cfi_ppb_unlock(struct mtd_info *mtd, loff_t ofs,
> * first check the locking status of all sectors and save
> * it for future use.
> */
> - sect = kcalloc(MAX_SECTORS, sizeof(struct ppb_lock), GFP_KERNEL);
> + max_sectors = 0;
> + for (i = 0; i < mtd->numeraseregions; i++)
> + max_sectors += regions[i].numblocks;
> +
> + sect = kcalloc(max_sectors, sizeof(struct ppb_lock), GFP_KERNEL);
> if (!sect)
> return -ENOMEM;
>
> @@ -2689,9 +2692,9 @@ static int __maybe_unused cfi_ppb_unlock(struct mtd_info *mtd, loff_t ofs,
> }
>
> sectors++;
> - if (sectors >= MAX_SECTORS) {
> + if (sectors >= max_sectors) {
> printk(KERN_ERR "Only %d sectors for PPB locking supported!\n",
> - MAX_SECTORS);
> + max_sectors);
> kfree(sect);
> return -EINVAL;
> }
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-06-28 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 0:06 [PATCH] mtd: cfi_cmdset_0002: dynamically determine the max sectors Chris Packham
2019-05-22 6:01 ` Stefan Roese
2019-06-14 3:23 ` Chris Packham
2019-06-14 7:18 ` Joakim Tjernlund
2019-06-14 7:39 ` Vignesh Raghavendra
2019-06-28 14:32 ` Vignesh Raghavendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4a2970f-40ff-3c6c-d408-4c19d5d502ad@ti.com \
--to=vigneshr@ti.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).