From: <Tudor.Ambarus@microchip.com>
To: <vigneshr@ti.com>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
<marek.vasut@gmail.com>
Cc: yogeshnarayan.gaur@nxp.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, bbrezillon@kernel.org
Subject: Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c
Date: Thu, 25 Jul 2019 11:44:52 +0000 [thread overview]
Message-ID: <b60adcf5-e85b-875a-c041-6bff1cade296@microchip.com> (raw)
In-Reply-To: <f6410e21-18c3-9733-4ea5-13eb26ad6169@microchip.com>
On 07/25/2019 02:19 PM, Tudor.Ambarus@microchip.com wrote:
> static int spi_nor_spimem_xfer_reg(struct spi_nor *nor, struct spi_mem_op *op)
> {
> if (!op || (op->data.nbytes && !nor->cmd_buf))
!nor->cmd_buf can't be NULL, we can get rid of this check too, and use
spi_mem_exec_op() directly when interacting with registers.
> return -EINVAL;
>
> return spi_mem_exec_op(nor->spimem, op);
> }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-07-25 11:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 8:00 [PATCH v2 0/2] ] Merge m25p80 into spi-nor Vignesh Raghavendra
2019-07-20 8:00 ` [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c Vignesh Raghavendra
2019-07-25 11:19 ` Tudor.Ambarus
2019-07-25 11:44 ` Tudor.Ambarus [this message]
2019-07-25 12:37 ` Boris Brezillon
2019-07-25 13:17 ` Tudor.Ambarus
2019-07-25 13:35 ` Tudor.Ambarus
2019-07-25 14:00 ` Boris Brezillon
2019-07-25 14:36 ` Tudor.Ambarus
2019-07-30 18:04 ` Vignesh Raghavendra
2019-07-31 6:19 ` Tudor.Ambarus
2019-07-20 8:00 ` [PATCH v2 2/2] mtd: spi-nor: Rework hwcaps selection for the spi-mem case Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b60adcf5-e85b-875a-c041-6bff1cade296@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).