From: Michael Walle <michael@walle.cc>
To: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Cc: greg.malysa@timesys.com,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] These are the required patches I found while adding
Date: Thu, 24 Nov 2022 09:07:06 +0100 [thread overview]
Message-ID: <bb6c006a27184ffa0e4ab9303cffcc72@walle.cc> (raw)
In-Reply-To: <20221123211335.126417-1-nathan.morrison@timesys.com>
Hi Nathan,
Am 2022-11-23 22:13, schrieb Nathan Barrett-Morrison:
> 1) The core framework needs some additional logic for 8S-8S-8S to pass
> through
> succesfully.
>
> 2) The IS25LX256 chip needs added to the SPI part table along with
> various fixups
Unfortunately, I can't make any sense of this series. First of all, the
IS25LX256 [1] doesn't support 8S-8S-8S, only 8D-8D-8D and 1S-8S-8S, see
ch. 4. Confused, I've looked at your octal str enable function and it
writes
0xc7 to the volatile configuration register 0x00. According to the
datasheet,
that is the enable for the octal DTR mode.
Please explain your problem and your motivation in the cover
letter/commit
message and how you fix it.
[1] https://www.issi.com/WW/pdf/25LX-WX256-128.pdf
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-11-24 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 21:13 [PATCH 0/2] These are the required patches I found while adding Nathan Barrett-Morrison
2022-11-23 21:13 ` [PATCH 1/2] mtd: spi-nore: core: Add in framework for 8S-8S-8S Octal STR mode Nathan Barrett-Morrison
2022-11-25 11:12 ` kernel test robot
2022-11-23 21:13 ` [PATCH 2/2] mtd: spi-nor: issi: Add in support for IS25LX256 chip, operating in " Nathan Barrett-Morrison
2022-11-23 21:24 ` [PATCH 0/2] These are the required patches I found while adding Nathan Barrett-Morrison
2022-11-25 15:55 ` [PATCH 2/2] mtd: spi-nor: issi: Add in support for IS25LX256 chip, operating in Octal STR mode kernel test robot
2022-11-24 8:07 ` Michael Walle [this message]
2022-11-24 11:47 ` [PATCH 0/2] These are the required patches I found while adding Nathan Barrett-Morrison
2022-11-24 12:42 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6c006a27184ffa0e4ab9303cffcc72@walle.cc \
--to=michael@walle.cc \
--cc=greg.malysa@timesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=nathan.morrison@timesys.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).