From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: linux-mtd@lists.infradead.org Cc: linux-mips@vger.kernel.org,linux-spi@vger.kernel.org,linux-kernel@vger.kernel.org,devicetree@vger.kernel.org Cc: linux-mtd@lists.infradead.org,linux-spi@vger.kernel.org,linux-kernel@vger.kernel.org,devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] SPI: Ingenic: Add SFC support for Ingenic SoCs. Date: Sat, 23 Jul 2022 17:15:46 +0200 [thread overview] Message-ID: <c522ee04-4183-c2ff-8c35-ce2bbbc1bc95@wanadoo.fr> (raw) In-Reply-To: <1658508510-15400-4-git-send-email-zhouyanjie@wanyeetech.com> Le 22/07/2022 à 18:48, 周琰杰 (Zhou Yanjie) a écrit : > Add SFC support for the X1000 SoC, the X1600 SoC, and the X2000 SoC > from Ingenic. > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> > --- > drivers/spi/Kconfig | 9 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-ingenic-sfc.c | 662 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 672 insertions(+) > create mode 100644 drivers/spi/spi-ingenic-sfc.c > [...] > +static int ingenic_sfc_probe(struct platform_device *pdev) > +{ > + struct ingenic_sfc *sfc; > + struct spi_controller *ctlr; > + int ret; > + > + ctlr = spi_alloc_master(&pdev->dev, sizeof(*sfc)); > + if (!ctlr) > + return -ENOMEM; devm_spi_alloc_master()? (+ error handling simplification) Or there should be a .remove() function. CJ > + > + sfc = spi_controller_get_devdata(ctlr); > + > + sfc->soc_info = of_device_get_match_data(&pdev->dev); > + if (!sfc->soc_info) { > + dev_err(&pdev->dev, "No of match data provided\n"); > + ret = -ENODEV; > + goto err_put_master; > + } > + [...] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>, tudor.ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aidanmacdonald.0x0@gmail.com, tmn505@gmail.com, paul@crapouillou.net, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, jinghui.liu@ingenic.com, sernia.zhou@foxmail.com, reimu@sudomaker.com Subject: Re: [PATCH 3/3] SPI: Ingenic: Add SFC support for Ingenic SoCs. Date: Sat, 23 Jul 2022 17:15:46 +0200 [thread overview] Message-ID: <c522ee04-4183-c2ff-8c35-ce2bbbc1bc95@wanadoo.fr> (raw) Message-ID: <20220723151546.BFmsGy06FRyX2mobfu49AOf-SSKlwQgWMoWqfqCLXvc@z> (raw) In-Reply-To: <1658508510-15400-4-git-send-email-zhouyanjie@wanyeetech.com> Le 22/07/2022 à 18:48, 周琰杰 (Zhou Yanjie) a écrit : > Add SFC support for the X1000 SoC, the X1600 SoC, and the X2000 SoC > from Ingenic. > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> > --- > drivers/spi/Kconfig | 9 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-ingenic-sfc.c | 662 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 672 insertions(+) > create mode 100644 drivers/spi/spi-ingenic-sfc.c > [...] > +static int ingenic_sfc_probe(struct platform_device *pdev) > +{ > + struct ingenic_sfc *sfc; > + struct spi_controller *ctlr; > + int ret; > + > + ctlr = spi_alloc_master(&pdev->dev, sizeof(*sfc)); > + if (!ctlr) > + return -ENOMEM; devm_spi_alloc_master()? (+ error handling simplification) Or there should be a .remove() function. CJ > + > + sfc = spi_controller_get_devdata(ctlr); > + > + sfc->soc_info = of_device_get_match_data(&pdev->dev); > + if (!sfc->soc_info) { > + dev_err(&pdev->dev, "No of match data provided\n"); > + ret = -ENODEV; > + goto err_put_master; > + } > + [...] ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-23 15:16 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-22 16:48 [PATCH 0/3] Add SFC support for Ingenic SoCs 周琰杰 (Zhou Yanjie) 2022-07-22 16:48 ` [PATCH 1/3] mtd: spi-nor: Use the spi-mem poll status APIs 周琰杰 (Zhou Yanjie) 2022-07-23 8:30 ` Sergey Shtylyov 2022-07-22 16:48 ` [PATCH 2/3] dt-bindings: SPI: Add Ingenic SFC bindings 周琰杰 (Zhou Yanjie) 2022-07-22 17:46 ` Krzysztof Kozlowski 2022-07-23 16:50 ` Zhou Yanjie 2022-07-23 17:43 ` Krzysztof Kozlowski 2022-07-23 18:47 ` Mike Yang 2022-07-23 19:27 ` Mark Brown 2022-07-23 20:07 ` Krzysztof Kozlowski 2022-07-23 20:49 ` Mike Yang 2022-07-24 15:33 ` Zhou Yanjie 2022-07-25 18:30 ` Rob Herring 2022-07-23 20:05 ` Krzysztof Kozlowski 2022-07-24 14:52 ` Zhou Yanjie 2022-07-22 22:44 ` Rob Herring 2022-07-22 16:48 ` [PATCH 3/3] SPI: Ingenic: Add SFC support for Ingenic SoCs 周琰杰 (Zhou Yanjie) 2022-07-22 18:07 ` Krzysztof Kozlowski 2022-07-23 16:53 ` Zhou Yanjie 2022-07-22 18:38 ` Mark Brown 2022-07-23 17:06 ` Zhou Yanjie 2022-07-23 19:32 ` Mark Brown 2022-07-24 1:24 ` Zhou Yanjie 2022-07-22 20:03 ` Paul Cercueil 2022-07-23 17:26 ` Zhou Yanjie 2022-07-23 20:24 ` Paul Cercueil 2022-07-24 15:29 ` Zhou Yanjie 2022-07-23 15:15 ` Christophe JAILLET [this message] 2022-07-23 15:15 ` Christophe JAILLET 2022-07-24 1:22 ` Zhou Yanjie 2022-07-24 0:43 ` kernel test robot 2022-07-24 1:28 ` Vanessa Page 2022-07-23 14:47 ` [PATCH 0/3] " Tomasz Maciej Nowak 2022-07-24 1:25 ` Zhou Yanjie 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:28 ` Vanessa Page 2022-07-24 1:30 ` Vanessa Page 2022-07-24 1:32 ` Vee Page 2022-07-26 6:13 ` Vee Page
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c522ee04-4183-c2ff-8c35-ce2bbbc1bc95@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).