From: <Tudor.Ambarus@microchip.com>
To: <michael@walle.cc>
Cc: <pratyush@kernel.org>, <miquel.raynal@bootlin.com>,
<richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<p.yadav@ti.com>
Subject: Re: [PATCH] mtd: spi-nor: core: Add an error message when failing to exit the 4-byte address mode
Date: Thu, 28 Jul 2022 12:26:09 +0000 [thread overview]
Message-ID: <c5396813-8504-e24b-bb04-463308bd099a@microchip.com> (raw)
In-Reply-To: <27c95d5e17906f5e45c04cec7c1bda9d@walle.cc>
On 7/28/22 15:15, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi,
>
> Am 2022-07-28 05:01, schrieb Tudor Ambarus:
>> Add an error message when failing to exit the 4-byte address mode. Do
>> not
>> stop the execution and go through the spi_nor_soft_reset() method if
>> used,
>> in the hope that the flash will default to 3-byte address mode after
>> the
>> reset.
>>
>> Suggested-by: Pratyush Yadav <p.yadav@ti.com>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> ---
>> drivers/mtd/spi-nor/core.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
>> index f2c64006f8d7..1cdbdad97136 100644
>> --- a/drivers/mtd/spi-nor/core.c
>> +++ b/drivers/mtd/spi-nor/core.c
>> @@ -2841,7 +2841,8 @@ void spi_nor_restore(struct spi_nor *nor)
>> /* restore the addressing mode */
>> if (nor->addr_nbytes == 4 && !(nor->flags & SNOR_F_4B_OPCODES) &&
>> nor->flags & SNOR_F_BROKEN_RESET)
>> - nor->params->set_4byte_addr_mode(nor, false);
>> + if (nor->params->set_4byte_addr_mode(nor, false))
>> + dev_err(nor->dev, "Failed to exit 4-byte address mode\n");
>
> Could we stick to the ususal pattern:
>
> ret = func()
> if (ret)
> err("blubb (%d)", ret);
>
> I know it is more lines but imho it makes the code much more readable.
> And that way you could also print the error code. You could also use
> dev_err("bla (%pe)\n", ERR_PTR(ret));
>
sure, will do. Thanks.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-07-28 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 3:01 [PATCH] mtd: spi-nor: core: Add an error message when failing to exit the 4-byte address mode Tudor Ambarus
2022-07-28 12:06 ` Pratyush Yadav
2022-07-28 12:15 ` Michael Walle
2022-07-28 12:26 ` Tudor.Ambarus [this message]
2022-10-25 2:33 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5396813-8504-e24b-bb04-463308bd099a@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).