From: <Tudor.Ambarus@microchip.com> To: <vigneshr@ti.com>, <miquel.raynal@bootlin.com>, <richard@nod.at> Cc: marek.vasut@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, tmaimon77@gmail.com, bbrezillon@kernel.org Subject: Re: [PATCH v4 3/3] mtd: spi-nor: Rework hwcaps selection for the spi-mem case Date: Mon, 5 Aug 2019 17:45:53 +0000 Message-ID: <ca327faa-d716-9ef3-f368-e496a40c6e2e@microchip.com> (raw) In-Reply-To: <20190801162229.28897-4-vigneshr@ti.com> On 08/01/2019 07:22 PM, Vignesh Raghavendra wrote: > +static int spi_nor_spimem_check_op(struct spi_nor *nor, > + struct spi_mem_op *op) > +{ > + /* > + * First test with 4 address bytes. The opcode itself might > + * be a 3B addressing opcode but we don't care, because > + * SPI controller implementation should not check the opcode, > + * but just the sequence. > + */ > + op->addr.nbytes = 4; > + if (!spi_mem_supports_op(nor->spimem, op)) { > + /* If flash size <16MB, 3 address bytes are sufficient */ > + if (nor->mtd.size <= SZ_16M) { > + op->addr.nbytes = 3; > + if (!spi_mem_supports_op(nor->spimem, op)) > + return -ENOTSUPP; > + } this returns success when: op->addr.nbytes == 4 && !spi_mem_supports_op(nor->spimem, op) && !(nor->mtd.size <= SZ_16M)) which is wrong. The patch looks good otherwise! > + } > + > + return 0; > +} ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-01 16:22 [PATCH v4 0/3] Merge m25p80 into spi-nor Vignesh Raghavendra 2019-08-01 16:22 ` [PATCH v4 1/3] mtd: spi-nor: always use bounce buffer for register read/writes Vignesh Raghavendra 2019-08-05 9:06 ` Tudor.Ambarus 2019-08-05 10:38 ` Vignesh Raghavendra 2019-08-05 11:24 ` Tudor.Ambarus 2019-08-01 16:22 ` [PATCH v4 2/3] mtd: spi-nor: Move m25p80 code in spi-nor.c Vignesh Raghavendra 2019-08-05 10:25 ` Tudor.Ambarus 2019-08-05 11:10 ` Vignesh Raghavendra 2019-08-05 11:51 ` Tudor.Ambarus 2019-08-05 12:31 ` Vignesh Raghavendra 2019-08-01 16:22 ` [PATCH v4 3/3] mtd: spi-nor: Rework hwcaps selection for the spi-mem case Vignesh Raghavendra 2019-08-05 17:45 ` Tudor.Ambarus [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ca327faa-d716-9ef3-f368-e496a40c6e2e@microchip.com \ --to=tudor.ambarus@microchip.com \ --cc=bbrezillon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=tmaimon77@gmail.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mtd Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \ linux-mtd@lists.infradead.org public-inbox-index linux-mtd Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git