From: "Xiangsheng Hou (侯祥胜)" <Xiangsheng.Hou@mediatek.com>
To: "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"gch981213@gmail.com" <gch981213@gmail.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"richard@nod.at" <richard@nod.at>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Benliang Zhao (赵本亮)" <Benliang.Zhao@mediatek.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Bin Zhang (章斌)" <bin.zhang@mediatek.com>
Subject: Re: [PATCH 8/9] dt-bindings: mtd: Split ECC engine with rawnand controller
Date: Tue, 29 Nov 2022 02:50:16 +0000 [thread overview]
Message-ID: <cba02d8972da75f89d9f0c0e03765cee58b42f57.camel@mediatek.com> (raw)
In-Reply-To: <69d35231-0ac0-297c-d669-5566a926aac3@linaro.org>
Hi Krzysztof,
On Mon, 2022-11-28 at 10:13 +0100, Krzysztof Kozlowski wrote:
> On 28/11/2022 03:06, Xiangsheng Hou wrote:
> > Split MediaTek ECC engine with rawnand controller and convert to
> > YAML schema.
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/mtk,nand-ecc-
> > engine.yaml
>
> Wrong vendor prefix. Isn't it mediatek?
Yes, will be fixed.
> > +
> > + reg:
> > + items:
> > + - description: Base physical address and size of ECC.
> > +
> > + interrupts:
> > + items:
> > + - description: ECC interrupt
> > +
> > + clocks:
> > + minItems: 1
>
> Drop minItems.
>
> > + items:
> > + - description: clock used for the controller
>
> Drop items/description - it is obvious, isn't it? Rather maxItems: 1,
> Unless controller is not obvious in this context - about which
> controller you talk about?
Will be dropped and fix other comment in next series.
> > +
> > +
> > + nand-ecc-engine:
> > + description: Required ECC Engine node
> > + $ref: /schemas/types.yaml#/definitions/phandle
>
> This does not look right. This is a property of NAND chip and
> original
> binding was saying this as well... or was it called ecc-engine in
> original bindings? But your commit msg did not explain any
> differences
> from pure conversion.
The MediaTek NAND controller driver have change ecc-engine to nand-ecc-
engine property. Will dropped and explain the difference in commit msg.
Best regards,
Xiangsheng Hou
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-11-29 2:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 2:06 [PATCH 0/9] Add MediaTek MT7986 SPI NAND and ECC support Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 1/9] spi: mtk-snfi: add snfi support for mt7986 IC Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 2/9] spi: mtk-snfi: change default page format to setup default setting Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 3/9] spi: mtk-snfi: add optional nfi_hclk which needed for mt7986 Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 4/9] mtd: nand: ecc-mtk: add ecc support fot mt7986 IC Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 5/9] dt-bindings: spi: mtk-snfi: add mt7986 IC snfi bindings Xiangsheng Hou
2022-11-28 9:00 ` Krzysztof Kozlowski
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:33 ` Krzysztof Kozlowski
2022-11-28 2:06 ` [PATCH 6/9] spi: mtk-snfi: add snfi sample delay and read latency adjustment Xiangsheng Hou
2022-11-28 2:06 ` [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property Xiangsheng Hou
2022-11-28 9:04 ` Krzysztof Kozlowski
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜)
2022-11-29 7:47 ` Krzysztof Kozlowski
2022-11-30 8:18 ` Xiangsheng Hou (侯祥胜)
2022-11-30 8:35 ` Krzysztof Kozlowski
2022-11-30 9:08 ` Chuanhong Guo
2022-11-28 12:20 ` Rob Herring
2022-11-28 2:06 ` [PATCH 8/9] dt-bindings: mtd: Split ECC engine with rawnand controller Xiangsheng Hou
2022-11-28 9:13 ` Krzysztof Kozlowski
2022-11-29 2:50 ` Xiangsheng Hou (侯祥胜) [this message]
2022-11-28 12:20 ` Rob Herring
2022-12-01 5:24 ` kernel test robot
2022-11-28 2:06 ` [PATCH 9/9] dt-bindings: mtd: ecc-mtk: add mt7986 IC ecc bindings Xiangsheng Hou
2022-11-28 9:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba02d8972da75f89d9f0c0e03765cee58b42f57.camel@mediatek.com \
--to=xiangsheng.hou@mediatek.com \
--cc=Benliang.Zhao@mediatek.com \
--cc=bin.zhang@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).