From: Kever Yang <kever.yang@rock-chips.com>
To: Yifeng Zhao <yifeng.zhao@rock-chips.com>,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 8/8] arm: dts: rockchip: Add NFC node for RK3036 SoC
Date: Wed, 14 Oct 2020 08:28:09 +0800 [thread overview]
Message-ID: <cd4ac8ed-49b4-fe7d-f483-f267376acec6@rock-chips.com> (raw)
In-Reply-To: <20200930020902.7522-4-yifeng.zhao@rock-chips.com>
On 2020/9/30 上午10:09, Yifeng Zhao wrote:
> Add NAND FLASH Controller(NFC) node for RK3036 SoC.
>
> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> ---
>
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> arch/arm/boot/dts/rk3036.dtsi | 52 +++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
Looks good to me,
Reviewed-by: Kever Yang<kever.yang@rock-chips.com>
Thanks,
- Kever
>
> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi
> index 093567022386..dda5a1f79aca 100644
> --- a/arch/arm/boot/dts/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rk3036.dtsi
> @@ -292,6 +292,21 @@
> status = "disabled";
> };
>
> + nfc: nand-controller@10500000 {
> + compatible = "rockchip,rk3036-nfc",
> + "rockchip,rk2928-nfc";
> + reg = <0x10500000 0x4000>;
> + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_NANDC>, <&cru SCLK_NANDC>;
> + clock-names = "ahb", "nfc";
> + assigned-clocks = <&cru SCLK_NANDC>;
> + assigned-clock-rates = <150000000>;
> + pinctrl-0 = <&flash_ale &flash_bus8 &flash_cle &flash_csn0
> + &flash_rdn &flash_rdy &flash_wrn>;
> + pinctrl-names = "default";
> + status = "disabled";
> + };
> +
> cru: clock-controller@20000000 {
> compatible = "rockchip,rk3036-cru";
> reg = <0x20000000 0x1000>;
> @@ -643,6 +658,43 @@
> };
> };
>
> + nfc {
> + flash_ale: flash-ale {
> + rockchip,pins = <2 RK_PA0 1 &pcfg_pull_default>;
> + };
> +
> + flash_bus8: flash-bus8 {
> + rockchip,pins = <1 RK_PD0 1 &pcfg_pull_default>,
> + <1 RK_PD1 1 &pcfg_pull_default>,
> + <1 RK_PD2 1 &pcfg_pull_default>,
> + <1 RK_PD3 1 &pcfg_pull_default>,
> + <1 RK_PD4 1 &pcfg_pull_default>,
> + <1 RK_PD5 1 &pcfg_pull_default>,
> + <1 RK_PD6 1 &pcfg_pull_default>,
> + <1 RK_PD7 1 &pcfg_pull_default>;
> + };
> +
> + flash_cle: flash-cle {
> + rockchip,pins = <2 RK_PA1 1 &pcfg_pull_default>;
> + };
> +
> + flash_csn0: flash-csn0 {
> + rockchip,pins = <2 RK_PA6 1 &pcfg_pull_default>;
> + };
> +
> + flash_rdn: flash-rdn {
> + rockchip,pins = <2 RK_PA3 1 &pcfg_pull_default>;
> + };
> +
> + flash_rdy: flash-rdy {
> + rockchip,pins = <2 RK_PA4 1 &pcfg_pull_default>;
> + };
> +
> + flash_wrn: flash-wrn {
> + rockchip,pins = <2 RK_PA2 1 &pcfg_pull_default>;
> + };
> + };
> +
> emac {
> emac_xfer: emac-xfer {
> rockchip,pins = <2 RK_PB2 1 &pcfg_pull_default>, /* crs_dvalid */
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-14 0:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 2:07 [PATCH v10 0/8] Add Rockchip NFC drivers for RK3308 and others Yifeng Zhao
2020-09-30 2:07 ` [PATCH v10 1/8] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Yifeng Zhao
2020-10-05 14:41 ` Rob Herring
2020-10-14 0:25 ` Kever Yang
2020-09-30 2:07 ` [PATCH v10 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Yifeng Zhao
2020-10-14 0:26 ` Kever Yang
2020-09-30 2:07 ` [PATCH v10 3/8] MAINTAINERS: add maintainers to ROCKCHIP NFC Yifeng Zhao
2020-10-14 0:26 ` Kever Yang
2020-09-30 2:07 ` [PATCH v10 4/8] arm64: dts: rockchip: Add NFC node for RK3308 SoC Yifeng Zhao
2020-10-14 0:26 ` Kever Yang
2020-09-30 2:08 ` [PATCH v10 5/8] arm64: dts: rockchip: Add NFC node for PX30 SoC Yifeng Zhao
2020-09-30 2:09 ` [PATCH v10 6/8] arm: dts: rockchip: Add NFC node for RV1108 SoC Yifeng Zhao
2020-10-14 0:27 ` Kever Yang
2020-09-30 2:09 ` [PATCH v10 7/8] arm: dts: rockchip: Add NFC node for RK2928 and other SoCs Yifeng Zhao
2020-10-14 0:27 ` Kever Yang
2020-09-30 2:09 ` [PATCH v10 8/8] arm: dts: rockchip: Add NFC node for RK3036 SoC Yifeng Zhao
2020-10-14 0:28 ` Kever Yang [this message]
2020-10-14 0:27 ` [PATCH v10 5/8] arm64: dts: rockchip: Add NFC node for PX30 SoC Kever Yang
2020-10-14 0:35 ` [PATCH v10 0/8] Add Rockchip NFC drivers for RK3308 and others Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd4ac8ed-49b4-fe7d-f483-f267376acec6@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).