From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F93EC04A6B for ; Fri, 10 May 2019 11:05:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 018FD21479 for ; Fri, 10 May 2019 11:05:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VWlVnHkQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="cJaRCIlX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 018FD21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=analog.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=onxnXH266irdJ7RTQOoTrlO4kq4dEYfJZtc4X76+qAE=; b=VWlVnHkQCpYEz+ 7/EJ1sDX+mDg/mCNSbyJo5aDS/KsRQo2oz47a115CMFkFGNy4dFkoqXU9LYtCm3Vk+AQbi1RcIOB/ DRRyM6oGfitIsByGozwpGXxifyrVLV2zwQaP3Ra/9dii2IjiOTQ70RJeOa3Cek/xG+DTLI6BFeaQ7 bw6tV50O+HbizAiRaH0LCsKusRk8m0ABJRh/NJpZeFmWRCIA4ItFR90J1/29feyZ5z5/Y95VOwzCa l5rpN5CTVYtItV8UYKvlLuqar3+holsBE6D8kdBS7Bw0HeLKp7ivGcrq4K1hf+CQxqSwpxD3PKN5M qoDmN3MjCssN4vZM6MtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hP3Kt-0000F6-OK; Fri, 10 May 2019 11:05:07 +0000 Received: from mail-by2nam03on0630.outbound.protection.outlook.com ([2a01:111:f400:fe4a::630] helo=NAM03-BY2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hP3Kn-0008Fj-DZ; Fri, 10 May 2019 11:05:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector1-analog-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nVlpM+6hUpJfEDjmqqh5buswTi9IXWo+idp+3aYvadA=; b=cJaRCIlXlhytsC0WOUjovdUXlHRExZWPjhVf03F0+kh9EW3mb68RI6Rnc3cHyEhKGz4sJV9wA82vpcEx/F+iU3ypyrnsW4/k0e997VS2hIGKO+igCU4zzHHlAx2b/kf5RKAjaKA2W3b6tkRnBRfNgWUAFNGQGOnAYoLiEYdp3VE= Received: from BN6PR03CA0017.namprd03.prod.outlook.com (2603:10b6:404:23::27) by BY2PR03MB556.namprd03.prod.outlook.com (2a01:111:e400:2c3a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.22; Fri, 10 May 2019 11:04:54 +0000 Received: from BL2NAM02FT036.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::208) by BN6PR03CA0017.outlook.office365.com (2603:10b6:404:23::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1878.20 via Frontend Transport; Fri, 10 May 2019 11:04:54 +0000 Authentication-Results: spf=pass (sender IP is 137.71.25.57) smtp.mailfrom=analog.com; linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=bestguesspass action=none header.from=analog.com; Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT036.mail.protection.outlook.com (10.152.77.154) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.1856.11 via Frontend Transport; Fri, 10 May 2019 11:04:53 +0000 Received: from NWD2HUBCAS9.ad.analog.com (nwd2hubcas9.ad.analog.com [10.64.69.109]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id x4AB4rkt031706 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 10 May 2019 04:04:53 -0700 Received: from NWD2MBX7.ad.analog.com ([fe80::190e:f9c1:9a22:9663]) by NWD2HUBCAS9.ad.analog.com ([fe80::44a2:871b:49ab:ea47%12]) with mapi id 14.03.0415.000; Fri, 10 May 2019 07:04:53 -0400 From: "Ardelean, Alexandru" To: "dan.carpenter@oracle.com" Subject: Re: [PATCH 09/16] mmc: sdhci-xenon: use new match_string() helper/macro Thread-Topic: [PATCH 09/16] mmc: sdhci-xenon: use new match_string() helper/macro Thread-Index: AQHVBZFjC5krcc3G0k+g00YBPwx6V6ZhaK0AgAAShYCAAt35AIAAHiKAgAABAAA= Date: Fri, 10 May 2019 11:04:53 +0000 Message-ID: References: <20190508112842.11654-1-alexandru.ardelean@analog.com> <20190508112842.11654-11-alexandru.ardelean@analog.com> <20190508122010.GC21059@kadam> <2ec6812d6bf2f33860c7c816c641167a31eb2ed6.camel@analog.com> <31be52eb1a1abbc99a24729f5c65619235cb201f.camel@analog.com> <20190510110116.GB18105@kadam> In-Reply-To: <20190510110116.GB18105@kadam> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.50.1.244] x-adiroutedonprem: True Content-ID: <134D0B85CEA25646B3EBD898406EC02C@analog.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(1496009)(136003)(396003)(376002)(346002)(39860400002)(2980300002)(189003)(199004)(426003)(76176011)(102836004)(26005)(436003)(70206006)(446003)(8936002)(7696005)(70586007)(36756003)(14444005)(6246003)(186003)(336012)(2486003)(8676002)(6116002)(3846002)(229853002)(5660300002)(11346002)(47776003)(5640700003)(356004)(305945005)(50466002)(2616005)(476003)(6916009)(2906002)(118296001)(478600001)(126002)(7736002)(86362001)(14454004)(2351001)(2501003)(7636002)(23676004)(106002)(246002)(4326008)(316002)(7416002)(7406005)(54906003)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR03MB556; H:nwd2mta2.analog.com; FPR:; SPF:Pass; LANG:en; PTR:nwd2mail11.analog.com; MX:1; A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f76a2088-dc12-4942-d433-08d6d537549b X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4709054)(2017052603328)(7193020); SRVR:BY2PR03MB556; X-MS-TrafficTypeDiagnostic: BY2PR03MB556: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0033AAD26D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: tULqUEYxx8A1Vcan/qfbE7E/YiNcE+blJBkWLIfZLYQfoW+YJfMk/7pGVcvZ1Zi7zwbrhva5fOWhPlE7BRloVhcy0b7UY+H3u7eHfxlqm2FqcBDBRA6rNCrikJSdpJCdjDevTorMO4v2pbPJ9vgXgpdzx4rSWTBAzaTFpTqnxoN6817pHFRM6OimKYwZT+zkHQBRDborUH0cfCMCTH7W/DYsug3lJUPmoVohbzUw7Qlzb5gflrpKMIIuKRlZUQA5y+LwbgY2fjwZItJ1in7CCdq2yHbgQEyod/D4nUaFXtQNysaVfM6q5P4JW2pJdKeJjrqkRhofhZP8Dy5+VsJYbafZu2hWLTkGR5O0X96SKzhm9VbATpPl5eWgoo6bTpaSEgvMToAEFFE6dQ7aXg+NwW0dDvkkJwZFaifj5Uv3dxk= X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2019 11:04:53.7708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f76a2088-dc12-4942-d433-08d6d537549b X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a; Ip=[137.71.25.57]; Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB556 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190510_040501_512067_84EE93BD X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-wireless@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-pci@vger.kernel.org" , "alsa-devel@alsa-project.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-mtd@lists.infradead.org" , "linux-clk@vger.kernel.org" , "devel@driverdev.osuosl.org" , "andriy.shevchenko@linux.intel.com" , "linux-rockchip@lists.infradead.org" , "linux-pm@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "linux-gpio@vger.kernel.org" , "linux-rpi-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "cgroups@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-ide@vger.kernel.org" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-integrity@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 2019-05-10 at 14:01 +0300, Dan Carpenter wrote: > [External] > > > On Fri, May 10, 2019 at 09:13:26AM +0000, Ardelean, Alexandru wrote: > > On Wed, 2019-05-08 at 16:26 +0300, Alexandru Ardelean wrote: > > > On Wed, 2019-05-08 at 15:20 +0300, Dan Carpenter wrote: > > > > > > > > > > > > On Wed, May 08, 2019 at 02:28:35PM +0300, Alexandru Ardelean wrote: > > > > > -static const char * const phy_types[] = { > > > > > - "emmc 5.0 phy", > > > > > - "emmc 5.1 phy" > > > > > -}; > > > > > - > > > > > enum xenon_phy_type_enum { > > > > > EMMC_5_0_PHY, > > > > > EMMC_5_1_PHY, > > > > > NR_PHY_TYPES > > > > > > > > There is no need for NR_PHY_TYPES now so you could remove that as > > > > well. > > > > > > > > > > I thought the same. > > > The only reason to keep NR_PHY_TYPES, is for potential future > > > patches, > > > where it would be just 1 addition > > > > > > enum xenon_phy_type_enum { > > > EMMC_5_0_PHY, > > > EMMC_5_1_PHY, > > > + EMMC_5_2_PHY, > > > NR_PHY_TYPES > > > } > > > > > > Depending on style/preference of how to do enums (allow comma on last > > > enum > > > or not allow comma on last enum value), adding new enum values woudl > > > be 2 > > > additions + 1 deletion lines. > > > > > > enum xenon_phy_type_enum { > > > EMMC_5_0_PHY, > > > - EMMC_5_1_PHY > > > + EMM > > > C_5_1_PHY, > > > + EMMC_5_2_PHY > > > } > > > > > > Either way (leave NR_PHY_TYPES or remove NR_PHY_TYPES) is fine from > > > my > > > side. > > > > > > > Preference on this ? > > If no objection [nobody insists] I would keep. > > > > I don't feel strongly about it [dropping NR_PHY_TYPES or not]. > > If you end up resending the series could you remove it, but if not then > it's not worth it. ack thanks Alex > > regards, > dan carpenter > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/