From: Liang Yang <liang.yang@amlogic.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
<linux-mtd@lists.infradead.org>
Cc: kernel test robot <lkp@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
XianWei Zhao <xianwei.zhao@amlogic.com>,
Kelvin Zhang <kelvin.zhang@amlogic.com>,
BiChao Zheng <bichao.zheng@amlogic.com>,
YongHui Yu <yonghui.yu@amlogic.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 5/5] mtd: rawnand: meson: not support legacy clock
Date: Tue, 7 Jun 2022 17:37:31 +0800 [thread overview]
Message-ID: <e06acb65-50fe-46e6-a302-0238c902d1a2@amlogic.com> (raw)
In-Reply-To: <791b3e4e-7348-997a-0ead-136739ec10bf@baylibre.com>
Hi Neil,
On 2022/6/7 15:12, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
>
> Hi,
>
> On 07/06/2022 08:47, Liang Yang wrote:
>> meson NFC driver use common clock interfaces. so the test robot report
>> some errors once using the legacy clock with HAVE_LEGACY_CLK on.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Liang Yang <liang.yang@amlogic.com>
>> ---
>> drivers/mtd/nand/raw/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
>> index 67b7cb67c030..5169412a4af4 100644
>> --- a/drivers/mtd/nand/raw/Kconfig
>> +++ b/drivers/mtd/nand/raw/Kconfig
>> @@ -395,7 +395,7 @@ config MTD_NAND_STM32_FMC2
>> config MTD_NAND_MESON
>> tristate "Support for NAND controller on Amlogic's Meson SoCs"
>> - depends on ARCH_MESON || COMPILE_TEST
>> + depends on ARCH_MESON || COMPILE_TEST || !HAVE_LEGACY_CLK
>
> I think depending on CCF would be better than excluding legacy clock.
>
indeed. i will use COMMON_CLK later. thanks.
>> select MFD_SYSCON
>> help
>> Enables support for NAND controller on Amlogic's Meson SoCs.
>
> Neil
>
> .
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2022-06-07 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 6:47 [PATCH v6 0/5] fix the meson NFC clock Liang Yang
2022-06-07 6:47 ` [PATCH v6 1/5] dt-bindings: nand: meson: fix meson nfc clock Liang Yang
2022-06-07 6:47 ` [PATCH v6 2/5] mtd: rawnand: meson: fix the clock Liang Yang
2022-06-07 6:47 ` [PATCH v6 3/5] mtd: rawnand: meson: refine resource getting in probe Liang Yang
2022-06-07 6:47 ` [PATCH v6 4/5] dt-bindings: nand: meson: convert txt to yaml Liang Yang
2022-06-07 6:47 ` [PATCH v6 5/5] mtd: rawnand: meson: not support legacy clock Liang Yang
2022-06-07 7:12 ` Neil Armstrong
2022-06-07 9:37 ` Liang Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e06acb65-50fe-46e6-a302-0238c902d1a2@amlogic.com \
--to=liang.yang@amlogic.com \
--cc=bichao.zheng@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=kelvin.zhang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lkp@intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=victor.wan@amlogic.com \
--cc=vigneshr@ti.com \
--cc=xianwei.zhao@amlogic.com \
--cc=yonghui.yu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).