From: Vignesh Raghavendra <vigneshr@ti.com>
To: Michael Walle <michael@walle.cc>
Cc: <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 2/2] mtd: spi-nor: add initial sysfs support
Date: Tue, 6 Apr 2021 17:13:47 +0530 [thread overview]
Message-ID: <e14029f2-587d-0f89-98ee-c08b550bf282@ti.com> (raw)
In-Reply-To: <4f1de957288118d5a627027ec4c37973@walle.cc>
On 4/6/21 2:17 PM, Michael Walle wrote:
> Hi,
>
> Am 2021-04-06 09:56, schrieb Vignesh Raghavendra:
>> Hi,
>>
>> On 3/18/21 2:54 PM, Michael Walle wrote:
>>> Add support to show the name and JEDEC identifier as well as to dump the
>>> SFDP table. Not all flashes list their SFDP table contents in their
>>> datasheet. So having that is useful. It might also be helpful in bug
>>> reports from users.
>>>
>>
>> Sorry for the delay..
>>
>> There is already debugfs support for dumping JEDEC ID [1]. Any reason to
>> add sysfs entry as well?
>
> This is per mtd while the sfdp is per flash device. IMHO both should
> be at the same place.
>
>> That brings up another question. Since SFDP dumps are more of a debug
>> aid, should this be a debugfs entry rather than sysfs entry?
>
> And you're not the first one asking that. My argument was that the
> debugfs might not be available just when you need it. A developer
> could easily rebuild a kernel, but imagine some user with a COTS
> distro and some problems, then it is not that easy anymore. But
> thats your call to make.
>
>> Note that sysfs entries are userspace ABIs just like syscalls and thus
>> need to be documented in Documentation/ABI/testing/ or
>> Documentation/ABI/stable. Thus need to be carefully designed compared to
>> debugfs which are much more flexible.
>
> Ok. But I don't see a problem adding these read-only files
> /sfdp
> /name
> /jedec-id
>
Hmm, ok. but do add documentation please.
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-04-06 11:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:24 [PATCH 0/2] mtd: spi-nor: support dumping sfdp tables Michael Walle
2021-03-18 9:24 ` [PATCH 1/2] mtd: spi-nor: sfdp: save a copy of the SFDP data Michael Walle
2021-03-22 14:21 ` Pratyush Yadav
2021-03-22 15:32 ` Michael Walle
2021-03-22 15:48 ` Michael Walle
2021-03-22 18:42 ` Pratyush Yadav
2021-03-22 22:31 ` Michael Walle
2021-03-23 9:37 ` Pratyush Yadav
2021-04-05 13:11 ` Tudor.Ambarus
2021-04-05 15:07 ` Michael Walle
2021-04-05 15:42 ` Tudor.Ambarus
2021-04-05 16:03 ` Michael Walle
2021-03-18 9:24 ` [PATCH 2/2] mtd: spi-nor: add initial sysfs support Michael Walle
2021-03-20 4:16 ` Yicong Yang
2021-03-20 19:17 ` Michael Walle
2021-03-22 14:43 ` Pratyush Yadav
2021-03-22 14:57 ` Michael Walle
2021-04-06 7:56 ` Vignesh Raghavendra
2021-04-06 8:47 ` Michael Walle
2021-04-06 11:43 ` Vignesh Raghavendra [this message]
2021-04-29 15:37 ` Alexander Williams
2021-04-29 15:46 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e14029f2-587d-0f89-98ee-c08b550bf282@ti.com \
--to=vigneshr@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).