Re: [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa

[Sungbo Eo <mans0n@gorani.run>]

On 2021-07-17 01:11, Michael Walle wrote:
> Am 2021-06-20 10:56, schrieb Sungbo Eo:
>> The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
>> 0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn bits
>> are non-volatile, unlike its older version.
>>
>> References: 
>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
>> References:
>> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
> 
> "Datasheet:" please
> 
>> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
>> ---
>> At first I was going to send a new support patch of F25L16PA(2S),
>> but before that, I wanted to make sure if "(2s)" suffix is okay or 
>> unnecessary.
>> ---
>>  drivers/mtd/spi-nor/esmt.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
>> index cfc9218c1053..51b3ff764ef6 100644
>> --- a/drivers/mtd/spi-nor/esmt.c
>> +++ b/drivers/mtd/spi-nor/esmt.c
>> @@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
>>      /* ESMT */
>>      { "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
>>                 SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
>> -    { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
>> -               SECT_4K | SPI_NOR_HAS_LOCK) },
>> +    { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
>> +                   SECT_4K | SPI_NOR_HAS_LOCK) },
>>      { "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
>>                 SECT_4K | SPI_NOR_HAS_LOCK) },
>>  };
> 
> Tudor has decide on that name - or the use of parentheses. I don't have a
> strong opinion on it.

I'm concerned that any other devices do not contain parentheses in their 
model names... I'm fine with "f25l32qa-2s" if preferred.

> 
> FWIW,
> Reviewed-by: Michael Walle <michael@walle.cc>

Thanks for your review!

> 
> -michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/