From: "Behme Dirk (CM/ESO2)" <dirk.behme@de.bosch.com>
To: Vignesh Raghavendra <vigneshr@ti.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH RFT 0/2/2] mtd: hyperbus: add Renesas RPC-IF driver
Date: Tue, 18 Feb 2020 08:12:27 +0100 [thread overview]
Message-ID: <eed17a25-e21c-b493-98e8-e25150216731@de.bosch.com> (raw)
In-Reply-To: <16309076-4378-d9ff-30c3-93a46af1d803@ti.com>
Hi Vignesh,
On 18.02.2020 05:00, Vignesh Raghavendra wrote:
> Hi Sergei
>
> On 30/01/20 2:09 am, Sergei Shtylyov wrote:
>> Add the HyperFLash driver for the Renesas RPC-IF. It's the "front end"
>> driver using the "back end" APIs in the main driver to talk to the real
>> hardware.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> drivers/mtd/hyperbus/Kconfig | 6 +
>> drivers/mtd/hyperbus/Makefile | 1
>> drivers/mtd/hyperbus/rpc-if.c | 162 ++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 169 insertions(+)
>>
>> Index: linux/drivers/mtd/hyperbus/Kconfig
>> ===================================================================
>> --- linux.orig/drivers/mtd/hyperbus/Kconfig
>> +++ linux/drivers/mtd/hyperbus/Kconfig
>> @@ -22,4 +22,10 @@ config HBMC_AM654
>> This is the driver for HyperBus controller on TI's AM65x and
>> other SoCs
>>
>> +config RPCIF_HYPERBUS
>> + tristate "Renesas RPC-IF HyperBus driver"
>> + depends on RENESAS_RPCIF
>> + help
>> + This option includes Renesas RPC-IF HyperFlash support.
>> +
>> endif # MTD_HYPERBUS
>> Index: linux/drivers/mtd/hyperbus/Makefile
>> ===================================================================
>> --- linux.orig/drivers/mtd/hyperbus/Makefile
>> +++ linux/drivers/mtd/hyperbus/Makefile
>> @@ -2,3 +2,4 @@
>>
>> obj-$(CONFIG_MTD_HYPERBUS) += hyperbus-core.o
>> obj-$(CONFIG_HBMC_AM654) += hbmc-am654.o
>> +obj-$(CONFIG_RPCIF_HYPERBUS) += rpc-if.o
>> Index: linux/drivers/mtd/hyperbus/rpc-if.c
>> ===================================================================
>> --- /dev/null
>> +++ linux/drivers/mtd/hyperbus/rpc-if.c
>> @@ -0,0 +1,162 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Linux driver for RPC-IF HyperFlash
>> + *
>> + * Copyright (C) 2019 Cogent Embedded, Inc.
>> + */
>> +
>> +#include <linux/err.h>
>> +#include <linux/kernel.h>
>> +#include <linux/module.h>
>> +#include <linux/mtd/hyperbus.h>
>> +#include <linux/mtd/mtd.h>
>> +#include <linux/mux/consumer.h>
>> +#include <linux/of.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/types.h>
>> +
>> +#include <memory/renesas-rpc-if.h>
>> +
>> +struct rpcif_hyperbus {
>> + struct rpcif rpc;
>> + struct hyperbus_ctlr ctlr;
>> + struct hyperbus_device hbdev;
>> +};
>> +
>> +static const struct rpcif_op rpcif_op_tmpl = {
>> + .cmd = {
>> + .buswidth = 8,
>> + .ddr = true,
>> + },
>> + .ocmd = {
>> + .buswidth = 8,
>> + .ddr = true,
>> + },
>> + .addr = {
>> + .nbytes = 1,
>> + .buswidth = 8,
>> + .ddr = true,
>> + },
>> + .data = {
>> + .buswidth = 8,
>> + .ddr = true,
>> + },
>> +};
>> +
>
> Looking around, there seems to be more than one SPI controllers, apart
> from Renesas, which also support SPI NOR and HyperFlash protocol within
> a single IP block. E.g.: Cadence xSPI controller [1]. Therefore, we need
> a generic framework to support these kind of controllers.
>
> One way would be to extend spi_mem_op to support above template along
> with a new field to distinguish SPI NOR vs HyperFlash protocol. HyperBus
> core can then register a spi_device and use spi-mem ops to talk to
> controller driver.
> So, I suggest making Renesas RPC-IF backend a full fledged spi-mem
> driver (instead of driver/memory) and use extended spi_mem_op to support
> HyperFlash.
From Renesas Hyperflash user point of view, I wonder if a two step
approach would be possible and acceptable, here?
Being a user of the Renesas Hyperflash, I want a driver for that. And,
of course, I want it "now" ;)
So I wonder if it would be a valid option to have a functioning Renesas
Hypeflash driver, first. And in a second step abstract that in a more
generic way to support additional controllers. While in parallel having
a functional driver for the Renesas people, already.
Is the support for [1] a more or less theoretical one, at the moment? Or
are there users of that which need support "now", too?
Best regards
Dirk
> [1]
> https://ip.cadence.com/uploads/1244/cdn-dsd-mem-fla-host-controller-ip-for-xspi-pdf
>
>
> Regards
> Vignesh
>
>> +static u16 rpcif_hb_read16(struct hyperbus_device *hbdev, unsigned long addr)
>> +{
>> + struct rpcif_hyperbus *hyperbus =
>> + container_of(hbdev, struct rpcif_hyperbus, hbdev);
>> + struct rpcif_op op = rpcif_op_tmpl;
>> + map_word data;
>> +
>> + op.cmd.opcode = 0xC0;
>> + op.addr.val = addr >> 1;
>> + op.dummy.buswidth = 1;
>> + op.dummy.ncycles = 15;
>> + op.data.dir = RPCIF_DATA_IN;
>> + op.data.nbytes = 2;
>> + op.data.buf.in = &data;
>> + rpcif_prepare(&hyperbus->rpc, &op, NULL, NULL); // ?
>> + rpcif_io_xfer(&hyperbus->rpc);
>> +
>> + return be16_to_cpu(data.x[0]);
>> +}
>> +
>> +static void rpcif_hb_write16(struct hyperbus_device *hbdev, unsigned long addr,
>> + u16 data)
>> +{
>> + struct rpcif_hyperbus *hyperbus =
>> + container_of(hbdev, struct rpcif_hyperbus, hbdev);
>> + struct rpcif_op op = rpcif_op_tmpl;
>> +
>> + op.cmd.opcode = 0x40;
>> + op.addr.val = addr >> 1;
>> + op.data.dir = RPCIF_DATA_OUT;
>> + op.data.nbytes = 2;
>> + op.data.buf.out = &data;
>> + cpu_to_be16s(&data);
>> + rpcif_prepare(&hyperbus->rpc, &op, NULL, NULL); // ?
>> + rpcif_io_xfer(&hyperbus->rpc);
>> +}
>> +
>> +static void rpcif_hb_copy_from(struct hyperbus_device *hbdev, void *to,
>> + unsigned long from, ssize_t len)
>> +{
>> + struct rpcif_hyperbus *hyperbus =
>> + container_of(hbdev, struct rpcif_hyperbus, hbdev);
>> + struct rpcif_op op = rpcif_op_tmpl;
>> +
>> + op.cmd.opcode = 0xA0;
>> + op.addr.val = from;
>> + op.dummy.buswidth = 1;
>> + op.dummy.ncycles = 15;
>> + op.data.dir = RPCIF_DATA_IN;
>> + op.data.nbytes = len;
>> + op.data.buf.in = to;
>> + rpcif_prepare(&hyperbus->rpc, &op, NULL, NULL); // ?
>> + rpcif_dirmap_read(&hyperbus->rpc, from, len, to);
>> +}
>> +
>> +static const struct hyperbus_ops rpcif_hb_ops = {
>> + .read16 = rpcif_hb_read16,
>> + .write16 = rpcif_hb_write16,
>> + .copy_from = rpcif_hb_copy_from,
>> +};
>> +
>> +static int rpcif_hb_probe(struct platform_device *pdev)
>> +{
>> + struct device *dev = &pdev->dev;
>> + struct rpcif_hyperbus *hyperbus;
>> + int status;
>> +
>> + hyperbus = devm_kzalloc(dev, sizeof(*hyperbus), GFP_KERNEL);
>> + if (!hyperbus)
>> + return -ENOMEM;
>> +
>> + rpcif_sw_init(&hyperbus->rpc, pdev->dev.parent);
>> +
>> + platform_set_drvdata(pdev, hyperbus);
>> +
>> + rpcif_enable_rpm(&hyperbus->rpc);
>> +
>> + rpcif_hw_init(&hyperbus->rpc, true);
>> +
>> + hyperbus->hbdev.map.size = hyperbus->rpc.size;
>> + hyperbus->hbdev.map.virt = hyperbus->rpc.dirmap;
>> +
>> + hyperbus->ctlr.dev = dev;
>> + hyperbus->ctlr.ops = &rpcif_hb_ops;
>> + hyperbus->hbdev.ctlr = &hyperbus->ctlr;
>> + hyperbus->hbdev.np = of_get_next_child(pdev->dev.parent->of_node, NULL);
>> + status = hyperbus_register_device(&hyperbus->hbdev);
>> + if (status) {
>> + dev_err(dev, "failed to register device\n");
>> + rpcif_disable_rpm(&hyperbus->rpc);
>> + }
>> +
>> + return status;
>> +}
>> +
>> +static int rpcif_hb_remove(struct platform_device *pdev)
>> +{
>> + struct rpcif_hyperbus *hyperbus = platform_get_drvdata(pdev);
>> + int error = hyperbus_unregister_device(&hyperbus->hbdev);
>> + struct rpcif *rpc = dev_get_drvdata(pdev->dev.parent);
>> +
>> + rpcif_disable_rpm(rpc);
>> + return error;
>> +}
>> +
>> +static struct platform_driver rpcif_platform_driver = {
>> + .probe = rpcif_hb_probe,
>> + .remove = rpcif_hb_remove,
>> + .driver = {
>> + .name = "rpc-if-hyperflash",
>> + },
>> +};
>> +
>> +module_platform_driver(rpcif_platform_driver);
>> +
>> +MODULE_DESCRIPTION("Renesas RPC-IF HyperFlash driver");
>> +MODULE_LICENSE("GPL v2");
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-18 7:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 20:32 [PATCH RFT 0/2] Add RPC-IF HyperFlash driver Sergei Shtylyov
2020-01-29 20:37 ` [PATCH RFT 1/2] mtd: hyperbus: move direct mapping setup to AM654 HBMC driver Sergei Shtylyov
2020-03-13 5:21 ` Vignesh Raghavendra
2020-01-29 20:39 ` [PATCH RFT 0/2/2] mtd: hyperbus: add Renesas RPC-IF driver Sergei Shtylyov
2020-02-03 4:59 ` Vignesh Raghavendra
2020-02-03 11:46 ` Sergei Shtylyov
2020-02-07 12:59 ` Behme Dirk (CM/ESO2)
2020-02-07 19:09 ` Sergei Shtylyov
2020-02-07 19:31 ` Dirk Behme
2020-02-07 20:17 ` Sergei Shtylyov
2020-02-10 9:18 ` Behme Dirk (CM/ESO2)
2020-02-18 4:00 ` Vignesh Raghavendra
2020-02-18 7:12 ` Behme Dirk (CM/ESO2) [this message]
2020-02-18 11:11 ` Vignesh Raghavendra
2020-02-20 18:30 ` Sergei Shtylyov
2020-02-24 5:27 ` Vignesh Raghavendra
2020-02-19 20:13 ` Sergei Shtylyov
2020-02-20 6:05 ` Vignesh Raghavendra
2020-02-20 7:46 ` Boris Brezillon
2020-02-20 7:49 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eed17a25-e21c-b493-98e8-e25150216731@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).