From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2507C4CEC4 for ; Wed, 18 Sep 2019 05:45:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B779821848 for ; Wed, 18 Sep 2019 05:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gRUF7fTV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZLIhuMuh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B779821848 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TcZxGl5zwcyfPpDeHV0IOtpXMtmO9lFVg4bU3cofrb4=; b=gRUF7fTV7CoQPf ODsMzpP0SP4i1taONxKZIN9i184b19In/WIcUO1akIuqAGZ32AnYj6vEfEF4LRFvD482dJE1TMI1s UQV04oAVcE7Af+iFAxSNN54Rwyp9Lf5q53Y0ENisqHWbn844Q6dN0kH5Nno5f83x1xr9PJEVf34bv sbX2SfNqRAjtCClihnQ7r9/WqtUI3Eg4s0Gkga3NVC/STeh90Er4BJM3sIgb719grnhuTbh9KIPF+ obKaL6BgsrBN0ogp7feFaW32yTSClyRWIRo0VdlCxF86L/SVRPx/Z13sltVfJFJWoVrJ6MjKbdYLY 7uksxR8wkhYEkvZoIj0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iASmM-000814-AA; Wed, 18 Sep 2019 05:45:26 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iASmJ-00080d-C1 for linux-mtd@lists.infradead.org; Wed, 18 Sep 2019 05:45:24 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8I5iwVk083894; Wed, 18 Sep 2019 00:44:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1568785498; bh=7pG9/InaMSwJjn0yQpoBq7e14aVoFDf5QOSWplTd8hM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=ZLIhuMuhDMAAVa/OB57tiW6AEdePr3n7ZG8cw4fMVrCsTbdfklR7+96PSeevFfAeq W1gak/1zW2G/19fsI2qxAWgIQOqcWRTZkiUuLkHvSYxXfpGY+EIg+15yDEOuFItoNx 7pR/kd6Y05ea3LGzcvrJ/S9tinY7zcRpyJl4b+Ys= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x8I5iw9b075287 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Sep 2019 00:44:58 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 18 Sep 2019 00:44:58 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 18 Sep 2019 00:44:58 -0500 Received: from [172.24.145.136] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8I5itkA022686; Wed, 18 Sep 2019 00:44:55 -0500 Subject: Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay() To: Geert Uytterhoeven , Sergei Shtylyov References: <610761cf-5a19-c182-07d8-8d118ca20035@cogentembedded.com> <90d87853-621f-890a-be59-1591cfe1f4ea@cogentembedded.com> From: Vignesh Raghavendra Message-ID: Date: Wed, 18 Sep 2019 11:15:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_224523_494004_F1072E8D X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , Marek Vasut , MTD Maling List , Miquel Raynal , Brian Norris , David Woodhouse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Sergei, On 18/09/19 2:53 AM, Geert Uytterhoeven wrote: > Hi Sergei, > > On Tue, Sep 17, 2019 at 9:53 PM Sergei Shtylyov > wrote: >> On 09/17/2019 10:43 PM, Geert Uytterhoeven wrote: >>>> cfi_udelay() open-codes DIV_ROUND_UP(), violating the kernel coding style >>> >>> Perhaps "violating" sounds a bit too harsh? >> >> Hm, indeed, scripts/checkpatch.pl doesn't complain on this line. Do you have >> other ideas how to call this? Or just omit this? > scripts/checkpatch.pl --strict will complain about this. > Just "use the existing helper, instead of open-coding the same operation"? I agree with Geert. This driver file predates checkpatch and therefore does not follow all kernel coding styles. But its good to replace open-coding with available helper macro. Also, please don't post new patches in reply to an existing thread. This patch appears in-reply-to ("mtd: devices: m25p80: Use the spi-mem dirmap API") which is unrelated to current patch. -- Regards Vignesh ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/