Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: "Måns Rullgård" <mans@mansr.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: vigneshr@ti.com, marc.w.gonzalez@free.fr, richard@nod.at,
	marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
	miquel.raynal@bootlin.com, computersforpeace@gmail.com,
	dwmw2@infradead.org
Subject: Re: [PATCH] mtd: rawnand: tango: Add of_node_put() before return
Date: Tue, 09 Jul 2019 19:42:48 +0100
Message-ID: <yw1xtvbvf3rr.fsf@mansr.com> (raw)
In-Reply-To: <20190709171316.13451-1-nishkadg.linux@gmail.com>

Nishka Dasgupta <nishkadg.linux@gmail.com> writes:

> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
>  drivers/mtd/nand/raw/tango_nand.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/tango_nand.c b/drivers/mtd/nand/raw/tango_nand.c
> index b3f2cabcc7c0..9acf2de37ee0 100644
> --- a/drivers/mtd/nand/raw/tango_nand.c
> +++ b/drivers/mtd/nand/raw/tango_nand.c
> @@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev)
>  		err = chip_init(&pdev->dev, np);
>  		if (err) {
>  			tango_nand_remove(pdev);
> +			of_node_put(np);
>  			return err;
>  		}
>  	}
> -- 

Acked-by: Mans Rullgard <mans@mansr.com>

-- 
Måns Rullgård

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09 17:13 Nishka Dasgupta
2019-07-09 18:42 ` Måns Rullgård [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yw1xtvbvf3rr.fsf@mansr.com \
    --to=mans@mansr.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=marek.vasut@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=nishkadg.linux@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org linux-mtd@archiver.kernel.org
	public-inbox-index linux-mtd


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/ public-inbox