linux-next: Fixes tag needs some work in the wireless-drivers-next tree

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi all,

In commit

  c709df58832c ("ath10k: Fix memory leak in qmi")

Fixes tag

  Fixes: fda6fee0001e ("ath10k: add QMI message handshake for wcn3990 client")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[dundi]

Hi Stephen,

You are correct, Its
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")

My bad, I added last 12 digits instead of first 12 digits of SHA1.

Regards,
Dundi

-----Original Message-----
From: Stephen Rothwell <sfr@canb.auug.org.au> 
Sent: Tuesday, July 2, 2019 3:03 AM
To: Kalle Valo <kvalo@codeaurora.org>; Wireless
<linux-wireless@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
Mailing List <linux-kernel@vger.kernel.org>; Dundi Raviteja
<dundi@codeaurora.org>
Subject: linux-next: Fixes tag needs some work in the wireless-drivers-next
tree

Hi all,

In commit

  c709df58832c ("ath10k: Fix memory leak in qmi")

Fixes tag

  Fixes: fda6fee0001e ("ath10k: add QMI message handshake for wcn3990
client")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Kalle Valo]

Hi Stephen,

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> On Wed, 19 Aug 2020 09:52:47 +0300 Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> Doh, I have checked carefully the commit ids but of course I missed
>> checking the trailing. I really need to automate this. Stephen, are your
>> scripts checking these available somewhere?
>
> I have attached them to this reply.  

Thanks a lot, these scripts are very helpful. For example with these I
quickly found a problem in one pull request I recently got. I do see
some cosmetic problems, most likely due to my git settings or version,
but should be easy to fix.

> I should put them up in a git repo somewhere.

Yeah, please do. I'm sure people would benefit from these.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 498 bytes --]

Hi Kalle,

On Wed, 19 Aug 2020 09:52:47 +0300 Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Doh, I have checked carefully the commit ids but of course I missed
> checking the trailing. I really need to automate this. Stephen, are your
> scripts checking these available somewhere?

I have attached them to this reply.  I should put them up in a git repo somewhere.

> But I'll leave this as is, no point of rebasing just because of this.

Fair enough.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4197 bytes --]

[-- Attachment #1.3: check_commits --]
[-- Type: application/x-shellscript, Size: 1611 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Kalle Valo]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> In commit
>
>   3b9fb6791e71 ("wcn36xx: Fix reported 802.11n rx_highest rate wcn3660/wcn3680")
>
> Fixes tag
>
>   Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more that one line.  Also, keep all
> the commit message tags together at the end of the message.

Doh, I have checked carefully the commit ids but of course I missed
checking the trailing. I really need to automate this. Stephen, are your
scripts checking these available somewhere?

But I'll leave this as is, no point of rebasing just because of this.
Thanks for the report.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Hi all,

In commit

  3b9fb6791e71 ("wcn36xx: Fix reported 802.11n rx_highest rate wcn3660/wcn3680")

Fixes tag

  Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more that one line.  Also, keep all
the commit message tags together at the end of the message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Kalle Valo]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> In commit
>
>   4c7e1711cf4c ("mt76: mt7915: fix potential memory leak in mcu message handler")
>
> Fixes tag
>
>   Fixes: c6b002bcdfa6 ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")

Yeah, that should have been it but it's too much work to fix this now so
I'll just leave it be. Thanks for the report.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi all,

In commit

  4c7e1711cf4c ("mt76: mt7915: fix potential memory leak in mcu message handler")

Fixes tag

  Fixes: c6b002bcdfa6 ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Kalle Valo]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> In commit
>
>   ad96bc27032c ("brcmfmac: initialize the requested dwell time")
>
> Fixes tag
>
>   Fixes: 4905432b28b7 ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
>
> Maybe you meant
>
> Fixes: 9c29da3f4e7e ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")

Heh, I noticed this and I even fixed it but maybe forgot to save my edit
or something. I'll need to be more careful next time.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi all,

In commit

  ad96bc27032c ("brcmfmac: initialize the requested dwell time")

Fixes tag

  Fixes: 4905432b28b7 ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")

has these problem(s):

  - Target SHA1 does not exist


Maybe you meant

Fixes: 9c29da3f4e7e ("brcmfmac: Fix P2P Group Formation failure via Go-neg method")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Kalle Valo]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> In commit
>
>   f8d6379932dd ("mt76: mt7663: fix the usage WoW with net detect support")
>
> Fixes tag
>
>   Fixes: bd39bd2f00c3 ("mt76: mt7663: introduce WoW with net detect support")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a72ad451e704 ("mt76: mt7663: introduce WoW with net detect support")

Thanks for the report. I don't think this is bad enough to start
rebasing wireless-drivers-next so I'll leave it as is. But I'll try to
implement some kind of checking of Fixes tags in the future.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  f8d6379932dd ("mt76: mt7663: fix the usage WoW with net detect support")

Fixes tag

  Fixes: bd39bd2f00c3 ("mt76: mt7663: introduce WoW with net detect support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a72ad451e704 ("mt76: mt7663: introduce WoW with net detect support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Kalle Valo]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Larry,
>
> On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
>> > 
>> > In commit
>> > 
>> >    ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
>> > 
>> > Fixes tag
>> > 
>> >    Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
>> > 
>> > has these problem(s):
>> > 
>> >    - Subject does not match target commit subject
>> >      Just use
>> > 	git log -1 --format='Fixes: %h ("%s")'
>> 
>> I do not understand what you want here. The subject describes what was fixed. 
>> The error has been in the driver since it was merged. The Fixes: line is a 
>> description of the commit that introduced the driver file with the error.
>
> The subject I was referring to is the subject quoted in the Fixes tag,
> not the subject of the fixing commit.  So:
>
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for
> legacy BCM43xx devices")
>
> Its not very important, just a consistency thing - I wouldn't bother
> rebasing just to fix this, just for the future ...

Yeah, I don't normally rebase wireless-drivers-next so this has to be
like this. But hopefully some time in the future I'll end up adding a
check for this in my patchwork script.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hi Larry,

On Tue, 14 Apr 2020 19:36:28 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 4/14/20 5:08 PM, Stephen Rothwell wrote:
> > 
> > In commit
> > 
> >    ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
> > 
> > Fixes tag
> > 
> >    Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> > 
> > has these problem(s):
> > 
> >    - Subject does not match target commit subject
> >      Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> 
> I do not understand what you want here. The subject describes what was fixed. 
> The error has been in the driver since it was merged. The Fixes: line is a 
> description of the commit that introduced the driver file with the error.

The subject I was referring to is the subject quoted in the Fixes tag,
not the subject of the fixing commit.  So:

Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")

Its not very important, just a consistency thing - I wouldn't bother
rebasing just to fix this, just for the future ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Larry Finger]

On 4/14/20 5:08 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")
> 
> Fixes tag
> 
>    Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")
> 
> has these problem(s):
> 
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 

Stephan,

I do not understand what you want here. The subject describes what was fixed. 
The error has been in the driver since it was merged. The Fixes: line is a 
description of the commit that introduced the driver file with the error.

Larry

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Hi all,

In commit

  ec4d3e3a0545 ("b43legacy: Fix case where channel status is corrupted")

Fixes tag

  Fixes: 75388acd0cd8 ("add mac80211-based driver for legacy BCM43xx devices")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Kalle Valo]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> n commit
>
>   6ba8b3b6bd77 ("ath10k: Correct the DMA direction for management tx buffers")
>
> Fixes tag
>
>   Fixes: dc405152bb6 ("ath10k: handle mgmt tx completion event")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Doh, I missed that but naturally there's nothing we can do now as the
commit is in Linus' tree. I really should implement some kind of
automatic check to my patchwork script for this.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

n commit

  6ba8b3b6bd77 ("ath10k: Correct the DMA direction for management tx buffers")

Fixes tag

  Fixes: dc405152bb6 ("ath10k: handle mgmt tx completion event")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Lorenzo Bianconi]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

> Hi all,
> 
> In commit
> 
>   d923cf6bc38a ("mt76: mt7615: fix sparse warnings: warning: cast from restricted __le16")
> 
> Fixes tag
> 
>   Fixes: 3ca0a6f6e9df ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: 516c3e380533 ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")
> 
> In commit
> 
>   eda96044de27 ("mt76: mt7615: fix sparse warnings: incorrect type in assignment (different base types)")
> 
> Fixes tag
> 
>   Fixes: 7339fbc0caa5 ("mt7615: mcu: do not use function pointers whenever possible")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: 1ca8089a55ee ("mt7615: mcu: do not use function pointers whenever possible")
> 
> In commit
> 
>   1a09d9e0e5f0 ("mt76: mt7615: fix incorrect settings in mesh mode")
> 
> Fixes tag
> 
>   Fixes: f072c7ba2150 ("mt76: mt7615: enable support for mesh")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: f4ec7fdf7f83 ("mt76: mt7615: enable support for mesh")

Hi Stephen,

I used the hashes from my local git tree that are different from upstream ones,
sorry for the inconvenience. I will pay more attention next time.

Regards,
Lorenzo

> 
> -- 
> Cheers,
> Stephen Rothwell



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

Hi all,

In commit

  d923cf6bc38a ("mt76: mt7615: fix sparse warnings: warning: cast from restricted __le16")

Fixes tag

  Fixes: 3ca0a6f6e9df ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 516c3e380533 ("mt7615: mcu: use standard signature for mt7615_mcu_msg_send")

In commit

  eda96044de27 ("mt76: mt7615: fix sparse warnings: incorrect type in assignment (different base types)")

Fixes tag

  Fixes: 7339fbc0caa5 ("mt7615: mcu: do not use function pointers whenever possible")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 1ca8089a55ee ("mt7615: mcu: do not use function pointers whenever possible")

In commit

  1a09d9e0e5f0 ("mt76: mt7615: fix incorrect settings in mesh mode")

Fixes tag

  Fixes: f072c7ba2150 ("mt76: mt7615: enable support for mesh")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: f4ec7fdf7f83 ("mt76: mt7615: enable support for mesh")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Hi all,

In commit

  9280f4fc06f4 ("ath10k: Fix the wrong value of enums for wmi tlv stats id")

Fixes tag

  Fixes: f40a307eb92c ("ath10k: Fill rx duration for each peer in fw_stats for WCN3990)

has these problem(s):

  - Subject has leading but no trailing quotes

In commit

  93ee3d108fc7 ("ath10k: fix incorrect multicast/broadcast rate setting")

Fixes tag

  Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the wireless-drivers-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hi all,

In commit

  9c7c756eb066 ("mt76: mt76x02: mt76x02_poll_tx() can be static")

Fixes tag

  Fixes: ec7d2d74760a ("mt76: mt76x02: use napi polling for tx cleanup")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 2ac515a5d74f ("mt76: mt76x02: use napi polling for tx cleanup")

And BTW, we prefer real names on Signed-off-by tags ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]