linux-next: Signed-off-by missing for commits in the net-next tree

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Hi all,

Commits

  dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
  04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Andrew Lunn]

On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
> 
> are missing a Signed-off-by from their author.

Hi David.

Any idea what happened here? The version in my git repo has SOB.

https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.

     Thanks
	Andrew

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Heiner Kallweit]

On 09.12.2018 22:11, Andrew Lunn wrote:
> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commits
>>
>>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
>>
>> are missing a Signed-off-by from their author.
> 
> Hi David.
> 
> Any idea what happened here? The version in my git repo has SOB.
> 
> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
> 
Instead of
v2
--
int -> u32 in platform data structure

Signed-off-by: Andrew Lunn <andrew@lunn.ch>

shouldn't it be

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
v2
- int -> u32 in platform data structure

?

Heiner
>      Thanks
> 	Andrew
> 

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Andrew Lunn]

On Sun, Dec 09, 2018 at 10:33:10PM +0100, Heiner Kallweit wrote:
> On 09.12.2018 22:11, Andrew Lunn wrote:
> > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Commits
> >>
> >>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
> >>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
> >>
> >> are missing a Signed-off-by from their author.
> > 
> > Hi David.
> > 
> > Any idea what happened here? The version in my git repo has SOB.
> > 
> > https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
> > 
> Instead of
> v2
> --
> int -> u32 in platform data structure
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> shouldn't it be
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v2
> - int -> u32 in platform data structure

Hi Heiner

David said he wanted to see the version history. So i deliberately put
it above the ---.

I'm just wondering if -- was enough to trigger something in David's
scripts? Or patchwork. The -- has disappeared in the commit which made
it into net-next.

   Andrew

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Sabrina Dubroca]

2018-12-09, 22:49:07 +0100, Andrew Lunn wrote:
> On Sun, Dec 09, 2018 at 10:33:10PM +0100, Heiner Kallweit wrote:
> > On 09.12.2018 22:11, Andrew Lunn wrote:
> > > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
> > >> Hi all,
> > >>
> > >> Commits
> > >>
> > >>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
> > >>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
> > >>
> > >> are missing a Signed-off-by from their author.
> > > 
> > > Hi David.
> > > 
> > > Any idea what happened here? The version in my git repo has SOB.
> > > 
> > > https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
> > > 
> > Instead of
> > v2
> > --
> > int -> u32 in platform data structure
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > 
> > shouldn't it be
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > v2
> > - int -> u32 in platform data structure
> 
> Hi Heiner
> 
> David said he wanted to see the version history. So i deliberately put
> it above the ---.
> 
> I'm just wondering if -- was enough to trigger something in David's
> scripts? Or patchwork. The -- has disappeared in the commit which made
> it into net-next.
> 
>    Andrew

If you fetch the mbox from patchwork at

    https://patchwork.ozlabs.org/patch/1009811/mbox/

it contains:

-------- 8< --------
v2
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
int -> u32 in platform data structure

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
[diffstat]
-------- 8< --------

That's 3 dashes instead of the 2 from your mail. If you "git am" that,
the sign-off and actual history will get chopped off.

Maybe Stephen's script to detect those missing sign-offs could be run
as a commit/apply hook by David? This happens regularly, sometimes
dropping more than just a sign-off.

-- 
Sabrina

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[David Miller]

From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 9 Dec 2018 22:11:39 +0100

> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
>> Hi all,
>> 
>> Commits
>> 
>>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
>> 
>> are missing a Signed-off-by from their author.
> 
> Hi David.
> 
> Any idea what happened here? The version in my git repo has SOB.
> 
> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.

I wonder if "git am" ate it. :-/

Yeah it's the '--' I think.

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[David Miller]

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 9 Dec 2018 22:33:10 +0100

> On 09.12.2018 22:11, Andrew Lunn wrote:
>> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>>   dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>>>   04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
>>>
>>> are missing a Signed-off-by from their author.
>> 
>> Hi David.
>> 
>> Any idea what happened here? The version in my git repo has SOB.
>> 
>> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
>> 
> Instead of
> v2
> --
> int -> u32 in platform data structure
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> shouldn't it be
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v2
> - int -> u32 in platform data structure

No, I want the changelog to actually appear in the commit message.

I'm kinda tired of saying this.

Keep changelog information in the commit message, everyone.

The problem here is the '--' delimiter, Andrew should have either
used nothing or something else.

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[David Miller]

From: Sabrina Dubroca <sd@queasysnail.net>
Date: Mon, 10 Dec 2018 00:27:22 +0100

> Maybe Stephen's script to detect those missing sign-offs could be run
> as a commit/apply hook by David? This happens regularly, sometimes
> dropping more than just a sign-off.

Yeah, that would probably be a good idea, maybe something even on the
git.kernel.org side that won't let me push if I'm sending commits that
have this problem.

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2345 bytes --]

Hi Dave,

On Sun, 09 Dec 2018 16:31:52 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> From: Sabrina Dubroca <sd@queasysnail.net>
> Date: Mon, 10 Dec 2018 00:27:22 +0100
> 
> > Maybe Stephen's script to detect those missing sign-offs could be run
> > as a commit/apply hook by David? This happens regularly, sometimes
> > dropping more than just a sign-off.  
> 
> Yeah, that would probably be a good idea, maybe something even on the
> git.kernel.org side that won't let me push if I'm sending commits that
> have this problem.

That is fine as a last resort, but it is probably less disruptive to
find these things before you try to push i.e. as part of the "apply the
patch" otherwise you could end up having to rebase a whole lot of later
commits.

Anyway, here's my current version of my script.  It just takes a commit
range (anything you can pass to "git log").  You may want to drop the
gitk invocation at the end.

--------------------------------------------------------------------
#!/bin/bash

if [ "$#" -lt 1 ]; then
	printf "Usage: %s <commit range>\n", "$0" 1>&2
	exit 1
fi

commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
	printf "No commits\n"
	exit 0
fi

author_missing=
committer_missing=

print_commits()
{
	local t="$1"

	shift

	s=
	is='is'
	its='its'
	[ "$#" -gt 1 ] && {
		s='s'
		is='are'
		its='their'
	}
	printf "Commit%s\n\n" "$s"
	git log --no-walk --pretty='format:  %h ("%s")' "$@"
	printf "\n%s missing a Signed-off-by from %s %s%s.\n" "$is" "$its" "$t" "$s"
	printf "\n"
}

for c in $commits; do
	ae=$(git log -1 --format='<%ae>%n<%aE>%n %an %n %aN ' "$c" | sort -u)
	ce=$(git log -1 --format='<%ce>%n<%cE>%n %cn %n %cN ' "$c" | sort -u)
	msg=$(git log -1 --format='%b' "$c")
	sob=$(echo "$msg" | sed -En 's/^\s*Signed-off-by:?\s*/ /ip')

	am=false
	cm=false
	grep -i -F -q "$ae" <<<"$sob" ||
		am=true
	grep -i -F -q "$ce" <<<"$sob" ||
		cm=true
	"$am" && author_missing+=" $c"
	"$cm" && committer_missing+=" $c"
done

if [ "$author_missing" ]; then
	print_commits "author" $author_missing
fi
if [ "$committer_missing" ]; then
	print_commits "committer" $committer_missing
fi

exec gitk "$@"
--------------------------------------------------------------------

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 10 Dec 2018 11:48:48 +1100

> That is fine as a last resort, but it is probably less disruptive to
> find these things before you try to push i.e. as part of the "apply the
> patch" otherwise you could end up having to rebase a whole lot of later
> commits.

I meant to imply that we should do both, something I do pre-commit
and something that double checks again when I push.

Sorry if I wasn't clear.

> Anyway, here's my current version of my script.  It just takes a commit
> range (anything you can pass to "git log").  You may want to drop the
> gitk invocation at the end.

Thanks!

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Hi Dave,

On Sun, 09 Dec 2018 16:54:43 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 10 Dec 2018 11:48:48 +1100
> 
> > That is fine as a last resort, but it is probably less disruptive to
> > find these things before you try to push i.e. as part of the "apply the
> > patch" otherwise you could end up having to rebase a whole lot of later
> > commits.  
> 
> I meant to imply that we should do both, something I do pre-commit
> and something that double checks again when I push.
> 
> Sorry if I wasn't clear.

No worries, belts and braces :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Andrew Lunn]

> The problem here is the '--' delimiter, Andrew should have either
> used nothing or something else.

I picked -- because it was not --- !

Anyway, lesson learned. But i kind of expect it will happen again to
others, since the "Submitting Patches" documentation just mentions ---
and does not say that other similar markers may also trigger the magic
scissors.

	Andrew

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Sabrina Dubroca]

2018-12-10, 14:35:00 +0100, Andrew Lunn wrote:
> > The problem here is the '--' delimiter, Andrew should have either
> > used nothing or something else.
> 
> I picked -- because it was not --- !
> 
> Anyway, lesson learned. But i kind of expect it will happen again to
> others, since the "Submitting Patches" documentation just mentions ---
> and does not say that other similar markers may also trigger the magic
> scissors.

-- doesn't trigger the scissors. It looks like patchwork replaced your
-- with a ---, as I wrote in my other reply.

-- 
Sabrina

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Jakub Kicinski]

On Tue, 8 Mar 2022 10:19:03 +1100 Stephen Rothwell wrote:
> > Would it be possible to add bluetooth trees to linux-next?
> > 
> > Marcel, Luiz, Johan, would it help?  
> 
> I already have
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
> branch master
> 
> in linux-next.  Those commits appeared in the bluetooth and net-next
> trees on the same day (Monday) for me.

I see :/

Thanks for checking.

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Hi Jakub,

On Mon, 7 Mar 2022 15:02:48 -0800 Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 7 Mar 2022 07:22:48 +1100 Stephen Rothwell wrote:
> > 
> > Commits
> > 
> >   c2b2a1a77f6b ("Bluetooth: Improve skb handling in mgmt_device_connected()")
> >   ba17bb62ce41 ("Bluetooth: Fix skb allocation in mgmt_remote_name() & mgmt_device_connected()")
> >   a6fbb2bf51ad ("Bluetooth: mgmt: Remove unneeded variable")
> >   8cd3c55c629e ("Bluetooth: hci_sync: fix undefined return of hci_disconnect_all_sync()")
> >   3a0318140a6f ("Bluetooth: mgmt: Replace zero-length array with flexible-array member")
> > 
> > are missing a Signed-off-by from their committer.  
> 
> Would it be possible to add bluetooth trees to linux-next?
> 
> Marcel, Luiz, Johan, would it help?

I already have

git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
branch master

in linux-next.  Those commits appeared in the bluetooth and net-next
trees on the same day (Monday) for me.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Jakub Kicinski]

On Mon, 7 Mar 2022 07:22:48 +1100 Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   c2b2a1a77f6b ("Bluetooth: Improve skb handling in mgmt_device_connected()")
>   ba17bb62ce41 ("Bluetooth: Fix skb allocation in mgmt_remote_name() & mgmt_device_connected()")
>   a6fbb2bf51ad ("Bluetooth: mgmt: Remove unneeded variable")
>   8cd3c55c629e ("Bluetooth: hci_sync: fix undefined return of hci_disconnect_all_sync()")
>   3a0318140a6f ("Bluetooth: mgmt: Replace zero-length array with flexible-array member")
> 
> are missing a Signed-off-by from their committer.

Would it be possible to add bluetooth trees to linux-next?

Marcel, Luiz, Johan, would it help?

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Hi all,

Commits

  c2b2a1a77f6b ("Bluetooth: Improve skb handling in mgmt_device_connected()")
  ba17bb62ce41 ("Bluetooth: Fix skb allocation in mgmt_remote_name() & mgmt_device_connected()")
  a6fbb2bf51ad ("Bluetooth: mgmt: Remove unneeded variable")
  8cd3c55c629e ("Bluetooth: hci_sync: fix undefined return of hci_disconnect_all_sync()")
  3a0318140a6f ("Bluetooth: mgmt: Replace zero-length array with flexible-array member")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Russell King (Oracle)]

On Thu, Jan 27, 2022 at 07:57:02AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()")
>   f4c296c90976 ("net: stmmac: remove phylink_config.pcs_poll usage")
>   d194923d51c9 ("net: stmmac: fill in supported_interfaces")
>   92c3807b9ac3 ("net: stmmac: convert to phylink_get_linkmodes()")
>   be6ec5b70266 ("net: xpcs: add support for retrieving supported interface modes")
> 
> are missing a Signed-off-by from their author.

Hi Stephen,

Sigh, this is more vim stupidity. The commits _look_ fine in vim and
look fine in git log on an 80 column display, but that is because the
"Tested-by" line somehow ended up with the perfect amount of space
characters to make it so.

This is not the first time this has happened - it keeps happening, and
I've no clue why it keeps happening, other than rediculous vi behaviour.
I'm sorry, but I don't see any solution to it at the moment. Maybe
someone can suggest something that (a) prevents it happening when I
paste in the Tested-by line, and (b) makes vim show when lines in a
commit message are longer than 80 characters?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi all,

Commits

  04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()")
  f4c296c90976 ("net: stmmac: remove phylink_config.pcs_poll usage")
  d194923d51c9 ("net: stmmac: fill in supported_interfaces")
  92c3807b9ac3 ("net: stmmac: convert to phylink_get_linkmodes()")
  be6ec5b70266 ("net: xpcs: add support for retrieving supported interface modes")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On Saturday, 21 August 2021 05:08:15 CEST Stephen Rothwell wrote:
[...]
>   71d41c09f1fa ("batman-adv: Move IRC channel to hackint.org")

Something went wrong here. The tag
https://git.open-mesh.org/linux-merge.git/tag/refs/tags/batadv-next-pullrequest-20210820 [1]
has this version of the patch:
https://git.open-mesh.org/linux-merge.git/commit/3baa9f522a0cad3cd8a45f4a5b85c3694cece672. 
And it seems like it has the correct Signed-off-by: and the patchwork-bot 
informed us that it was merged [2]

But it seems like 815cc21d8d2e47c2d00caf3cd4cddcf0b5b07292 merged [3] 
refs/tags/batadv-next-pullrequest-20210819 - an older version where we 
forgot this Signed-off-by (and Jakub informed us about it [4]).

Kind regards,
	Sven

[1] https://patchwork.kernel.org/project/netdevbpf/patch/20210820083300.32289-1-sw@simonwunderlich.de/
[2] https://lore.kernel.org/netdev/162946395159.27725.6381822484284696109.git-patchwork-notify@kernel.org/
[3] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=815cc21d8d2e47c2d00caf3cd4cddcf0b5b07292
[4] https://lore.kernel.org/netdev/20210819135238.354db062@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

Hi all,

Commits

  3202ea65f85c ("net/mlx5: E-switch, Add QoS tracepoints")
  0fe132eac38c ("net/mlx5: E-switch, Allow to add vports to rate groups")
  f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
  1ae258f8b343 ("net/mlx5: E-switch, Introduce rate limiting groups API")
  ad34f02fe2c9 ("net/mlx5: E-switch, Enable devlink port tx_{share|max} rate control")
  2d116e3e7e49 ("net/mlx5: E-switch, Move QoS related code to dedicated file")
  71d41c09f1fa ("batman-adv: Move IRC channel to hackint.org")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Saeed Mahameed]

On Mon, 2020-04-13 at 10:05 +1000, Stephen Rothwell wrote:
> Hi Saeed,
> 
> On Tue, 10 Mar 2020 23:57:31 +0000 Saeed Mahameed <
> saeedm@mellanox.com> wrote:
> > On Tue, 2020-03-10 at 21:01 +1100, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > Commits
> > > 
> > >   b63293e759a1 ("net/mlx5e: Show/set Rx network flow
> > > classification
> > > rules on ul rep")
> > >   6783e8b29f63 ("net/mlx5e: Init ethtool steering for
> > > representors")
> > >   01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS
> > > hash
> > > key on ul rep")
> > >   
> > 
> > Hi Stephen, 
> > 
> > checkpatch doesn't seem to catch such problems.. 
> > 
> > I count on our CI to do such checks for me, so instead of me
> > writing a 
> > new script every time we hit a new unforeseen issue, i was
> > wondering
> > where can i find the set of test/scripts you are running ? 
> 
> I have attached my scripts ...
> 

Thanks Stephen ! much appreciated.

Saeed.

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 829 bytes --]

Hi Saeed,

On Tue, 10 Mar 2020 23:57:31 +0000 Saeed Mahameed <saeedm@mellanox.com> wrote:
>
> On Tue, 2020-03-10 at 21:01 +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commits
> > 
> >   b63293e759a1 ("net/mlx5e: Show/set Rx network flow classification
> > rules on ul rep")
> >   6783e8b29f63 ("net/mlx5e: Init ethtool steering for representors")
> >   01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS hash
> > key on ul rep")
> >   
> 
> Hi Stephen, 
> 
> checkpatch doesn't seem to catch such problems.. 
> 
> I count on our CI to do such checks for me, so instead of me writing a 
> new script every time we hit a new unforeseen issue, i was wondering
> where can i find the set of test/scripts you are running ? 

I have attached my scripts ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_commits --]
[-- Type: application/x-shellscript, Size: 1611 bytes --]

[-- Attachment #1.3: check_fixes --]
[-- Type: application/x-shellscript, Size: 4197 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Saeed Mahameed]

On Tue, 2020-03-10 at 21:01 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   b63293e759a1 ("net/mlx5e: Show/set Rx network flow classification
> rules on ul rep")
>   6783e8b29f63 ("net/mlx5e: Init ethtool steering for representors")
>   01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS hash
> key on ul rep")
> 

Hi Stephen, 

checkpatch doesn't seem to catch such problems.. 

I count on our CI to do such checks for me, so instead of me writing a 
new script every time we hit a new unforeseen issue, i was wondering
where can i find the set of test/scripts you are running ? 

> are missing a Signed-off-by from their committer.
> 

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi all,

Commits

  b63293e759a1 ("net/mlx5e: Show/set Rx network flow classification rules on ul rep")
  6783e8b29f63 ("net/mlx5e: Init ethtool steering for representors")
  01013ad355d6 ("net/mlx5e: Show/set Rx flow indir table and RSS hash key on ul rep")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Daniel Borkmann]

On 11/25/19 8:28 AM, Stephen Rothwell wrote:
> Hi Dave,
> 
> Commits
> 
>    5940c5bf6504 ("selftests, bpftool: Skip the build test if not in tree")
>    31f8b8295bb8 ("selftests, bpftool: Set EXIT trap after usage function")
>    a89b2cbf71d6 ("tools, bpf: Fix build for 'make -s tools/bpf O=<dir>'")
>    a0f17cc6665c ("tools, bpftool: Fix warning on ignored return value for 'read'")
>    5d946c5abbaf ("xsk: Fix xsk_poll()'s return type")
> 
> are missing a Signed-off-by from their committers.
> 
> Presumably because the bpf-next tree has been rebased before asking you
> to merge it.  :-(

Yep, the tree has been rebased onto net-next in order to avoid an ugly merge
conflict. My maintainer SOB is still there fwiw, but I guess in this situation
would probably have been good add both of ours. Sorry for the trouble.

Thanks,
Daniel

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Hi Dave,

Commits

  5940c5bf6504 ("selftests, bpftool: Skip the build test if not in tree")
  31f8b8295bb8 ("selftests, bpftool: Set EXIT trap after usage function")
  a89b2cbf71d6 ("tools, bpf: Fix build for 'make -s tools/bpf O=<dir>'")
  a0f17cc6665c ("tools, bpftool: Fix warning on ignored return value for 'read'")
  5d946c5abbaf ("xsk: Fix xsk_poll()'s return type")

are missing a Signed-off-by from their committers.

Presumably because the bpf-next tree has been rebased before asking you
to merge it.  :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

Hi all,

On Fri, 16 Aug 2019 07:10:34 -0700 Gerd Rausch <gerd.rausch@oracle.com> wrote:
>
> On 16/08/2019 02.15, Andy Grover wrote:
> > On 8/16/19 3:06 PM, Gerd Rausch wrote:  
> >>
> >> Just added the e-mail addresses I found using a simple "google search",
> >> in order to reach out to the original authors of these commits:
> >> Chris Mason and Andy Grover.
> >>
> >> I'm hoping they still remember their work from 7-8 years ago.  
> > 
> > Yes looks like what I was working on. What did you need from me? It's
> > too late to amend the commitlogs...

Yeah, Dave doesn't rebase his trees.

> I'll let Stephen or David respond to what (if any) action is necessary.
> 
> The missing Signed-off-by was pointed out to me by Stephen yesterday.
> 
> Hence I tried to locate you guys to pull you into the loop in order to
> not leave his concern unanswered.

It is OK for SOBs to be missing, I just wanted to make sure that it was
OK in this instance.  (Its better that I ask when its OK then not to
ask and find something has gone wrong.)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Gerd Rausch]

Hi,

On 16/08/2019 02.15, Andy Grover wrote:
> On 8/16/19 3:06 PM, Gerd Rausch wrote:
>> Hi,
>>
>> Just added the e-mail addresses I found using a simple "google search",
>> in order to reach out to the original authors of these commits:
>> Chris Mason and Andy Grover.
>>
>> I'm hoping they still remember their work from 7-8 years ago.
> 
> Yes looks like what I was working on. What did you need from me? It's
> too late to amend the commitlogs...
> 

I'll let Stephen or David respond to what (if any) action is necessary.

The missing Signed-off-by was pointed out to me by Stephen yesterday.

Hence I tried to locate you guys to pull you into the loop in order to
not leave his concern unanswered.

Thanks,

  Gerd

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Chris Mason]

On 16 Aug 2019, at 5:15, Andy Grover wrote:

> On 8/16/19 3:06 PM, Gerd Rausch wrote:
>> Hi,
>>
>> Just added the e-mail addresses I found using a simple "google 
>> search",
>> in order to reach out to the original authors of these commits:
>> Chris Mason and Andy Grover.
>>
>> I'm hoping they still remember their work from 7-8 years ago.
>
> Yes looks like what I was working on. What did you need from me? It's
> too late to amend the commitlogs...

Same question ;)  The missing signed-off-by is a mistake, but from the 
point of view of the DCO, these patches are totally fine by me.

-chris

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Andy Grover]

On 8/16/19 3:06 PM, Gerd Rausch wrote:
> Hi,
> 
> Just added the e-mail addresses I found using a simple "google search",
> in order to reach out to the original authors of these commits:
> Chris Mason and Andy Grover.
> 
> I'm hoping they still remember their work from 7-8 years ago.

Yes looks like what I was working on. What did you need from me? It's
too late to amend the commitlogs...

-- Andy

> 
> Thanks,
> 
>   Gerd
> 
> On 15/08/2019 14.53, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commits
>>
>>   11740ef44829 ("rds: check for excessive looping in rds_send_xmit")
>>   65dedd7fe1f2 ("RDS: limit the number of times we loop in rds_send_xmit")
>>
>> are missing a Signed-off-by from their authors.
>>

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Gerd Rausch]

Hi,

Just added the e-mail addresses I found using a simple "google search",
in order to reach out to the original authors of these commits:
Chris Mason and Andy Grover.

I'm hoping they still remember their work from 7-8 years ago.

Thanks,

  Gerd

On 15/08/2019 14.53, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   11740ef44829 ("rds: check for excessive looping in rds_send_xmit")
>   65dedd7fe1f2 ("RDS: limit the number of times we loop in rds_send_xmit")
> 
> are missing a Signed-off-by from their authors.
> 

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi all,

Commits

  11740ef44829 ("rds: check for excessive looping in rds_send_xmit")
  65dedd7fe1f2 ("RDS: limit the number of times we loop in rds_send_xmit")

are missing a Signed-off-by from their authors.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Hi all,

Commits

  2a4c42980250 ("net/mlx5: Remove counter from idr after removing it from list")
  fd3307130344 ("net/mlx5: Take fs_counters dellist before addlist")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Hi Johan,

On Mon, 2 Apr 2018 08:38:03 +0300 Johan Hedberg <johan.hedberg@intel.com> wrote:
>
> On Mon, Apr 02, 2018, Stephen Rothwell wrote:
> >   45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4")
> >   f9b95db0165a ("Bluetooth: btrsi: remove unused including <linux/version.h>")
> >   96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME")
> >   9ea471320e13 ("Bluetooth: Mark expected switch fall-throughs")
> > 
> > are missing a Signed-off-by from their committer.  
> 
> I think this is because I fixed up a missing author name in "Bluetooth:
> hci_bcm: Remove DMI quirk for the MINIX Z83-4" and did a push --force,
> whereas these patches were originally committed by Marcel. Should I be
> adding my signed-off-by to all affected patches when doing such rebases?

Yep, Ideally we should have a Signed-off-by from everyone who involved
in getting the patches into the final tree.  That definitely means that
the final committer needs to add one.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the net-next tree

[Johan Hedberg]

Hi,

On Mon, Apr 02, 2018, Stephen Rothwell wrote:
>   45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4")
>   f9b95db0165a ("Bluetooth: btrsi: remove unused including <linux/version.h>")
>   96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME")
>   9ea471320e13 ("Bluetooth: Mark expected switch fall-throughs")
> 
> are missing a Signed-off-by from their committer.

I think this is because I fixed up a missing author name in "Bluetooth:
hci_bcm: Remove DMI quirk for the MINIX Z83-4" and did a push --force,
whereas these patches were originally committed by Marcel. Should I be
adding my signed-off-by to all affected patches when doing such rebases?

Johan

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi all,

Commits

  45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4")
  f9b95db0165a ("Bluetooth: btrsi: remove unused including <linux/version.h>")
  96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME")
  9ea471320e13 ("Bluetooth: Mark expected switch fall-throughs")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Hi all,

Commits

  568477045f80 (" phy: marvell10g: Utilize gen10g_no_soft_reset()")
  0adfdb667ab5 (" phy: cortina: Utilize generic functions")
  aebc78a40b88 (" phy: teranetics: Utilize generic functions")
  e8a714e086e4 (" phy: Export gen10g_* functions")
  6ed33d3a06e6 (" phy: aquantia: Utilize genphy_c45_aneg_done()")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commits in the net-next tree

[Stephen Rothwell]

Hi all,

Commits

  d8d8ccf27741 ("sfc: update EF10 register definitions")
  0bc959a95e8c ("sfc: populate the timer reload field")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell