linux-next: Fixes tag needs some work in the usb-gadget tree

linux-next: Fixes tag needs some work in the usb-gadget tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi all,

In commit

  6a6ae4e8e926 ("usb: gadget: f_ncm: Use atomic_t to track in-flight request")

Fixes tag

  Fixes: 40d133d7f5426 ("usb: gadget: f_ncm: convert to new function interface

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, please keep
all the commit message tags together at the end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the usb-gadget tree

[Bryan O'Donoghue]

On 15/01/2020 20:07, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    6a6ae4e8e926 ("usb: gadget: f_ncm: Use atomic_t to track in-flight request")
> 
> Fixes tag
> 
>    Fixes: 40d133d7f5426 ("usb: gadget: f_ncm: convert to new function interface

How should extra long fixes like this be divided up ?

Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function 
interface with backward compatibility")


Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function
                       interface with backward compatibility")

?

I don't see that for fixes like these.

Fixes: commit e9061c397839 ("nvmet: Remove the data_len field from the 
nvmet_req struct")


Fixes: 9e80635619b51 ("riscv: clear the instruction cache and all 
registers when booting")

---
bod

Re: linux-next: Fixes tag needs some work in the usb-gadget tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

Hi Bryan,

On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>
> How should extra long fixes like this be divided up ?

Just let them run on even if they are too long i.e. don't split them at all.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the usb-gadget tree

[Bryan O'Donoghue]

On 16/01/2020 01:41, Stephen Rothwell wrote:
> Hi Bryan,
> 
> On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>>
>> How should extra long fixes like this be divided up ?
> 
> Just let them run on even if they are too long i.e. don't split them at all.

That's what's in the git commit log though isn't it ?

Re: linux-next: Fixes tag needs some work in the usb-gadget tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Hi Bryan,

On Thu, 16 Jan 2020 01:45:25 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>
> On 16/01/2020 01:41, Stephen Rothwell wrote:
> > Hi Bryan,
> > 
> > On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:  
> >>
> >> How should extra long fixes like this be divided up ?  
> > 
> > Just let them run on even if they are too long i.e. don't split them at all.  
> 
> That's what's in the git commit log though isn't it ?

When you add a Fixes: tag to a commit, you quote the subject line of
the commit you are fixing which, by definition, is a single line.  We
want to keep it that way so it can be searched for easily.

So to create a fixes line you can use this:

git log -1 --format='Fixes: %h ("%s")' <commit being fixed>

i.e. in this case:

$ git log -1 --format='Fixes: %h (\"%s\")' 40d133d7f5426
Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function interface with backward compatibility")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the usb-gadget tree

[Bryan O'Donoghue]

On 16/01/2020 01:58, Stephen Rothwell wrote:
> Hi Bryan,
> 
> On Thu, 16 Jan 2020 01:45:25 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>>
>> On 16/01/2020 01:41, Stephen Rothwell wrote:
>>> Hi Bryan,
>>>
>>> On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>>>>
>>>> How should extra long fixes like this be divided up ?
>>>
>>> Just let them run on even if they are too long i.e. don't split them at all.
>>
>> That's what's in the git commit log though isn't it ?
> 
> When you add a Fixes: tag to a commit, you quote the subject line of
> the commit you are fixing which, by definition, is a single line.  We
> want to keep it that way so it can be searched for easily.
> 
> So to create a fixes line you can use this:
> 
> git log -1 --format='Fixes: %h ("%s")' <commit being fixed>
> 
> i.e. in this case:
> 
> $ git log -1 --format='Fixes: %h (\"%s\")' 40d133d7f5426
> Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function interface with backward compatibility")
> 

doh sorry still not seeing it

git remote -v
usb-next	git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
(fetch)

git fetch usb-next
git show 5b24c28cfe13

that's a correctly formatted fixes right i.e. the same one as above

:(

not seeing the difference...

---
bod

Re: linux-next: Fixes tag needs some work in the usb-gadget tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Hi Bryan,

On Thu, 16 Jan 2020 02:08:55 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>
> On 16/01/2020 01:58, Stephen Rothwell wrote:
> > 
> > On Thu, 16 Jan 2020 01:45:25 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:  
> >>
> >> On 16/01/2020 01:41, Stephen Rothwell wrote:  
> >>> Hi Bryan,
> >>>
> >>> On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:  
> >>>>
> >>>> How should extra long fixes like this be divided up ?  
> >>>
> >>> Just let them run on even if they are too long i.e. don't split them at all.  
> >>
> >> That's what's in the git commit log though isn't it ?  
> > 
> > When you add a Fixes: tag to a commit, you quote the subject line of
> > the commit you are fixing which, by definition, is a single line.  We
> > want to keep it that way so it can be searched for easily.
> > 
> > So to create a fixes line you can use this:
> > 
> > git log -1 --format='Fixes: %h ("%s")' <commit being fixed>
> > 
> > i.e. in this case:
> > 
> > $ git log -1 --format='Fixes: %h (\"%s\")' 40d133d7f5426
> > Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function interface with backward compatibility")
> >   
> 
> doh sorry still not seeing it
> 
> git remote -v
> usb-next	git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
> (fetch)
> 
> git fetch usb-next
> git show 5b24c28cfe13
> 
> that's a correctly formatted fixes right i.e. the same one as above
> 
> :(
> 
> not seeing the difference...

Now I see our confusion.  There is another version of this patch in
Felipe's tree as a different commit (6a6ae4e8e926) which has the Fixes
tag split ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the usb-gadget tree

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]


Hi

Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Bryan,
>
> On Thu, 16 Jan 2020 02:08:55 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>>
>> On 16/01/2020 01:58, Stephen Rothwell wrote:
>> > 
>> > On Thu, 16 Jan 2020 01:45:25 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:  
>> >>
>> >> On 16/01/2020 01:41, Stephen Rothwell wrote:  
>> >>> Hi Bryan,
>> >>>
>> >>> On Thu, 16 Jan 2020 01:19:22 +0000 Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:  
>> >>>>
>> >>>> How should extra long fixes like this be divided up ?  
>> >>>
>> >>> Just let them run on even if they are too long i.e. don't split them at all.  
>> >>
>> >> That's what's in the git commit log though isn't it ?  
>> > 
>> > When you add a Fixes: tag to a commit, you quote the subject line of
>> > the commit you are fixing which, by definition, is a single line.  We
>> > want to keep it that way so it can be searched for easily.
>> > 
>> > So to create a fixes line you can use this:
>> > 
>> > git log -1 --format='Fixes: %h ("%s")' <commit being fixed>
>> > 
>> > i.e. in this case:
>> > 
>> > $ git log -1 --format='Fixes: %h (\"%s\")' 40d133d7f5426
>> > Fixes: 40d133d7f542 ("usb: gadget: f_ncm: convert to new function interface with backward compatibility")
>> >   
>> 
>> doh sorry still not seeing it
>> 
>> git remote -v
>> usb-next	git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git 
>> (fetch)
>> 
>> git fetch usb-next
>> git show 5b24c28cfe13
>> 
>> that's a correctly formatted fixes right i.e. the same one as above
>> 
>> :(
>> 
>> not seeing the difference...
>
> Now I see our confusion.  There is another version of this patch in
> Felipe's tree as a different commit (6a6ae4e8e926) which has the Fixes
> tag split ...

Right, Greg applied my tree as patches to fix this problem. I need to
rebase my tree on Greg's to get rid of this problem.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

linux-next: Fixes tag needs some work in the usb-gadget tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hi all,

In commit

  238d76021654 ("usb: dwc3: meson-g12a: Don't use ret uninitialized in dwc3_meson_g12a_otg_init")

Fixes tag

  Fixes: 729149c53f04 ("usb: dwc3: Add Amlogic A1 DWC3 glue")

has these problem(s):

  - Target SHA1 does not exist

Perhaps you meant

Fixes: 1e355f21d3fb ("usb: dwc3: Add Amlogic A1 DWC3 glue")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the usb-gadget tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi Felipe,

In commit

  9f8dc24f7f5d ("usb: gadget: f_fs: don't free buffer prematurely")

Fixes tag

  Fixes: 772a7a724f6 ("usb: gadget: f_fs: Allow scatter-gather buffers")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]