linux-next: Fixes tag needs some work in the hid tree

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi all,

In commit

  5ebdffd25098 ("HID: core: fix off-by-one memset in hid_report_raw_event()")

Fixes tag

  Fixes: 966922f26c7f ("HID: fix a crash in hid_report_raw_event()

has these problem(s):

  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the hid tree

[Johan Korsnes (jkorsnes)]

On 2/12/20 9:49 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5ebdffd25098 ("HID: core: fix off-by-one memset in hid_report_raw_event()")
> 
> Fixes tag
> 
>   Fixes: 966922f26c7f ("HID: fix a crash in hid_report_raw_event()
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
>

Sorry about this. The checkpatch.pl script initially did complain
about the format of my commit references in v1:

"ERROR: Please use git commit description style"

But it only complained about number of characters in SHA, it did not
mention anything about line break. I will take care not to introduce
these line breaks in future commits, but it would be nice if
checkpatch.pl could check for this.

Johan

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Hi all,

In commit

  05c7d1de81eb ("HID: nintendo: Remove some unused functions")

Fixes tag

  Fixes: 94f18bb1994 ("HID: nintendo: add support for nso controllers")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

In commit

  82a3e2fb3e96 ("HID: logitech-hidpp: Hard-code HID++ 1.0 fast scroll support")

Fixes tag

  Fixes: 908d325 ("HID: logitech-hidpp: Detect hi-res scrolling support")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Hi all,

In commit

  609174edeb75 ("HID: uclogic: Fix warning in uclogic_rdesc_template_apply")

Fixes tag

  Fixes: 08177f4 ("HID: uclogic: merge hid-huion driver in hid-uclogic")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the hid tree

[José Expósito]

Hi,

On Fri, Aug 26, 2022 at 09:56:47AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   609174edeb75 ("HID: uclogic: Fix warning in uclogic_rdesc_template_apply")
> 
> Fixes tag
> 
>   Fixes: 08177f4 ("HID: uclogic: merge hid-huion driver in hid-uclogic")

Sorry about that, checkpatch didn't catch this one. This should read:

Fixes: 08177f40bd00 ("HID: uclogic: merge hid-huion driver in hid-uclogic")
 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  1117d182c5d7 ("HID: alps: Declare U1_UNICORN_LEGACY support")

Fixes tag

  Fixes: 640e403 ("HID: alps: Add AUI1657 device ID")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hi all,

In commit

  f97ec5d75e92 ("HID: intel-ish-hid: Use dma_alloc_coherent for firmware update")

Fixes tag

  Fixes: commit 91b228107da3 ("HID: intel-ish-hid: ISH firmware loader client driver")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Hi all,

In commit

  3e6a950d9836 ("HID: input: set usage type to key on keycode remap")

Fixes tag

  Fixes: bcfa8d1457 ("HID: input: Add support for Programmable Buttons")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Fixes tag

  Fixes: f5854fad39 ("Input: hid-input - allow mapping unknown usages")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the hid tree

[Thomas Weißschuh]

Hi Stephen,

On 2021-11-23 08:17+1100, Stephen Rothwell wrote:
> In commit
> 
>   3e6a950d9836 ("HID: input: set usage type to key on keycode remap")
> 
> Fixes tag
> 
>   Fixes: bcfa8d1457 ("HID: input: Add support for Programmable Buttons")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thanks for the pointer. I'll make sure to do this correctly in the future.
Maybe this should be part of checkpatch.pl?

> Fixes tag
> 
>   Fixes: f5854fad39 ("Input: hid-input - allow mapping unknown usages")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

Thomas

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  b45ef5db7bf2 ("HID: ft260: check data size in ft260_smbus_write()")

Fixes tag

  Fixes: 98189a0adfa0 ("HID: ft260: add usb hid to i2c host bridge driver")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi all,

In commit

  4b393f0f76c8 ("AMD_SFH: Fix for incorrect Sensor index")

Fixes tag

  Fixes: 4f567b9f8141 ("SFH: PCIe driver to add support of AMD sensor fusion hub 4f567b9f8141")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  dcce8ef8f70a ("HID: wacom: Report 2nd-gen Intuos Pro S center button status over BT")

Fixes tag

  Fixes: cd47de45b855 ("HID: wacom: Add 2nd gen Intuos Pro Small support")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 912c6aa67ad4 ("HID: wacom: Add 2nd gen Intuos Pro Small support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the hid tree

[Jason Gerecke]

My apologies. I copied the wrong commit SHA when generating this
commit. Commit cd47de45b855 is the reference to this commit in our
input-wacom tree, not upstream. The correct Fixes tag should indeed
be:

Fixes: 912c6aa67ad4 ("HID: wacom: Add 2nd gen Intuos Pro Small support")

Thanks,
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one  /
(That is to say, eight) to the two,     /
But you can’t take seven from three,    /
So you look at the sixty-fours....

On Wed, Apr 29, 2020 at 3:06 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   dcce8ef8f70a ("HID: wacom: Report 2nd-gen Intuos Pro S center button status over BT")
>
> Fixes tag
>
>   Fixes: cd47de45b855 ("HID: wacom: Add 2nd gen Intuos Pro Small support")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 912c6aa67ad4 ("HID: wacom: Add 2nd gen Intuos Pro Small support")
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

In commit

  ff479731c385 ("HID: wacom: generic: Treat serial number and related fields as unsigned")

Fixes tag

  Fixes: f85c9dc678 ("HID: wacom: generic: Support tool ID and additional tool types")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the hid tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

In commit

  b72fb1dcd2ea ("HID: wacom: Correct distance scale for 2nd-gen Intuos devices")

Fixes tag

  Fixes: eda01dab53 ("HID: wacom: Add four new Intuos devices")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]