linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	linux-bcache@vger.kernel.org,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: linux-next: Tree for Apr 19 (bcache)
Date: Tue, 20 Apr 2021 12:24:11 +0800	[thread overview]
Message-ID: <061cd630-2740-2da9-cfbe-fd18adb22fdc@suse.de> (raw)
In-Reply-To: <76e63e74-2237-f672-eb10-edde017bc76e@kernel.dk>

On 4/20/21 1:50 AM, Jens Axboe wrote:
> On 4/19/21 10:26 AM, Coly Li wrote:
>> On 4/19/21 11:40 PM, Randy Dunlap wrote:
>>> On 4/19/21 3:23 AM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20210416:
>>>>
>>>
>>> on x86_64:
>>>
>>> when
>>> # CONFIG_BLK_DEV is not set
>>>
>>>
>>> WARNING: unmet direct dependencies detected for LIBNVDIMM
>>>   Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
>>>   Selected by [y]:
>>>   - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]
>>>
>>>
>>> Full randconfig file is attached.
>>>
>>
>> I need hint from kbuild expert.
>>
>> My original idea to use "select LIBNVDIMM" is to avoid the
>> BCACHE_NVM_PAGES option to disappear if LIBNVDIMM is not enabled.
>> Otherwise if nvdimm driver is not configure, users won't know there is a
>> BCACHE_NVM_PAGES option unless they read bcache Kconfig file.
> 
> But why? That's exactly how it should work. Just use depends to set the
> dependency.
> 
>> But I see nvdimm's Kconfig, it uses "depends on BLK_DEV", I understand
>> it is acceptable that LIBNVDIMM option to disappear from "make
>> menuconfig" if BLK_DEV is not enabled.
>>
>> For such condition, which one is the proper way to set the dependence ?
>> - Change "select LIBNVDIMM" and "select DAX" to "depends on LIBNVDIMM"
>> and "depends on DAX" in bcache Kconfig
>> - Or change "depends on BLK_DEV" to "select BLK_DEV" in nvdimm Kconfig.
> 
> The former.
> 

Copied. Thanks for the hint. I will post a fix soon.

Coly Li

      reply	other threads:[~2021-04-20  4:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 10:23 linux-next: Tree for Apr 19 Stephen Rothwell
2021-04-19 15:40 ` linux-next: Tree for Apr 19 (bcache) Randy Dunlap
2021-04-19 16:26   ` Coly Li
2021-04-19 17:50     ` Jens Axboe
2021-04-20  4:24       ` Coly Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=061cd630-2740-2da9-cfbe-fd18adb22fdc@suse.de \
    --to=colyli@suse.de \
    --cc=axboe@kernel.dk \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).