Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Vinod Koul <vinod.koul@intel.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Subject: Re: linux-next: build warning after merge of the slave-dma tree
Date: Mon, 30 Mar 2015 11:56:08 +0530
Message-ID: <0d71a355-1f27-4f9f-ad87-01a68aeaaca3@BL2FFO11OLC014.protection.gbl> (raw)
In-Reply-To: <20150330172053.63896266@canb.auug.org.au>

Hi Stephen Rothwell,

I will fix this and will send a patch.

Regards,
Kedar.

On 3/30/2015 11:50 AM, Stephen Rothwell wrote:
> Hi Vinod,
>
> After merging the slave-dma tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0:
> include/linux/dmapool.h:18:4: warning: 'struct device' declared inside parameter list
>      size_t size, size_t align, size_t allocation);
>      ^
> include/linux/dmapool.h:18:4: warning: its scope is only this definition or declaration, which is probably not what you want
> include/linux/dmapool.h:31:7: warning: 'struct device' declared inside parameter list
>         size_t size, size_t align, size_t allocation);
>         ^
> drivers/dma/xilinx/xilinx_vdma.c: In function 'xilinx_vdma_alloc_chan_resources':
> drivers/dma/xilinx/xilinx_vdma.c:501:20: warning: passing argument 2 of 'dma_pool_create' from incompatible pointer type
>    chan->desc_pool = dma_pool_create("xilinx_vdma_desc_pool",
>                      ^
> In file included from drivers/dma/xilinx/xilinx_vdma.c:26:0:
> include/linux/dmapool.h:17:18: note: expected 'struct device *' but argument is of type 'struct device *'
>   struct dma_pool *dma_pool_create(const char *name, struct device *dev,
>                    ^
>
> Presumable caused by the include order change in commit 937abe88aea3
> ("dmaengine: xilinx-dma: move header file to common location").
>
> I guess that dmapool.h needs a "struct device;" line near the top.
>



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30  6:20 Stephen Rothwell
2015-03-30  6:26 ` Appana Durga Kedareswara Rao [this message]
2016-06-09  1:18 Stephen Rothwell
2016-06-09  6:04 ` Appana Durga Kedareswara Rao
2018-07-04  3:30 Stephen Rothwell
2018-07-04  4:20 ` Vinod
2018-07-05  2:47   ` Stephen Rothwell
2018-07-05  5:01     ` Vinod
2018-09-13  2:22 Stephen Rothwell
2018-09-13  7:17 ` Angelo Dureghello
2018-11-26  5:59 Stephen Rothwell
2018-11-26  8:09 ` Vinod Koul
2019-08-12  7:14 Stephen Rothwell
2019-08-12  9:14 ` Arnd Bergmann
2019-08-12  9:21   ` Stephen Rothwell
2020-02-14  0:00 Stephen Rothwell
2020-02-14  4:41 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d71a355-1f27-4f9f-ad87-01a68aeaaca3@BL2FFO11OLC014.protection.gbl \
    --to=appana.durga.rao@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git