From: Matthias Brugger <matthias.bgg@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the mediatek tree
Date: Tue, 26 Apr 2022 10:55:03 +0200 [thread overview]
Message-ID: <0e84ae3d-318c-f88e-bca4-3ae947c3e734@gmail.com> (raw)
In-Reply-To: <55c9dd79-2703-b7f5-f593-3324d09085e5@kernel.org>
On 26/04/2022 10:52, Krzysztof Kozlowski wrote:
> On 26/04/2022 10:48, Matthias Brugger wrote:
>> Hi Stephen,
>>
>> On 26/04/2022 00:07, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>> 775ef8aaa66e ("arm64: dts: mediatek: align thermal zone node names with dtschema")
>>> c8b8db1a173d ("arm64: dts: mediatek: align operating-points table name with dtschema")
>>> c01d9aa630b8 ("arm64: dts: mediatek: mt8183: align Google CROS EC PWM node name with dtschema")
>>> 75a3c81bc634 ("arm64: dts: hisilicon: align 'freq-table-hz' with dtschema in UFS")
>>>
>>> are missing a Signed-off-by from their committer.
>>>
>>
>> These patches are taken by Krysztof and merge into my tree via a tag [1] to
>> avoid any conflicts. Please let me know if there is anything I need to do to fix
>> this problem.
>
> Hi Matthias,
>
> Before you merged my branch, which was fine, but later you rebased all
> this thus making yourself committer. Commits pulled from other trees
> should in general not be rebased, because it creates duplicates - there
> are ones in my tree, and separate in yours.
>
> Additionally, such rebase changes the author, so you need your SoB.
>
Ok thanks for the explanation.
> Since you already rebased it, I propose you add your own SoB to Mediatek
> patches and drop the one hisilicon (75a3c81bc634). I will do the reverse
> - drop Mediatek and keep hisilicon.
>
Ok, I think this is the easiest solution. Sorry for the inconvenience I created.
Regards,
Matthias
next prev parent reply other threads:[~2022-04-26 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 22:07 linux-next: Signed-off-by missing for commit in the mediatek tree Stephen Rothwell
2022-04-26 8:48 ` Matthias Brugger
2022-04-26 8:52 ` Krzysztof Kozlowski
2022-04-26 8:53 ` Krzysztof Kozlowski
2022-04-26 8:55 ` Matthias Brugger [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-13 21:57 Stephen Rothwell
2018-05-14 10:47 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e84ae3d-318c-f88e-bca4-3ae947c3e734@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).