linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org
Subject: Re: linux-next: firmware build failure
Date: Fri, 06 Jun 2008 10:31:05 +0100	[thread overview]
Message-ID: <1212744665.32207.304.camel@pmac.infradead.org> (raw)
In-Reply-To: <20080606174723.05ae4f28.sfr@canb.auug.org.au>

On Fri, 2008-06-06 at 17:47 +1000, Stephen Rothwell wrote:
> Hi David,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
>   IHEX2FW firmware/atmsar11.fw
> Bad EOF record (type 01) format
> make[2]: *** [firmware/atmsar11.fw] Error 1

Bah. The actual fix is something like this, which I forgot to commit.
Sorry again -- it's there now (with some more minor cleanups).

--- a/firmware/ihex2fw.c
+++ b/firmware/ihex2fw.c
@@ -146,7 +146,6 @@ next_record:
 
        record->addr  = hex(data + i, &crc) << 8; i += 2;
        record->addr |= hex(data + i, &crc); i += 2;
-       record->addr += offset;
        type = hex(data + i, &crc); i += 2;
 
        for (j = 0; j < record->len; j++, i += 2)
@@ -166,12 +165,13 @@ next_record:
                if (!record->len)
                        break;
 
+               record->addr += offset;
                file_record(record);
                goto next_record;
 
        case 1: /* End-Of-File Record */
                if (record->addr || record->len) {
                        fprintf(stderr, "Bad EOF record (type 01) format\n");


> 
-- 
dwmw2


  parent reply	other threads:[~2008-06-06  9:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06  7:47 linux-next: firmware build failure Stephen Rothwell
2008-06-06  9:09 ` David Woodhouse
2008-06-06  9:31 ` David Woodhouse [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-12  6:28 Stephen Rothwell
2008-06-12  8:54 ` David Woodhouse
2008-06-04  6:46 Stephen Rothwell
2008-06-04  9:22 ` David Woodhouse
2008-06-04 10:40   ` Stephen Rothwell
2008-06-04  9:53 ` David Woodhouse
2008-06-04 10:47   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212744665.32207.304.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).