From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew@wil.cx>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] lockd: fix FILE_LOCKING=n build error
Date: Tue, 28 Apr 2009 14:15:54 -0400 [thread overview]
Message-ID: <1240942554.7376.38.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <49F7421A.1090709@oracle.com>
On Tue, 2009-04-28 at 10:51 -0700, Randy Dunlap wrote:
> J. Bruce Fields wrote:
> > On Tue, Apr 28, 2009 at 08:22:50AM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> lockd/svclock.c is missing a header file <linux/fs.h>.
> >>
> >> <linux/fs.h> is missing a definition of locks_release_private()
> >> for the config case of FILE_LOCKING=n, causing a build error:
> >>
> >> fs/lockd/svclock.c:330: error: implicit declaration of function 'locks_release_private'
> >
> > LOCKD without FILE_LOCKING doesn't really make sense; would it be better
> > to add a config dependency?
>
>
> I just tried a patch like the one below instead of the first one,
> but it has build errors too, so more Makefile/Kconfig work is
> needed (by someone who knows what interfaces are needed here):
>
>
> fs/built-in.o: In function `nfs_start_lockd':
> client.c:(.text+0xe8848): undefined reference to `nlmclnt_init'
> fs/built-in.o: In function `nfs_destroy_server':
> client.c:(.text+0xe8885): undefined reference to `nlmclnt_done'
> fs/built-in.o: In function `nfs_proc_lock':
> proc.c:(.text+0xf735f): undefined reference to `nlmclnt_proc'
> fs/built-in.o: In function `nfs3_proc_lock':
> nfs3proc.c:(.text+0xfd1df): undefined reference to `nlmclnt_proc'
>
>
>
>
> lockd without FILE_LOCKING doesn't make sense, so make LOCKD and
> LOCKD_V4 depend on FILE_LOCKING.
> ---
> fs/Kconfig | 2 ++
> fs/nfs/Kconfig | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-next-20090428.orig/fs/Kconfig
> +++ linux-next-20090428/fs/Kconfig
> @@ -226,10 +226,12 @@ source "fs/nfsd/Kconfig"
>
> config LOCKD
> tristate
> + depends on FILE_LOCKING
>
> config LOCKD_V4
> bool
> depends on NFSD_V3 || NFS_V3
> + depends on FILE_LOCKING
> default y
>
> config EXPORTFS
> --- linux-next-20090428.orig/fs/nfs/Kconfig
> +++ linux-next-20090428/fs/nfs/Kconfig
> @@ -1,7 +1,7 @@
> config NFS_FS
> tristate "NFS client support"
> depends on INET
> - select LOCKD
> + select LOCKD if FILE_LOCKING
> select SUNRPC
> select NFS_ACL_SUPPORT if NFS_V3_ACL
> help
Until someone finds time to go through the code and add in all the
CONFIG_FILE_LOCKING special cases, the above needs to be a 'depends on
INET && FILE_LOCKING'.
Trond
next prev parent reply other threads:[~2009-04-28 18:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 6:53 linux-next: Tree for April 28 Stephen Rothwell
2009-04-28 11:10 ` Next April 28: boot failure on PowerPC with SLQB Sachin Sant
2009-04-28 11:22 ` Pekka Enberg
2009-04-29 7:04 ` Nick Piggin
2009-04-29 11:36 ` Nick Piggin
2009-04-29 16:26 ` Sachin Sant
2009-04-30 3:21 ` Stephen Rothwell
2009-04-30 4:11 ` Nick Piggin
2009-04-30 5:36 ` Sachin Sant
2009-04-30 6:03 ` Nick Piggin
2009-04-30 6:42 ` Sachin Sant
2009-04-30 6:41 ` Nick Piggin
2009-04-30 9:47 ` Sachin Sant
2009-04-30 10:35 ` Nick Piggin
2009-04-30 10:38 ` Pekka Enberg
2009-04-30 11:00 ` Stephen Rothwell
2009-04-30 11:10 ` Pekka Enberg
2009-04-30 11:18 ` Nick Piggin
2009-04-30 11:20 ` Pekka Enberg
2009-04-30 11:26 ` Nick Piggin
2009-04-30 13:05 ` Nick Piggin
2009-04-30 14:00 ` Stephen Rothwell
2009-04-30 14:10 ` Nick Piggin
2009-05-03 11:51 ` Pekka Enberg
2009-04-30 14:10 ` Anton Vorontsov
2009-05-03 11:51 ` Pekka Enberg
2009-04-28 15:22 ` [PATCH] lockd: fix FILE_LOCKING=n build error Randy Dunlap
2009-04-28 15:38 ` Felix Blyakher
2009-04-28 17:21 ` J. Bruce Fields
2009-04-28 17:51 ` Randy Dunlap
2009-04-28 18:15 ` Trond Myklebust [this message]
2009-04-28 21:01 ` [PATCH v2] " Randy Dunlap
2009-04-28 21:40 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240942554.7376.38.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).