[PATCH 1/2] Staging: comedi: comedi_test.c should include timer.h

[PATCH 1/2] Staging: comedi: comedi_test.c should include timer.h

[Alexander Beregalov]

Fix this build error:
.../comedi_test.c:82: error: field timer has incomplete type
.../comedi_test.c: In function waveform_ai_interrupt:
.../comedi_test.c:188: error: implicit declaration of function mod_timer
.../comedi_test.c:188: error: jiffies undeclared (first use in this function)

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
 drivers/staging/comedi/drivers/comedi_test.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c
index 93ed1a0..9b8cf62 100644
--- a/drivers/staging/comedi/drivers/comedi_test.c
+++ b/drivers/staging/comedi/drivers/comedi_test.c
@@ -55,6 +55,7 @@ zero volts).
 #include <asm/div64.h>
 
 #include "comedi_fc.h"
+#include <linux/timer.h>
 
 /* Board descriptions */
 struct waveform_board {
-- 
1.6.3

[PATCH 2/2] Staging: comedi: data.c should include delay.h

[Alexander Beregalov]

Fix this build error:
.../data.c:86: error: implicit declaration of function 'udelay'

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
 drivers/staging/comedi/kcomedilib/data.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/comedi/kcomedilib/data.c b/drivers/staging/comedi/kcomedilib/data.c
index 3e5fe2c..c26df4e 100644
--- a/drivers/staging/comedi/kcomedilib/data.c
+++ b/drivers/staging/comedi/kcomedilib/data.c
@@ -26,6 +26,7 @@
 #include "../comedidev.h"
 
 #include <linux/string.h>
+#include <asm/delay.h>
 
 int comedi_data_write(void *dev, unsigned int subdev, unsigned int chan,
 	unsigned int range, unsigned int aref, unsigned int data)
-- 
1.6.3

Re: [PATCH 2/2] Staging: comedi: data.c should include delay.h

[Alexander Beregalov]

Fix this build error:
.../data.c:86: error: implicit declaration of function 'udelay'

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---

This one is better.

 drivers/staging/comedi/kcomedilib/data.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/comedi/kcomedilib/data.c b/drivers/staging/comedi/kcomedilib/data.c
index 3e5fe2c..d808556 100644
--- a/drivers/staging/comedi/kcomedilib/data.c
+++ b/drivers/staging/comedi/kcomedilib/data.c
@@ -26,6 +26,7 @@
 #include "../comedidev.h"
 
 #include <linux/string.h>
+#include <linux/delay.h>
 
 int comedi_data_write(void *dev, unsigned int subdev, unsigned int chan,
 	unsigned int range, unsigned int aref, unsigned int data)

Re: [PATCH 2/2] Staging: comedi: data.c should include delay.h

[Alexander Beregalov]

2009/5/13 Alexander Beregalov <a.beregalov@gmail.com>:
> Fix this build error:
> .../data.c:86: error: implicit declaration of function 'udelay'
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---

Greg,
Please apply instead my another patch, which includes delay.h in comedidev.h.

Re: [PATCH 2/2] Staging: comedi: data.c should include delay.h

[Greg KH]

On Thu, May 21, 2009 at 05:08:28PM +0400, Alexander Beregalov wrote:
> 2009/5/13 Alexander Beregalov <a.beregalov@gmail.com>:
> > Fix this build error:
> > .../data.c:86: error: implicit declaration of function 'udelay'
> >
> > Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> > ---
> 
> Greg,
> Please apply instead my another patch, which includes delay.h in comedidev.h.

Ok, will do.

thanks,

greg k-h