From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
Cc: ppc-dev <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jan Beulich <JBeulich-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: linux-next: tree build failure
Date: Mon, 28 Sep 2009 17:00:09 -0700 [thread overview]
Message-ID: <1254182409.15622.154.camel@slab.beaverton.ibm.com> (raw)
In-Reply-To: <20090924152102.8d7d40cf.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
On Thu, 2009-09-24 at 15:21 +1000, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
>
> In file included from arch/powerpc/kvm/booke.c:31:
> arch/powerpc/kvm/timing.h: In function 'kvmppc_account_exit_stat':
> arch/powerpc/kvm/timing.h:51: error: bit-field '<anonymous>' width not an integer constant
> In file included from arch/powerpc/kvm/booke.h:26,
> from arch/powerpc/kvm/booke_emulate.c:23:
> arch/powerpc/kvm/timing.h: In function 'kvmppc_account_exit_stat':
> arch/powerpc/kvm/timing.h:51: error: bit-field '<anonymous>' width not an integer constant
>
> Presumably caused by commit 8c87df457cb58fe75b9b893007917cf8095660a0
> ("BUILD_BUG_ON(): fix it and a couple of bogus uses of it").
First, I think there is a real bug here, and the code should read like
this (to match the comment):
/* type has to be known at build time for optimization */
- BUILD_BUG_ON(__builtin_constant_p(type));
+ BUILD_BUG_ON(!__builtin_constant_p(type));
However, I get the same build error *both* ways, i.e.
__builtin_constant_p(type) evaluates to both 0 and 1? Either that, or
the new BUILD_BUG_ON() macro isn't working...
> I applied the following patch for today. This inline function is
> only called from one place in one file ...
It's also called via kvmppc_account_exit() from a number of places.
--
Hollis Blanchard
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-29 0:00 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 5:21 linux-next: tree build failure Stephen Rothwell
[not found] ` <20090924152102.8d7d40cf.sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2009-09-29 0:00 ` Hollis Blanchard [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-16 7:21 Stephen Rothwell
2009-12-16 9:02 ` Felipe Balbi
2009-12-16 10:10 ` Liam Girdwood
2009-10-01 3:19 Stephen Rothwell
2009-10-01 7:58 ` Jens Axboe
2009-10-01 10:41 ` Stephen Rothwell
2009-09-29 9:28 Jan Beulich
[not found] ` <4AC1E15502000078000516B5-Qfbpwmsw6RoS3W1tAdPHOtBPR1lH4CV8@public.gmane.org>
2009-09-29 9:51 ` roel kluin
[not found] ` <25e057c00909290251h55c0dc25o4ab1f2e84c920dca-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-30 6:29 ` Jan Beulich
2009-09-29 23:39 ` Hollis Blanchard
[not found] ` <1254267572.15622.1621.camel-yDUrRDS8jBVhsM67afOH+sxtgHpCUUYS@public.gmane.org>
2009-09-30 6:35 ` Jan Beulich
[not found] ` <4AC318450200007800017355-Qfbpwmsw6RoS3W1tAdPHOtBPR1lH4CV8@public.gmane.org>
2009-10-02 15:48 ` Hollis Blanchard
2009-10-05 6:58 ` Jan Beulich
2009-10-09 19:14 ` Hollis Blanchard
2009-10-14 22:57 ` Hollis Blanchard
2009-10-15 7:27 ` Jan Beulich
2009-10-19 18:19 ` Hollis Blanchard
2009-10-20 1:12 ` Rusty Russell
[not found] ` <200910201142.34006.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2009-10-20 1:29 ` Hollis Blanchard
2009-08-17 8:39 Stephen Rothwell
2009-08-03 0:35 Stephen Rothwell
2009-08-03 1:01 ` NeilBrown
2009-08-03 1:30 ` Stephen Rothwell
2009-07-27 7:53 Stephen Rothwell
2009-07-27 9:21 ` Karsten Keil
2009-07-27 15:06 ` David Miller
2009-07-28 4:22 ` Stephen Rothwell
2009-04-07 3:41 Stephen Rothwell
2009-04-07 10:00 ` Mark Brown
2009-04-08 1:48 ` Takashi Iwai
2009-03-23 9:38 Stephen Rothwell
2009-03-23 22:27 ` Mauro Carvalho Chehab
2009-03-23 23:25 ` Stephen Rothwell
2009-03-05 7:41 Stephen Rothwell
2009-03-06 5:01 ` Rusty Russell
2009-01-16 5:37 Stephen Rothwell
2009-01-16 7:25 ` Peter Zijlstra
2009-01-16 9:03 ` Ingo Molnar
2009-01-16 10:39 ` Stephen Rothwell
2009-01-16 10:53 ` Ingo Molnar
2009-01-16 11:53 ` Stephen Rothwell
2009-01-16 12:32 ` Ingo Molnar
2008-11-28 10:04 Stephen Rothwell
2008-11-28 10:25 ` Takashi Iwai
2008-11-28 10:43 ` Stephen Rothwell
2008-11-28 17:23 ` Takashi Iwai
2008-10-21 8:30 Stephen Rothwell
2008-08-25 10:33 Stephen Rothwell
2008-08-25 16:36 ` Steven Rostedt
2008-06-30 14:35 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254182409.15622.154.camel@slab.beaverton.ibm.com \
--to=hollisb-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=JBeulich-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).