From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Walls Subject: Re: linux-next: v4l-dvb tree build failure Date: Wed, 27 Jan 2010 18:24:48 -0500 Message-ID: <1264634688.3088.1.camel@palomino.walls.org> References: <20100127175917.5d690f52.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mail1.radix.net ([207.192.128.31]:48120 "EHLO mail1.radix.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755437Ab0A0X0U (ORCPT ); Wed, 27 Jan 2010 18:26:20 -0500 In-Reply-To: <20100127175917.5d690f52.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Mauro Carvalho Chehab , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Devin Heitmueller On Wed, 2010-01-27 at 17:59 +1100, Stephen Rothwell wrote: > Hi Mauro, > > Today's linux-next build (powerpc allyesconfig) failed like this: > > drivers/media/video/cx18/cx18-alsa-pcm.c: In function 'snd_pcm_alloc_vmalloc_buffer': > drivers/media/video/cx18/cx18-alsa-pcm.c:234: error: implicit declaration of function 'vfree' > drivers/media/video/cx18/cx18-alsa-pcm.c:236: error: implicit declaration of function 'vmalloc' > > Caused by commit 5e9a302853301e0a2bb6671036daac3366fd85f4 ("V4L/DVB: cx18: overhaul ALSA PCM device handling so it works"). > > I applied the following patch for today. > > From: Stephen Rothwell > Date: Wed, 27 Jan 2010 17:53:39 +1100 > Subject: [PATCH] V4L/DVB: using vmalloc requires include of linux/vmalloc.h > > Signed-off-by: Stephen Rothwell Stephen, Looks good to me. Acked-by: Andy Walls Regards, Andy > --- > drivers/media/video/cx18/cx18-alsa-pcm.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/video/cx18/cx18-alsa-pcm.c b/drivers/media/video/cx18/cx18-alsa-pcm.c > index 6e56df9..b9f42b1 100644 > --- a/drivers/media/video/cx18/cx18-alsa-pcm.c > +++ b/drivers/media/video/cx18/cx18-alsa-pcm.c > @@ -25,6 +25,7 @@ > > #include > #include > +#include > > #include > > -- > 1.6.6 >