Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the scsi tree
@ 2010-02-10  5:51 Stephen Rothwell
  2010-02-10 22:13 ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2010-02-10  5:51 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Giridhar Malavali, Sarang Radke

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Hi all,

After merging the percpu tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

drivers/scsi/qla2xxx/qla_attr.c: In function 'qla2x00_process_vendor_specific':
drivers/scsi/qla2xxx/qla_attr.c:2150: warning: 'req_data' may be used uninitialized in this function
drivers/scsi/qla2xxx/qla_attr.c:2152: warning: 'req_data_len' may be used uninitialized in this function

If the first "goto done_unmap_sg;" in this function is followed, the
req_data will be tested even though it has not been assigned to yet and
if it is non zero, it and req_data_len will be passed to
dma_free_coherent() while still uninitialised.

Introduced by commit 9a069e196767d7b87184fd8d8211d22bb5b9c0b8 ("[SCSI]
qla2xxx: Add BSG support for FC ELS/CT passthrough and vendor commands").

The compiler also produces these:

drivers/scsi/qla2xxx/qla_attr.c:2144: warning: 'command_sent' may be used uninitialized in this function
drivers/scsi/qla2xxx/qla_attr.c:2146: warning: 'type' may be used uninitialized in this function

but I can't easily tell if they are false positives.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2010-08-04  3:13 Stephen Rothwell
  2010-08-04  4:17 ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2010-08-04  3:13 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Alan Stern

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/scsi_sysfs.c:384: warning: dereferencing 'void *' pointer

Introduced by commit db5bd1e0b505c54ff492172ce4abc245cf6cd639 ("[SCSI]
convert to the new PM framework").  This build does not have
CONFIG_PM_OPS set.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
[parent not found: <20110518114912.dfdf8835.sfr@canb.auug.org.au>]
* linux-next: build warning after merge of the scsi tree
@ 2011-07-20  4:08 Stephen Rothwell
  0 siblings, 0 replies; 46+ messages in thread
From: Stephen Rothwell @ 2011-07-20  4:08 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Kashyap, Desai

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/mpt2sas/mpt2sas_scsih.c: In function '_scsih_sas_broadcast_primative_event':
drivers/scsi/mpt2sas/mpt2sas_scsih.c:5591:40: warning: unused variable 'event_data'

Probably introduced by commit f93213de5c28 ("[SCSI] mpt2sas: fix
broadcast AEN and task management issue").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2013-09-02  8:28 Stephen Rothwell
  2013-09-04  9:18 ` Sujit Reddy Thumma
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2013-09-02  8:28 UTC (permalink / raw)
  To: James Bottomley
  Cc: linux-next, linux-kernel, Sujit Reddy Thumma, Santosh Y, Tejun Heo

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated (declared at /scratch/sfr/next/include/linux/workqueue.h:624) [-Wdeprecated-declarations]
   flush_work_sync(&hba->eh_work);
   ^

Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
methods").  flush_work_sync was deprecated by commit 43829731dd37
("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2014-11-18  8:21 Stephen Rothwell
  2014-11-20  8:23 ` Christoph Hellwig
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2014-11-18  8:21 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-next, linux-kernel, Christoph Hellwig

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' [-Wunused-variable]
  u8 tag[2];
     ^

Introduced by commit 5066863337af ("scsi: remove abuses of
scsi_populate_tag").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2016-09-13  4:15 Stephen Rothwell
  2016-09-13 14:09 ` Bryant G. Ly
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2016-09-13  4:15 UTC (permalink / raw)
  To: James Bottomley
  Cc: linux-next, linux-kernel, Bryant G. Ly, Martin K. Petersen, Michael Cyr

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 'srp' [-Wunused-variable]
    struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
                    ^

Introduced by commit

  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2016-11-22  7:44 Stephen Rothwell
  2016-11-22 22:24 ` Martin K. Petersen
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2016-11-22  7:44 UTC (permalink / raw)
  To: James Bottomley
  Cc: linux-next, linux-kernel, Hannes Reinecke, Martin K. Petersen

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (!sd)
     ^

Introduced by commit

  4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2017-04-06  4:04 Stephen Rothwell
  2017-04-06  8:18 ` Fam Zheng
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2017-04-06  4:04 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Fam Zheng

Hi James,

After merging the scsi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/list.h:8:0,
                 from include/linux/module.h:9,
                 from drivers/scsi/sd.c:35:
drivers/scsi/sd.c: In function 'sd_revalidate_disk':
include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast
  (void) (&min1 == &min2);   \
                ^
include/linux/kernel.h:758:2: note: in expansion of macro '__min'
  __min(typeof(x), typeof(y),   \
  ^
include/linux/kernel.h:783:39: note: in expansion of macro 'min'
  __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
                                       ^
drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
   rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
            ^

Introduced by commit

  c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable")

logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
blk_default_limits" (i.e. int).

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2018-04-17  2:25 Stephen Rothwell
  2018-04-18 21:52 ` Long Li
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2018-04-17  2:25 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Long Li,
	Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is larger than 2048 bytes [-Wframe-larger-than=]
 }
 ^

Introduced by commit

  0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of ring buffer to write")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
[parent not found: <20180620132911.5f6ab464@canb.auug.org.au>]
* linux-next: build warning after merge of the scsi tree
@ 2018-10-19  4:50 Stephen Rothwell
  2018-10-19  4:54 ` James Bottomley
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2018-10-19  4:50 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_open':
drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be used uninitialized in this function [-Wmaybe-uninitialized]
   switch (nrport->port_state) {
           ~~~~~~^~~~~~~~~~~~
drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared here
  struct nvme_fc_remote_port *nrport;
                              ^~~~~~

I am not sure where this has come from :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2019-04-05  3:25 Stephen Rothwell
  2019-04-05  4:30 ` Bart Van Assche
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2019-04-05  3:25 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Bart Van Assche, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-function]
 lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
 ^~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  3999df75bccb ("scsi: lpfc: Declare local functions static")

It use is guarded by IS_ENABLED(CONFIG_NVME_FC).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2019-05-31  3:36 Stephen Rothwell
  2019-06-03 20:29 ` Tyrel Datwyler
  2019-06-03 23:37 ` Tyrel Datwyler
  0 siblings, 2 replies; 46+ messages in thread
From: Stephen Rothwell @ 2019-05-31  3:36 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Tyrel Datwyler, Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (rc) {
     ^
drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
  int rc;
      ^~

Introduced by commit

  035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2019-06-20  6:10 Stephen Rothwell
  0 siblings, 0 replies; 46+ messages in thread
From: Stephen Rothwell @ 2019-06-20  6:10 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Ming Lei,
	Martin K. Petersen

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/pci-dma-compat.h:8,
                 from include/linux/pci.h:2408,
                 from drivers/scsi/mvumi.c:13:
drivers/scsi/mvumi.c: In function 'mvumi_queue_command':
include/linux/dma-mapping.h:608:34: warning: 'sg' may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define dma_unmap_sg(d, s, n, r) dma_unmap_sg_attrs(d, s, n, r, 0)
                                  ^~~~~~~~~~~~~~~~~~
drivers/scsi/mvumi.c:192:22: note: 'sg' was declared here
  struct scatterlist *sg;
                      ^~

Introduced by commit

  350d66a72adc ("scsi: mvumi: use sg helper to iterate over scatterlist")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread
* linux-next: build warning after merge of the scsi tree
@ 2019-11-07  4:01 Stephen Rothwell
  2019-11-07 15:51 ` Bart Van Assche
  0 siblings, 1 reply; 46+ messages in thread
From: Stephen Rothwell @ 2019-11-07  4:01 UTC (permalink / raw)
  To: James Bottomley
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, James Smart,
	Martin K. Petersen, Dick Kennedy

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
 6020 |  if (!cpumask_of_node(numa_node))
      |      ^

Introduced by commit

  dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 46+ messages in thread

end of thread, back to index

Thread overview: 46+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-10  5:51 linux-next: build warning after merge of the scsi tree Stephen Rothwell
2010-02-10 22:13 ` James Bottomley
2010-08-04  3:13 Stephen Rothwell
2010-08-04  4:17 ` James Bottomley
     [not found] <20110518114912.dfdf8835.sfr@canb.auug.org.au>
2011-05-18  2:06 ` Nicholas A. Bellinger
2011-05-18  3:58   ` Stephen Rothwell
2011-05-19  2:54     ` Nicholas A. Bellinger
2011-05-19 16:18       ` Kiran Patil
2011-05-19 16:22     ` Geert Uytterhoeven
2011-06-23 17:02       ` Randy Dunlap
2011-07-20  4:08 Stephen Rothwell
2013-09-02  8:28 Stephen Rothwell
2013-09-04  9:18 ` Sujit Reddy Thumma
2013-09-04  9:54   ` Sujit Reddy Thumma
2014-11-18  8:21 Stephen Rothwell
2014-11-20  8:23 ` Christoph Hellwig
2016-09-13  4:15 Stephen Rothwell
2016-09-13 14:09 ` Bryant G. Ly
2016-09-15 13:55   ` Martin K. Petersen
2016-11-22  7:44 Stephen Rothwell
2016-11-22 22:24 ` Martin K. Petersen
2017-04-06  4:04 Stephen Rothwell
2017-04-06  8:18 ` Fam Zheng
2018-04-17  2:25 Stephen Rothwell
2018-04-18 21:52 ` Long Li
2018-04-18 23:30   ` Martin K. Petersen
     [not found] <20180620132911.5f6ab464@canb.auug.org.au>
2018-07-10  7:31 ` Stephen Rothwell
2018-07-10 14:09   ` Jens Axboe
2018-07-10 14:14     ` James Bottomley
2018-07-10 14:22       ` Jens Axboe
2018-07-10 14:26         ` James Bottomley
2018-07-10 14:35           ` Jens Axboe
2018-07-10 15:08             ` Martin K. Petersen
2018-10-19  4:50 Stephen Rothwell
2018-10-19  4:54 ` James Bottomley
2018-10-19  4:58   ` Stephen Rothwell
2019-04-05  3:25 Stephen Rothwell
2019-04-05  4:30 ` Bart Van Assche
2019-04-05  4:52   ` James Bottomley
2019-05-31  3:36 Stephen Rothwell
2019-06-03 20:29 ` Tyrel Datwyler
2019-06-03 23:37 ` Tyrel Datwyler
2019-06-20  6:10 Stephen Rothwell
2019-11-07  4:01 Stephen Rothwell
2019-11-07 15:51 ` Bart Van Assche
2019-11-08 23:02   ` James Smart

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git