linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] DRBG: fix maximum value checks on 32 bit systems
Date: Wed, 27 Aug 2014 15:40:06 +0200	[thread overview]
Message-ID: <12812557.76Zd8kO297@tauon> (raw)
In-Reply-To: <20140827133528.GA15871@gondor.apana.org.au>

Am Mittwoch, 27. August 2014, 21:35:28 schrieb Herbert Xu:

Hi Herbert,

>On Tue, Aug 26, 2014 at 11:36:54AM +0200, Stephan Mueller wrote:
>> The max_addtllen and max_req are defined in drbg_cores[] in
>> crypto/drbg.c for each DRBG type. As size_t on a 32 bit system is 32
>> bit the bit shifts would not work either.
>> 
>> Thus, I am wondering whether the just applied patch would need to go
>> to Linus
>> tree too? I would think that the following patch would be in order:
>Have you actually tested this on a 32-bit box? If so and it
>actually works then I'd be happy to push it.

I will have it tested by tomorrow.
>
>Cheers,


Ciao
Stephan

  reply	other threads:[~2014-08-27 13:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26  6:14 linux-next: build warnings after merge of the crypto tree Stephen Rothwell
2014-08-26  6:38 ` Herbert Xu
2014-08-26  7:00   ` Stephan Mueller
2014-08-26  7:31   ` [PATCH] DRBG: fix bit shifting on 32 bit systems Stephan Mueller
2014-08-26  7:32     ` Herbert Xu
2014-08-26  7:37       ` Stephan Mueller
2014-08-26  8:06       ` [PATCH] DRBG: fix maximum value checks " Stephan Mueller
2014-08-26  8:08         ` Herbert Xu
2014-08-26  8:29           ` [PATCH v2] " Stephan Mueller
2014-08-26  8:43             ` Herbert Xu
2014-08-26  8:52               ` Stephan Mueller
2014-08-26  8:58                 ` Herbert Xu
2014-08-26  9:36                   ` Stephan Mueller
2014-08-27 13:35                     ` Herbert Xu
2014-08-27 13:40                       ` Stephan Mueller [this message]
2014-08-28  7:13                       ` Stephan Mueller
2014-08-28  7:17                       ` DRBG: remove test for uninitialized DRBG handle Stephan Mueller
2014-09-01  5:11                         ` [PATCH v2] DRBG: remove check " Stephan Mueller
2014-09-03  1:33                           ` Stephan Mueller
2014-09-03 23:21                             ` Herbert Xu
2014-09-03 23:50                               ` Stephan Mueller
2014-09-05  7:55                                 ` Herbert Xu
2014-09-05 11:25                                   ` Stephan Mueller
2014-09-05  8:13                           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12812557.76Zd8kO297@tauon \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).