From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: linux-next: build failure after merge of the final tree (ubi tree related) Date: Wed, 16 Mar 2011 12:27:37 +0200 Message-ID: <1300271257.2817.8.camel@localhost> References: <20110316175041.67c4f371.sfr@canb.auug.org.au> <1300260170.2817.4.camel@localhost> <1300270508.22236.1168.camel@pasglop> Reply-To: Artem.Bityutskiy@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.nokia.com ([147.243.128.24]:57327 "EHLO mgw-da01.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703Ab1CPKbU (ORCPT ); Wed, 16 Mar 2011 06:31:20 -0400 In-Reply-To: <1300270508.22236.1168.camel@pasglop> Sender: linux-next-owner@vger.kernel.org List-ID: To: Benjamin Herrenschmidt Cc: ext Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org On Wed, 2011-03-16 at 21:15 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2011-03-16 at 09:22 +0200, Artem Bityutskiy wrote: > > On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote: > > > Hi all, > > >=20 > > > After merging the final tree, today's linux-next build (powerpc > > > allyesconfig) failed like this: > > >=20 > > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write': > > > drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first= use in this function) > > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff': > > > drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first= use in this function) > > >=20 > > > Caused by commit 823ed5091113 ("UBI: allocate write checking buff= er on demand"). > > >=20 > > > I don't know how to fix this, so I have left it for today. > >=20 > > Hmm, strange, include should be enough to use > > __vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'= ll > > try to look better. >=20 > Try adding asm/pgtable.h=20 Thanks, that's what I was thinking about as well. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9)