From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] intel_sst: fix compile error Date: Fri, 30 Sep 2011 08:04:55 +0530 Message-ID: <1317350095.1573.1786.camel@vkoul-udesk3> References: <20110930112337.02e0ba383ffd12b6d5d24f39@canb.auug.org.au> <1317350135-15055-1-git-send-email-guanqun.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:17165 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739Ab1I3Cks (ORCPT ); Thu, 29 Sep 2011 22:40:48 -0400 In-Reply-To: <1317350135-15055-1-git-send-email-guanqun.lu@intel.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Lu Guanqun Cc: gregkh@suse.de, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, alan@linux.intel.com, fengguang.wu@intel.com, devel@driverdev.osuosl.org, paul.gortmaker@windriver.com On Fri, 2011-09-30 at 10:35 +0800, Lu Guanqun wrote: > include module.h to fix the following compile errors: > > drivers/staging/intel_sst/intelmid.c:52: error: expected declaration specifiers or '...' before string constant > drivers/staging/intel_sst/intelmid.c:52: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:52: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' > drivers/staging/intel_sst/intelmid.c:52: warning: function declaration isn't a prototype > drivers/staging/intel_sst/intelmid.c:53: error: expected declaration specifiers or '...' before string constant > drivers/staging/intel_sst/intelmid.c:53: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:53: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' > drivers/staging/intel_sst/intelmid.c:53: warning: function declaration isn't a prototype > drivers/staging/intel_sst/intelmid.c:54: error: expected declaration specifiers or '...' before string constant > drivers/staging/intel_sst/intelmid.c:54: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:54: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' > drivers/staging/intel_sst/intelmid.c:54: warning: function declaration isn't a prototype > drivers/staging/intel_sst/intelmid.c:55: error: expected declaration specifiers or '...' before string constant > drivers/staging/intel_sst/intelmid.c:55: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:55: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' > drivers/staging/intel_sst/intelmid.c:55: warning: function declaration isn't a prototype > drivers/staging/intel_sst/intelmid.c:56: error: expected declaration specifiers or '...' before string constant > drivers/staging/intel_sst/intelmid.c:56: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:56: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' > drivers/staging/intel_sst/intelmid.c:56: warning: function declaration isn't a prototype > drivers/staging/intel_sst/intelmid.c:57: error: expected declaration specifiers or '...' before string constant > drivers/staging/intel_sst/intelmid.c:57: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:57: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' > drivers/staging/intel_sst/intelmid.c:57: warning: function declaration isn't a prototype > drivers/staging/intel_sst/intelmid.c:58: error: expected declaration specifiers or '...' before string constant > drivers/staging/intel_sst/intelmid.c:58: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:58: warning: type defaults to 'int' in declaration of 'MODULE_SUPPORTED_DEVICE' > drivers/staging/intel_sst/intelmid.c:58: warning: function declaration isn't a prototype > drivers/staging/intel_sst/intelmid.c:64: error: expected ')' before 'int' > drivers/staging/intel_sst/intelmid.c:65: error: expected ')' before string constant > drivers/staging/intel_sst/intelmid.c:66: error: expected ')' before numeric constant > drivers/staging/intel_sst/intelmid.c:67: error: expected ')' before string constant > drivers/staging/intel_sst/intelmid.c:461: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:461: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > drivers/staging/intel_sst/intelmid.c:461: warning: parameter names (without types) in function declaration > drivers/staging/intel_sst/intelmid.c:475: warning: data definition has no type or storage class > drivers/staging/intel_sst/intelmid.c:475: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' > drivers/staging/intel_sst/intelmid.c:475: warning: parameter names (without types) in function declaration > drivers/staging/intel_sst/intelmid.c: In function 'snd_intelmad_probe': > drivers/staging/intel_sst/intelmid.c:859: error: 'THIS_MODULE' undeclared (first use in this function) > drivers/staging/intel_sst/intelmid.c:859: error: (Each undeclared identifier is reported only once > drivers/staging/intel_sst/intelmid.c:859: error: for each function it appears in.) > drivers/staging/intel_sst/intelmid.c: At top level: > drivers/staging/intel_sst/intelmid.c:989: error: 'THIS_MODULE' undeclared here (not in a function) > > Reported-by: Stephen Rothwell > Signed-off-by: Lu Guanqun > --- > drivers/staging/intel_sst/intelmid.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/intel_sst/intelmid.c b/drivers/staging/intel_sst/intelmid.c > index 25656ad..492b660 100644 > --- a/drivers/staging/intel_sst/intelmid.c > +++ b/drivers/staging/intel_sst/intelmid.c > @@ -27,6 +27,7 @@ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > +#include > #include > #include > #include Thanks I was midway of creating this fix :) Acked-by: Vinod Koul -- ~Vinod