From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linus <torvalds@linux-foundation.org>,
target-devel@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: linux-next: Tree for Oct 25 (target)
Date: Wed, 26 Oct 2011 13:42:12 -0700 [thread overview]
Message-ID: <1319661732.21607.14.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20111027074002.8cd56b32b3f1200070abc4d9@canb.auug.org.au>
On Thu, 2011-10-27 at 07:40 +1100, Stephen Rothwell wrote:
> On Wed, 26 Oct 2011 12:53:11 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> >
> > On Wed, 2011-10-26 at 11:39 -0700, Randy Dunlap wrote:
> > > On 10/25/11 02:36, Stephen Rothwell wrote:
> > > > Hi all,
> > >
> > > target_core_cdb.c needs to include <linux/export.h>:
> > >
> > > drivers/target/target_core_cdb.c:1316:1: warning: data definition has no type or storage class [enabled by default]
> > > drivers/target/target_core_cdb.c:1316:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> > > drivers/target/target_core_cdb.c:1316:1: warning: parameter names (without types) in function declaration [enabled by default]
> > >
> > >
> >
> > This one had been addressed in target-pending.git/for-next with a
> > module.h include for target_core_cdb.c, but I'll change this now to use
> > the proper export.h.
>
> Except that export.h does not exist in Linus' tree yet. Just leave the
> module.h there and it will be changed sometime later.
>
Got it. Thank you for the heads up Stephen.
--nan
next prev parent reply other threads:[~2011-10-26 20:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 9:36 linux-next: Tree for Oct 25 Stephen Rothwell
2011-10-25 9:43 ` Stephen Rothwell
2011-10-25 10:42 ` Stephen Rothwell
2011-10-26 0:34 ` linux-next: Tree for Oct 25 (agp/intel-gtt.c) Randy Dunlap
2011-11-03 21:21 ` Randy Dunlap
2011-10-26 0:42 ` linux-next: Tree for Oct 25 (crypto) Randy Dunlap
2011-10-26 6:27 ` Herbert Xu
2011-10-26 12:33 ` Stefan Richter
2011-10-26 16:27 ` Randy Dunlap
2011-10-26 17:15 ` Stefan Richter
2011-10-27 7:05 ` Valdis.Kletnieks
2011-10-27 7:45 ` Herbert Xu
2011-10-29 23:20 ` Valdis.Kletnieks
2011-10-26 18:26 ` linux-next: Tree for Oct 25 (mfd/ab8500) Randy Dunlap
2011-10-30 23:04 ` Samuel Ortiz
2011-10-26 18:37 ` linux-next: Tree for Oct 25 (pci/ats.c) Randy Dunlap
2011-11-10 13:09 ` Ingo Molnar
2011-10-26 18:39 ` linux-next: Tree for Oct 25 (target) Randy Dunlap
2011-10-26 19:53 ` Nicholas A. Bellinger
2011-10-26 20:40 ` Stephen Rothwell
2011-10-26 20:42 ` Nicholas A. Bellinger [this message]
2011-10-26 18:47 ` linux-next: Tree for Oct 25 (sb_edac.c) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319661732.21607.14.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=target-devel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).