linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Javier Martin <javier.martin@vista-silicon.com>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: linux-next: build failure after merge of the slave-dma tree
Date: Tue, 27 Mar 2012 14:03:14 +0530	[thread overview]
Message-ID: <1332837194.1820.4.camel@vkoul-udesk3> (raw)
In-Reply-To: <20120327115232.ef58a6f97da2d29ed3c8bdb6@canb.auug.org.au>

On Tue, 2012-03-27 at 11:52 +1100, Stephen Rothwell wrote:
> Hi Vinod,
> 
> After merging the slave-dma tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/dma/imx-dma.c:31:22: fatal error: mach/dma.h: No such file or directory
> 
> Caused by commit 6bd081277ea0 ("dmaengine: imx-dma: merge old dma-v1.c
> with imx-dma.c").
Thanks Stephen,

This should have depends on ARCH_MXS at least and should not have built
for x86_64. Below patch should fix it and I will apply this.

> 
> I have used the slave-dma tree from next-20120326 for today.
> 
> I was wondering why this new work appeared during the merge window ...
I had this series pending and wanted to get this merged but it didn't
apply for me last week and I was out for the long weekend :(
So merged on first chance I got back.

Tree is frozen now, barring any other hiccups. Sorry for the issue
--------------------------------x-------------------x----------------------

>From 9da98b21787488f9d99b7f93b42aee95bfd07c49 Mon Sep 17 00:00:00 2001
From: Vinod Koul <vinod.koul@linux.intel.com>
Date: Tue, 27 Mar 2012 13:53:00 +0530
Subject: [PATCH] dmaengine: imx: fix the build failure on x64

commit 6bd081277ea0 "dmaengine: imx-dma: merge old dma-v1.c with
imx-dma.c" removed the dependency in config for the imx dma driver,
whereas it should depend on ARCH_MXS

Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
---
 drivers/dma/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index b4a53a0..34e48d9 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -230,6 +230,7 @@ config IMX_SDMA
 
 config IMX_DMA
 	tristate "i.MX DMA support"
+	depends on ARCH_MXC
 	select DMA_ENGINE
 	help
 	  Support the i.MX DMA engine. This engine is integrated into
-- 
1.7.0.4


-- 
~Vinod

  reply	other threads:[~2012-03-27  8:30 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  0:52 linux-next: build failure after merge of the slave-dma tree Stephen Rothwell
2012-03-27  8:33 ` Vinod Koul [this message]
2012-06-22  3:00 Stephen Rothwell
2012-06-22  5:01 ` Vinod Koul
2012-06-25  1:21   ` Zhangfei Gao
2013-01-07  0:26 Stephen Rothwell
2013-01-07 14:00 ` Vinod Koul
2013-04-02  1:57 Stephen Rothwell
2013-04-02  1:38 ` Vinod Koul
2014-07-28  2:18 Stephen Rothwell
2014-07-28  7:16 ` Vinod Koul
2014-07-28 11:56   ` Maxime Ripard
2014-09-12  3:17 Stephen Rothwell
2014-09-15  9:51 ` Geert Uytterhoeven
2014-11-10  0:58 Stephen Rothwell
2014-11-10  5:06 ` Vinod Koul
2014-11-12 13:23   ` Ludovic Desroches
2014-12-09  3:48 Stephen Rothwell
2014-12-09  4:47 ` Vinod Koul
2015-02-16  1:09 Stephen Rothwell
2015-02-16  1:48 ` Yibin Gong
2015-02-16  4:06   ` Vinod Koul
2015-08-06  2:22 Stephen Rothwell
2015-08-06  3:00 ` Vinod Koul
2015-08-24  6:53   ` Maxime Ripard
2015-08-24  8:11     ` Vinod Koul
2015-08-24  9:21       ` Maxime Ripard
2015-10-15  0:51 Stephen Rothwell
2015-10-15  3:35 ` Koul, Vinod
2015-10-15  3:51   ` Stephen Rothwell
2015-10-15 14:07     ` Arnd Bergmann
2015-10-15 14:27       ` Stephen Rothwell
2016-09-16  3:18 Stephen Rothwell
2016-09-16  8:34 ` Peter Griffin
2016-09-19 16:38   ` Vinod Koul
2017-08-22  5:36 Stephen Rothwell
2017-08-22 16:39 ` Vinod Koul
2018-10-04  5:44 Stephen Rothwell
2018-10-04  6:13 ` Vinod
2019-07-04  7:31 Stephen Rothwell
2019-07-06 13:43 ` Robin Gong
2019-07-06 14:43   ` Vinod Koul
2019-07-08  2:01     ` Robin Gong
2019-07-08  4:09       ` Vinod Koul
2019-07-08  1:22 ` Robin Gong
2019-07-08  3:06   ` zhangfei
2019-07-08  4:17     ` Vinod Koul
2019-07-08  4:54       ` Robin Gong
2019-07-08  4:48     ` Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332837194.1820.4.camel@vkoul-udesk3 \
    --to=vinod.koul@linux.intel.com \
    --cc=javier.martin@vista-silicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).