From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Westphal <fw@strlen.de>
Subject: [PATCH] netfilter: fix missing dependencies for NETFILTER_XT_MATCH_CONNLABEL
Date: Sun, 3 Feb 2013 12:24:07 +0100 [thread overview]
Message-ID: <1359890647-25846-1-git-send-email-fw@strlen.de> (raw)
In-Reply-To: <510DC976.7000008@infradead.org>
It was possible to set
NF_CONNTRACK=n
NF_CONNTRACK_LABELS=y
via NETFILTER_XT_MATCH_CONNLABEL=y:
warning: (NETFILTER_XT_MATCH_CONNLABEL) selects NF_CONNTRACK_LABELS which has
unmet direct dependencies (NET && INET && NETFILTER && NF_CONNTRACK)
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
---
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index eb2c8eb..d4dd702 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -860,6 +860,7 @@ config NETFILTER_XT_MATCH_CONNBYTES
config NETFILTER_XT_MATCH_CONNLABEL
tristate '"connlabel" match support'
select NF_CONNTRACK_LABELS
+ depends on NF_CONNTRACK
depends on NETFILTER_ADVANCED
---help---
This match allows you to test and assign userspace-defined labels names
--
1.7.8.6
next prev parent reply other threads:[~2013-02-03 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 13:51 linux-next: Tree for Feb 2 Stephen Rothwell
2013-02-03 2:20 ` linux-next: Tree for Feb 2 (netfilter) Randy Dunlap
2013-02-03 11:24 ` Florian Westphal [this message]
2013-02-03 16:04 ` [PATCH] netfilter: fix missing dependencies for NETFILTER_XT_MATCH_CONNLABEL Randy Dunlap
2013-02-05 3:00 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359890647-25846-1-git-send-email-fw@strlen.de \
--to=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).