* [PATCH] PowerCap: Replace dev_attrs with dev_groups
@ 2013-10-25 22:14 Srinivas Pandruvada
2013-10-25 22:30 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Pandruvada @ 2013-10-25 22:14 UTC (permalink / raw)
To: linux-next
Cc: broonie, rdunlap, rafael.j.wysocki, jacob.jun.pan,
thierry.reding, Srinivas Pandruvada
struct class no longer contains dev_attrs field. Replace dev_attrs
with dev_groups field.
This caused compile error on latest linux-next tree.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/powercap/powercap_sys.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
index c22fa4c..af07211 100644
--- a/drivers/powercap/powercap_sys.c
+++ b/drivers/powercap/powercap_sys.c
@@ -471,17 +471,18 @@ static ssize_t enabled_store(struct device *dev,
return -ENOSYS;
}
+static DEVICE_ATTR_RW(enabled);
-static struct device_attribute powercap_def_attrs[] = {
- __ATTR(enabled, S_IWUSR | S_IRUGO, enabled_show,
- enabled_store),
- __ATTR_NULL
+static struct attribute *powercap_dev_attrs[] = {
+ &dev_attr_enabled.attr,
+ NULL
};
+ATTRIBUTE_GROUPS(powercap_dev);
static struct class powercap_class = {
.name = "powercap",
.dev_release = powercap_release,
- .dev_attrs = powercap_def_attrs,
+ .dev_groups = powercap_dev_groups,
};
struct powercap_zone *powercap_register_zone(
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PowerCap: Replace dev_attrs with dev_groups
2013-10-25 22:14 [PATCH] PowerCap: Replace dev_attrs with dev_groups Srinivas Pandruvada
@ 2013-10-25 22:30 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2013-10-25 22:30 UTC (permalink / raw)
To: Srinivas Pandruvada, linux-next
Cc: broonie, rafael.j.wysocki, jacob.jun.pan, thierry.reding
On 10/25/13 15:14, Srinivas Pandruvada wrote:
> struct class no longer contains dev_attrs field. Replace dev_attrs
> with dev_groups field.
> This caused compile error on latest linux-next tree.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/powercap/powercap_sys.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c
> index c22fa4c..af07211 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -471,17 +471,18 @@ static ssize_t enabled_store(struct device *dev,
>
> return -ENOSYS;
> }
> +static DEVICE_ATTR_RW(enabled);
>
> -static struct device_attribute powercap_def_attrs[] = {
> - __ATTR(enabled, S_IWUSR | S_IRUGO, enabled_show,
> - enabled_store),
> - __ATTR_NULL
> +static struct attribute *powercap_dev_attrs[] = {
> + &dev_attr_enabled.attr,
> + NULL
> };
> +ATTRIBUTE_GROUPS(powercap_dev);
>
> static struct class powercap_class = {
> .name = "powercap",
> .dev_release = powercap_release,
> - .dev_attrs = powercap_def_attrs,
> + .dev_groups = powercap_dev_groups,
> };
>
> struct powercap_zone *powercap_register_zone(
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-25 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-25 22:14 [PATCH] PowerCap: Replace dev_attrs with dev_groups Srinivas Pandruvada
2013-10-25 22:30 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).