linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Zhong <zhong@linux.vnet.ibm.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-next list <linux-next@vger.kernel.org>
Subject: Re: [RFC PATCH next] fix unpaired rcu lock in prepend_path()
Date: Thu, 14 Nov 2013 10:17:51 +0800	[thread overview]
Message-ID: <1384395471.2497.6.camel@ThinkPad-T5421> (raw)
In-Reply-To: <20131113122848.GZ13318@ZenIV.linux.org.uk>

On Wed, 2013-11-13 at 12:28 +0000, Al Viro wrote:
> On Wed, Nov 13, 2013 at 03:21:51PM +0800, Li Zhong wrote:
> > The patch tries to fix following complaint(next-1112) caused by unpaired
> > rcu_read_lock/unlock in function prepend_path():
> 
> Frankly, I wonder if it wouldn't be better to shift rcu_read_unlock()
> past the second done_seqretry() in there...

Do you mean we have rcu_read_lock/unlock outside of the goto loops? 

It seems to me it would cause the two locks(mount,rename) potentially
acquired inside rcu read lock. Or did I misunderstand something here?

Thanks,
Zhong
> 

      reply	other threads:[~2013-11-14  2:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13  7:21 [RFC PATCH next] fix unpaired rcu lock in prepend_path() Li Zhong
2013-11-13 12:28 ` Al Viro
2013-11-14  2:17   ` Li Zhong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384395471.2497.6.camel@ThinkPad-T5421 \
    --to=zhong@linux.vnet.ibm.com \
    --cc=linux-next@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).