From: Frank Haverkamp <haver@linux.vnet.ibm.com>
To: gregkh@linuxfoundation.org
Cc: jim.epost@gmail.com, sfr@canb.auug.org.au,
fengguang.wu@intel.com, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, kbuild-all@01.org,
haver@linux.vnet.ibm.com
Subject: [PATCH] GenWQE: Accidently casting to u32 where u64 is required
Date: Fri, 20 Dec 2013 20:27:20 +0100 [thread overview]
Message-ID: <1387567640-25413-1-git-send-email-haver@linux.vnet.ibm.com> (raw)
In-Reply-To: <1387566773.1847.28.camel@oc7383187364.ibm.com>
Fix a casting to u32 where u64 would be appropriate.
The bad casting made the driver unusable.
Signed-off-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
---
drivers/misc/genwqe/card_utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -59,7 +59,7 @@ int __genwqe_writeq(struct genwqe_dev *c
if (cd->mmio == NULL)
return -EIO;
- __raw_writeq((__force u32)cpu_to_be64(val), cd->mmio + byte_offs);
+ __raw_writeq((__force u64)cpu_to_be64(val), cd->mmio + byte_offs);
return 0;
}
next prev parent reply other threads:[~2013-12-20 19:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 14:17 randconfig build error with next-20131220, in drivers/misc/genwqe/genwqe_driver.h Jim Davis
2013-12-20 15:26 ` [PATCH 1/2] GenWQE: Fix endian issues detected by sparse Frank Haverkamp
2013-12-20 16:47 ` Greg KH
2013-12-20 19:12 ` Frank Haverkamp
2013-12-20 19:27 ` Frank Haverkamp [this message]
2014-01-07 6:41 ` Dan Carpenter
2014-01-07 12:30 ` Frank Haverkamp
2014-01-07 12:45 ` Dan Carpenter
2014-01-07 14:39 ` Frank Haverkamp
2014-01-07 14:41 ` [PATCH 1/3] GenWQE: Rework return code for flash-update ioctl Frank Haverkamp
2014-01-07 14:41 ` [PATCH 2/3] GenWQE: Fix compile problems for Alpha Frank Haverkamp
2014-01-07 14:41 ` [PATCH 3/3] GenWQE: Fix warnings for sparc Frank Haverkamp
2013-12-20 15:26 ` [PATCH 2/2] GenWQE: Replace dynamic_hex_dump with print_hex_dump_debug Frank Haverkamp
2013-12-20 15:33 ` Greg KH
2013-12-20 15:49 ` Frank Haverkamp
2013-12-20 15:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387567640-25413-1-git-send-email-haver@linux.vnet.ibm.com \
--to=haver@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jim.epost@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--subject='Re: [PATCH] GenWQE: Accidently casting to u32 where u64 is required' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).